public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Alexander Kuzmenkov <[email protected]>
Cc: Ashutosh Sharma <[email protected]>
Subject: Re: Assertion failure in hash_kill_items()
Date: Tue, 17 Mar 2026 16:50:54 -0400
Message-ID: <myvvesyyicj4frh72p42vnnipkfzbwxe7fo3qrquofucfcngn7@ltlajx2yt2m3> (raw)
In-Reply-To: <p45puiwvjtbeff6cx2suwk3i35zubdot6iaa3z6buiqnoix7v6@hzygqumsgome>
References: <[email protected]>
	<p45puiwvjtbeff6cx2suwk3i35zubdot6iaa3z6buiqnoix7v6@hzygqumsgome>

Hi,

On 2026-03-17 13:40:10 -0400, Andres Freund wrote:
> On 2026-03-17 19:15:10 +0200, Heikki Linnakangas wrote:
> > I bumped into an assertion failure, while playing with variants of the test
> > case that Alexander Kuzmenkov wrote to exercise hash index page cleanup [1].
> > This is master-only, related to the recent changes in how buffers are marked
> > dirty.
> 
> Sorry, I had hoped to push a fix for that already, after it was reported in
>   https://postgr.es/m/vjtmvwvbxt7w5uyacxpzibpj65ewcb7uqaqbhd4arvnjbp5jqz%405ksdh6fsyqve
> but real life intervened.
> 
> I was planning to commit it together with an addition to
>   src/test/modules/index/specs/killtuples.spec
> 
> Unfortunately that made the change a good bit more verbose, as a naive
> addition would report a number of buffer accesses that seemed not necessarily
> reliable to me.   So I updated the 'result' step to just return true/false
> depending on whether there were any accesses.
> 
> I'll go and work on pushing that.

Done, as of f5eb854ab6d.

Greetings,

Andres

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Assertion failure in hash_kill_items()
  In-Reply-To: <myvvesyyicj4frh72p42vnnipkfzbwxe7fo3qrquofucfcngn7@ltlajx2yt2m3>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox