agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Melanie Plageman <melanieplageman@gmail.com>
Subject: [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
Date: Tue, 2 Sep 2025 11:00:44 -0400

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft

view thread (210+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: melanieplageman@gmail.com
  Subject: Re: [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
  In-Reply-To: <no-message-id-1058045@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox