agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

[PATCH v38 05/11] Add Incremental View Maintenance support to psql
107+ messages / 2 participants
[nested] [flat]

* [PATCH v38 05/11] Add Incremental View Maintenance support to psql
@ 2026-05-29 09:05 Yugo Nagata <nagata@sraoss.co.jp>
  0 siblings, 0 replies; 107+ messages in thread

From: Yugo Nagata @ 2026-05-29 09:05 UTC (permalink / raw)

Add tab completion and meta-command output for IVM.
---
 src/bin/psql/describe.c        | 32 +++++++++++++++++++++++++++++++-
 src/bin/psql/tab-complete.in.c | 30 ++++++++++++++++++------------
 2 files changed, 49 insertions(+), 13 deletions(-)

diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index af3935b0078..ad5c8274af0 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -1634,6 +1634,7 @@ describeOneTableDetails(const char *schemaname,
 		char		relpersistence;
 		char		relreplident;
 		char	   *relam;
+		bool		isivm;
 	}			tableinfo;
 	bool		show_column_details = false;
 
@@ -1648,7 +1649,26 @@ describeOneTableDetails(const char *schemaname,
 	/* Get general table info */
 	printfPQExpBuffer(&buf, "/* %s */\n",
 					  _("Get general information about one relation"));
-	if (pset.sversion >= 120000)
+	if (pset.sversion >= 200000)
+	{
+		printfPQExpBuffer(&buf,
+						  "SELECT c.relchecks, c.relkind, c.relhasindex, c.relhasrules, "
+						  "c.relhastriggers, c.relrowsecurity, c.relforcerowsecurity, "
+						  "false AS relhasoids, c.relispartition, %s, c.reltablespace, "
+						  "CASE WHEN c.reloftype = 0 THEN '' ELSE c.reloftype::pg_catalog.regtype::pg_catalog.text END, "
+						  "c.relpersistence, c.relreplident, am.amname, "
+						  "c.relisivm\n"
+						  "FROM pg_catalog.pg_class c\n "
+						  "LEFT JOIN pg_catalog.pg_class tc ON (c.reltoastrelid = tc.oid)\n"
+						  "LEFT JOIN pg_catalog.pg_am am ON (c.relam = am.oid)\n"
+						  "WHERE c.oid = '%s';",
+						  (verbose ?
+						   "pg_catalog.array_to_string(c.reloptions || "
+						   "array(select 'toast.' || x from pg_catalog.unnest(tc.reloptions) x), ', ')\n"
+						   : "''"),
+						  oid);
+	}
+	else if (pset.sversion >= 120000)
 	{
 		appendPQExpBuffer(&buf,
 						  "SELECT c.relchecks, c.relkind, c.relhasindex, c.relhasrules, "
@@ -1768,6 +1788,10 @@ describeOneTableDetails(const char *schemaname,
 			NULL : pg_strdup(PQgetvalue(res, 0, 14));
 	else
 		tableinfo.relam = NULL;
+	if (pset.sversion >= 200000)
+		tableinfo.isivm = strcmp(PQgetvalue(res, 0, 15), "t") == 0;
+	else
+		tableinfo.isivm = false;
 	PQclear(res);
 	res = NULL;
 
@@ -3830,6 +3854,12 @@ describeOneTableDetails(const char *schemaname,
 			printfPQExpBuffer(&buf, _("Access method: %s"), tableinfo.relam);
 			printTableAddFooter(&cont, buf.data);
 		}
+
+		/* Incremental view maintance info */
+		if (verbose && tableinfo.relkind == RELKIND_MATVIEW && tableinfo.isivm)
+		{
+			printTableAddFooter(&cont, _("Incremental view maintenance: yes"));
+		}
 	}
 
 	/* reloptions, if verbose */
diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 46b9add0604..e5ef41710a0 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -1334,6 +1334,7 @@ static const pgsql_thing_t words_after_create[] = {
 	{"FOREIGN TABLE", NULL, NULL, NULL},
 	{"FUNCTION", NULL, NULL, Query_for_list_of_functions},
 	{"GROUP", Query_for_list_of_roles},
+	{"INCREMENTAL MATERIALIZED VIEW", NULL, NULL, &Query_for_list_of_matviews, NULL, THING_NO_DROP | THING_NO_ALTER},
 	{"INDEX", NULL, NULL, &Query_for_list_of_indexes},
 	{"LANGUAGE", Query_for_list_of_languages},
 	{"LARGE OBJECT", NULL, NULL, NULL, NULL, THING_NO_CREATE | THING_NO_DROP},
@@ -4256,28 +4257,33 @@ match_previous_words(int pattern_id,
 		COMPLETE_WITH("SELECT");
 
 /* CREATE MATERIALIZED VIEW */
-	else if (Matches("CREATE", "MATERIALIZED"))
+	else if (Matches("CREATE", "MATERIALIZED") ||
+			 Matches("CREATE", "INCREMENTAL", "MATERIALIZED"))
 		COMPLETE_WITH("VIEW");
-	/* Complete CREATE MATERIALIZED VIEW <name> with AS or USING */
-	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny))
-		COMPLETE_WITH("AS", "USING");
 
+	/* Complete CREATE [INCREMENTAL] MATERIALIZED VIEW <name> with AS or USING */
+	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny) ||
+			 Matches("CREATE", "INCREMENTAL", "MATERIALIZED", "VIEW", MatchAny))
+		COMPLETE_WITH("AS", "USING");
 	/*
-	 * Complete CREATE MATERIALIZED VIEW <name> USING with list of access
-	 * methods
+	 * Complete CREATE [INCREMENTAL] MATERIALIZED VIEW <name> USING with list
+	 * of access methods
 	 */
-	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "USING"))
+	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "USING") ||
+			 Matches("CREATE", "INCREMENTAL", "MATERIALIZED", "VIEW", MatchAny, "USING"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_table_access_methods);
-	/* Complete CREATE MATERIALIZED VIEW <name> USING <access method> with AS */
-	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "USING", MatchAny))
+	/* Complete CREATE [INCREMENTAL] MATERIALIZED VIEW <name> USING <am> with AS */
+	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "USING", MatchAny) ||
+			 Matches("CREATE", "INCREMENTAL", "MATERIALIZED", "VIEW", MatchAny, "USING", MatchAny))
 		COMPLETE_WITH("AS");
-
 	/*
-	 * Complete CREATE MATERIALIZED VIEW <name> [USING <access method> ] AS
+	 * Complete CREATE [INCREMENTAL] MATERIALIZED VIEW <name> [USING <am>] AS
 	 * with "SELECT"
 	 */
 	else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "AS") ||
-			 Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "USING", MatchAny, "AS"))
+			 Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "USING", MatchAny, "AS") ||
+			 Matches("CREATE", "INCREMENTAL", "MATERIALIZED", "VIEW", MatchAny, "AS") ||
+			 Matches("CREATE", "INCREMENTAL", "MATERIALIZED", "VIEW", MatchAny, "USING", MatchAny, "AS"))
 		COMPLETE_WITH("SELECT");
 
 /* CREATE EVENT TRIGGER */
-- 
2.43.0


--Multipart=_Wed__1_Jul_2026_00_04_01_+0900_OVSy2WWK_9aByzDJ
Content-Type: text/x-diff;
 name="v38-0004-Add-Incremental-View-Maintenance-support-to-pg_d.patch"
Content-Disposition: attachment;
 filename="v38-0004-Add-Incremental-View-Maintenance-support-to-pg_d.patch"
Content-Transfer-Encoding: 7bit



^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24 Reviewer <review@example.com>
  0 siblings, 0 replies; 107+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 107+ messages in thread