agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

[PATCH v2 4/4] xml2: Avoid libxml leaks in pgxml_xpath() error paths
101+ messages / 2 participants
[nested] [flat]

* [PATCH v2 4/4] xml2: Avoid libxml leaks in pgxml_xpath() error paths
@ 2026-06-01 22:41  Andrey Chernyy <andrey.cherny@tantorlabs.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Andrey Chernyy @ 2026-06-01 22:41 UTC (permalink / raw)

pgxml_xpath() builds an xpath_workspace before returning it to
callers.  If an ERROR is thrown before the function returns, callers
have not received the workspace pointer yet and cannot run
cleanup_workspace().

Add local error cleanup for the partially built workspace and the
compiled XPath expression.  Also check xmlXPathNewContext() before
dereferencing the returned context.
---
 contrib/xml2/xpath.c | 51 +++++++++++++++++++++++++++-----------------
 1 file changed, 32 insertions(+), 19 deletions(-)

diff --git a/contrib/xml2/xpath.c b/contrib/xml2/xpath.c
index 9fe75cb5ff4..283bb51178d 100644
--- a/contrib/xml2/xpath.c
+++ b/contrib/xml2/xpath.c
@@ -497,36 +497,49 @@ static xpath_workspace *
 pgxml_xpath(text *document, xmlChar *xpath, PgXmlErrorContext *xmlerrcxt)
 {
 	int32		docsize = VARSIZE_ANY_EXHDR(document);
-	xmlXPathCompExprPtr comppath;
+	xmlXPathCompExprPtr volatile comppath = NULL;
 	xpath_workspace *workspace = palloc0_object(xpath_workspace);
 
 	workspace->doctree = NULL;
 	workspace->ctxt = NULL;
 	workspace->res = NULL;
 
-	workspace->doctree = xmlReadMemory((char *) VARDATA_ANY(document),
-									   docsize, NULL, NULL,
-									   XML_PARSE_NOENT);
-	if (workspace->doctree != NULL)
+	PG_TRY();
 	{
-		workspace->ctxt = xmlXPathNewContext(workspace->doctree);
-		workspace->ctxt->node = xmlDocGetRootElement(workspace->doctree);
-
-		/* compile the path */
-		comppath = xmlXPathCtxtCompile(workspace->ctxt, xpath);
-		if (comppath == NULL || pg_xml_error_occurred(xmlerrcxt))
+		workspace->doctree = xmlReadMemory((char *) VARDATA_ANY(document),
+										   docsize, NULL, NULL,
+										   XML_PARSE_NOENT);
+		if (workspace->doctree != NULL)
 		{
-			if (comppath != NULL)
-				xmlXPathFreeCompExpr(comppath);
-			xml_ereport(xmlerrcxt, ERROR, ERRCODE_INVALID_ARGUMENT_FOR_XQUERY,
-						"XPath Syntax Error");
-		}
+			workspace->ctxt = xmlXPathNewContext(workspace->doctree);
+			if (workspace->ctxt == NULL)
+				xml_ereport(xmlerrcxt, ERROR, ERRCODE_OUT_OF_MEMORY,
+							"could not allocate XPath context");
 
-		/* Now evaluate the path expression. */
-		workspace->res = xmlXPathCompiledEval(comppath, workspace->ctxt);
+			workspace->ctxt->node = xmlDocGetRootElement(workspace->doctree);
+
+			/* compile the path */
+			comppath = xmlXPathCtxtCompile(workspace->ctxt, xpath);
+			if (comppath == NULL || pg_xml_error_occurred(xmlerrcxt))
+				xml_ereport(xmlerrcxt, ERROR, ERRCODE_INVALID_ARGUMENT_FOR_XQUERY,
+							"XPath Syntax Error");
+
+			/* Now evaluate the path expression. */
+			workspace->res = xmlXPathCompiledEval(comppath, workspace->ctxt);
+
+			xmlXPathFreeCompExpr(comppath);
+			comppath = NULL;
+		}
+	}
+	PG_CATCH();
+	{
+		if (comppath != NULL)
+			xmlXPathFreeCompExpr(comppath);
+		cleanup_workspace(workspace);
 
-		xmlXPathFreeCompExpr(comppath);
+		PG_RE_THROW();
 	}
+	PG_END_TRY();
 
 	return workspace;
 }
-- 
2.54.0


--MP_/LMSk9=uMhuQ1QiIJDarDO8G--






^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v3 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 104 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 66 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..8802c6f8098 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,9 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +113,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +169,9 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +213,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +263,9 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +310,9 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +343,11 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
+	lo_set_int_arg(&argv[1], offset);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +385,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +425,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +467,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +498,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +536,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +568,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--6CoALBM/+cswbGQ8--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread

* [PATCH v4 3/3] add helper functions for fast-path arg setup
@ 2026-06-02 18:24  Reviewer <review@example.com>
  0 siblings, 0 replies; 101+ messages in thread

From: Reviewer @ 2026-06-02 18:24 UTC (permalink / raw)

---
 src/interfaces/libpq/fe-lobj.c | 110 ++++++++++++---------------------
 1 file changed, 38 insertions(+), 72 deletions(-)

diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
index 42b2a36bda9..e8f6d958e84 100644
--- a/src/interfaces/libpq/fe-lobj.c
+++ b/src/interfaces/libpq/fe-lobj.c
@@ -44,6 +44,22 @@
 static int	lo_initialize(PGconn *conn);
 static Oid	lo_import_internal(PGconn *conn, const char *filename, Oid oid);
 
+static inline void
+lo_set_int_arg(PQArgBlock *arg, int value)
+{
+	arg->isint = 1;
+	arg->len = 4;
+	arg->u.integer = value;
+}
+
+static inline void
+lo_set_ptr_arg(PQArgBlock *arg, const void *ptr, int len)
+{
+	arg->isint = 0;
+	arg->len = len;
+	arg->u.ptr = (int *) unconstify(void *, ptr);
+}
+
 /*
  * lo_open
  *	  opens an existing large object
@@ -62,13 +78,8 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = mode;
+	lo_set_int_arg(&argv[0], lobjId);
+	lo_set_int_arg(&argv[1], mode);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_open, &fd, -1, &result_len, 1, argv, 2);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -101,9 +112,7 @@ lo_close(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_close,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -159,13 +168,8 @@ lo_truncate(PGconn *conn, int fd, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -207,14 +211,10 @@ lo_truncate64(PGconn *conn, int fd, int64_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	len = pg_hton64(len);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &len;
+	lo_set_ptr_arg(&argv[1], &len, 8);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_truncate64,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -261,13 +261,8 @@ lo_read(PGconn *conn, int fd, char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = (int) len;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_read,
 				(void *) buf, len, &result_len, 0, argv, 2);
@@ -312,13 +307,8 @@ lo_write(PGconn *conn, int fd, const char *buf, size_t len)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 0;
-	argv[1].len = (int) len;
-	argv[1].u.ptr = (int *) unconstify(char *, buf);
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_ptr_arg(&argv[1], buf, (int) len);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_write,
 				&retval, -1, &result_len, 1, argv, 2);
@@ -349,17 +339,9 @@ lo_lseek(PGconn *conn, int fd, int offset, int whence)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
-
-	argv[1].isint = 1;
-	argv[1].len = 4;
-	argv[1].u.integer = offset;
-
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[0], fd);
+	lo_set_int_arg(&argv[1], offset);
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek,
 				&retval, -1, &result_len, 1, argv, 3);
@@ -397,18 +379,12 @@ lo_lseek64(PGconn *conn, int fd, int64_t offset, int whence)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	offset = pg_hton64(offset);
-	argv[1].isint = 0;
-	argv[1].len = 8;
-	argv[1].u.ptr = (int *) &offset;
+	lo_set_ptr_arg(&argv[1], &offset, 8);
 
-	argv[2].isint = 1;
-	argv[2].len = 4;
-	argv[2].u.integer = whence;
+	lo_set_int_arg(&argv[2], whence);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_lseek64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 3);
@@ -443,9 +419,7 @@ lo_creat(PGconn *conn, int mode)
 	if (lo_initialize(conn) < 0)
 		return InvalidOid;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = mode;
+	lo_set_int_arg(&argv[0], mode);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_creat,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -487,9 +461,7 @@ lo_create(PGconn *conn, Oid lobjId)
 		return InvalidOid;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_create,
 				&retval, -1, &result_len, 1, argv, 1);
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
@@ -520,9 +492,7 @@ lo_tell(PGconn *conn, int fd)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell,
 				&retval, -1, &result_len, 1, argv, 1);
@@ -560,9 +530,7 @@ lo_tell64(PGconn *conn, int fd)
 		return -1;
 	}
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = fd;
+	lo_set_int_arg(&argv[0], fd);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_tell64,
 				(void *) &retval, sizeof(retval), &result_len, 0, argv, 1);
@@ -594,9 +562,7 @@ lo_unlink(PGconn *conn, Oid lobjId)
 	if (lo_initialize(conn) < 0)
 		return -1;
 
-	argv[0].isint = 1;
-	argv[0].len = 4;
-	argv[0].u.integer = lobjId;
+	lo_set_int_arg(&argv[0], lobjId);
 
 	res = PQnfn(conn, conn->lobjfuncs->fn_lo_unlink,
 				&retval, -1, &result_len, 1, argv, 1);
-- 
2.50.1 (Apple Git-155)


--Z10p9YYojB0/BzD2--





^ permalink  raw  reply  [nested|flat] 101+ messages in thread