pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedfixes for a few GUC descriptions
8+ messages / 5 participants
[nested] [flat]
* fixes for a few GUC descriptions
@ 2026-09-10 21:41 Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-09-10 21:41 UTC (permalink / raw)
To: pgsql-hackers
Some new parameters added since commit 977d865c36 do not follow the GUC
description rules established by that commit. I've attached a patch to fix
them.
--
nathan
From a5a85c3f701631e148fe05613b0ec0b7d83776eb Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Thu, 10 Sep 2026 16:35:45 -0500
Subject: [PATCH v1 1/1] Describe special values in more GUC descriptions.
Commit 977d865c36 established some rules for mentioning special
values (e.g., -1, 0, an empty string) in GUC descriptions. A few
parameters either neglect to mention their special values or
describe them in a way that doesn't follow those rules. Most of
these parameters were added after the aforementioned commit, but
one was simply missed. This commit fixes them.
---
src/backend/utils/misc/guc_parameters.dat | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/backend/utils/misc/guc_parameters.dat b/src/backend/utils/misc/guc_parameters.dat
index 93a434858bf..9f2d739ebc3 100644
--- a/src/backend/utils/misc/guc_parameters.dat
+++ b/src/backend/utils/misc/guc_parameters.dat
@@ -1303,6 +1303,7 @@
{ name => 'idle_replication_slot_timeout', type => 'int', context => 'PGC_SIGHUP', group => 'REPLICATION_SENDING',
short_desc => 'Sets the duration a replication slot can remain idle before it is invalidated.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_S',
variable => 'idle_replication_slot_timeout_secs',
boot_val => '0',
@@ -1389,6 +1390,7 @@
{ name => 'io_max_concurrency', type => 'int', context => 'PGC_POSTMASTER', group => 'RESOURCES_IO',
short_desc => 'Max number of IOs that one process can execute simultaneously.',
+ long_desc => '-1 means use a value based on "shared_buffers" and the maximum number of processes.',
variable => 'io_max_concurrency',
boot_val => '-1',
min => '-1',
@@ -1876,7 +1878,7 @@
{ name => 'log_statement_max_length', type => 'int', context => 'PGC_SUSET', group => 'LOGGING_WHAT',
short_desc => 'Sets the maximum length in bytes of logged statement text.',
- long_desc => '-1 means log statement in full; 0 means log only an ellipsis.',
+ long_desc => '-1 means log statements in full. 0 means log only an ellipsis.',
flags => 'GUC_UNIT_BYTE',
variable => 'log_statement_max_length',
boot_val => '-1',
@@ -2368,7 +2370,7 @@
{ name => 'password_expiration_warning_threshold', type => 'int', context => 'PGC_SIGHUP', group => 'CONN_AUTH_AUTH',
short_desc => 'Threshold for password expiration warnings.',
- long_desc => '0 means not to emit these warnings.',
+ long_desc => '0 disables these warnings.',
flags => 'GUC_UNIT_S',
variable => 'password_expiration_warning_threshold',
boot_val => '604800',
@@ -3580,7 +3582,7 @@
{ name => 'wal_sender_shutdown_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time the server waits during shutdown for all WAL data to be replicated to the receiver.',
- long_desc => '-1 disables the timeout and waits for the receiver to catch up; 0 does not wait for the receiver to catch up.',
+ long_desc => '-1 disables the timeout. 0 means do not wait for the receiver to catch up.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_shutdown_timeout',
boot_val => '-1',
@@ -3590,6 +3592,7 @@
{ name => 'wal_sender_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time to wait for WAL replication.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_timeout',
boot_val => '60 * 1000',
--
2.55.0
Attachments:
[text/plain] v1-0001-Describe-special-values-in-more-GUC-descriptions.patch (3.4K, ../../aqMkIpRr62cVqtCZ@nathan/2-v1-0001-Describe-special-values-in-more-GUC-descriptions.patch)
download | inline diff:
From a5a85c3f701631e148fe05613b0ec0b7d83776eb Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Thu, 10 Sep 2026 16:35:45 -0500
Subject: [PATCH v1 1/1] Describe special values in more GUC descriptions.
Commit 977d865c36 established some rules for mentioning special
values (e.g., -1, 0, an empty string) in GUC descriptions. A few
parameters either neglect to mention their special values or
describe them in a way that doesn't follow those rules. Most of
these parameters were added after the aforementioned commit, but
one was simply missed. This commit fixes them.
---
src/backend/utils/misc/guc_parameters.dat | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/backend/utils/misc/guc_parameters.dat b/src/backend/utils/misc/guc_parameters.dat
index 93a434858bf..9f2d739ebc3 100644
--- a/src/backend/utils/misc/guc_parameters.dat
+++ b/src/backend/utils/misc/guc_parameters.dat
@@ -1303,6 +1303,7 @@
{ name => 'idle_replication_slot_timeout', type => 'int', context => 'PGC_SIGHUP', group => 'REPLICATION_SENDING',
short_desc => 'Sets the duration a replication slot can remain idle before it is invalidated.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_S',
variable => 'idle_replication_slot_timeout_secs',
boot_val => '0',
@@ -1389,6 +1390,7 @@
{ name => 'io_max_concurrency', type => 'int', context => 'PGC_POSTMASTER', group => 'RESOURCES_IO',
short_desc => 'Max number of IOs that one process can execute simultaneously.',
+ long_desc => '-1 means use a value based on "shared_buffers" and the maximum number of processes.',
variable => 'io_max_concurrency',
boot_val => '-1',
min => '-1',
@@ -1876,7 +1878,7 @@
{ name => 'log_statement_max_length', type => 'int', context => 'PGC_SUSET', group => 'LOGGING_WHAT',
short_desc => 'Sets the maximum length in bytes of logged statement text.',
- long_desc => '-1 means log statement in full; 0 means log only an ellipsis.',
+ long_desc => '-1 means log statements in full. 0 means log only an ellipsis.',
flags => 'GUC_UNIT_BYTE',
variable => 'log_statement_max_length',
boot_val => '-1',
@@ -2368,7 +2370,7 @@
{ name => 'password_expiration_warning_threshold', type => 'int', context => 'PGC_SIGHUP', group => 'CONN_AUTH_AUTH',
short_desc => 'Threshold for password expiration warnings.',
- long_desc => '0 means not to emit these warnings.',
+ long_desc => '0 disables these warnings.',
flags => 'GUC_UNIT_S',
variable => 'password_expiration_warning_threshold',
boot_val => '604800',
@@ -3580,7 +3582,7 @@
{ name => 'wal_sender_shutdown_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time the server waits during shutdown for all WAL data to be replicated to the receiver.',
- long_desc => '-1 disables the timeout and waits for the receiver to catch up; 0 does not wait for the receiver to catch up.',
+ long_desc => '-1 disables the timeout. 0 means do not wait for the receiver to catch up.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_shutdown_timeout',
boot_val => '-1',
@@ -3590,6 +3592,7 @@
{ name => 'wal_sender_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time to wait for WAL replication.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_timeout',
boot_val => '60 * 1000',
--
2.55.0
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-11 00:18 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
parent: Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Bharath Rupireddy @ 2026-09-11 00:18 UTC (permalink / raw)
To: Nathan Bossart <nathandbossart@gmail.com>; +Cc: pgsql-hackers
Hi,
On Thu, Sep 10, 2026 at 2:42 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> Some new parameters added since commit 977d865c36 do not follow the GUC
> description rules established by that commit. I've attached a patch to fix
> them.
Patch looks good to me. Some of these GUCs were introduced in prior
versions. I am fine if we are not backpatching the fixes.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-11 00:54 Fujii Masao <masao.fujii@gmail.com>
parent: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Fujii Masao @ 2026-09-11 00:54 UTC (permalink / raw)
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; +Cc: Nathan Bossart <nathandbossart@gmail.com>; pgsql-hackers
On Fri, Sep 11, 2026 at 9:18 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> > Some new parameters added since commit 977d865c36 do not follow the GUC
> > description rules established by that commit. I've attached a patch to fix
> > them.
>
> Patch looks good to me.
+1 except for one thing.
- long_desc => '-1 disables the timeout and waits for the receiver to
catch up; 0 does not wait for the receiver to catch up.',
+ long_desc => '-1 disables the timeout. 0 means do not wait for the
receiver to catch up.',
The previous wording was intentionally added based on Daniel's comment [1].
Regards,
[1] https://www.postgresql.org/message-id/B5EB4E43-290E-4509-AFF5-06453E4966CE%40yesql.se
> "A value of <literal>-1</literal> (the default) disables the timeout
> mechanism"
>
> To me as a non-native speaker reading that a timeout is disabled can be
> interpreted as if there is no waiting done, just like the in the case of 0.
--
Fujii Masao
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-11 03:41 Chao Li <li.evan.chao@gmail.com>
parent: Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Chao Li @ 2026-09-11 03:41 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; Nathan Bossart <nathandbossart@gmail.com>; pgsql-hackers
> On Sep 11, 2026, at 08:54, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Fri, Sep 11, 2026 at 9:18 AM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
>>> Some new parameters added since commit 977d865c36 do not follow the GUC
>>> description rules established by that commit. I've attached a patch to fix
>>> them.
>>
>> Patch looks good to me.
>
> +1 except for one thing.
>
> - long_desc => '-1 disables the timeout and waits for the receiver to
> catch up; 0 does not wait for the receiver to catch up.',
> + long_desc => '-1 disables the timeout. 0 means do not wait for the
> receiver to catch up.',
>
> The previous wording was intentionally added based on Daniel's comment [1].
>
> Regards,
>
> [1] https://www.postgresql.org/message-id/B5EB4E43-290E-4509-AFF5-06453E4966CE%40yesql.se
>> "A value of <literal>-1</literal> (the default) disables the timeout
>> mechanism"
>>
>> To me as a non-native speaker reading that a timeout is disabled can be
>> interpreted as if there is no waiting done, just like the in the case of 0.
>
> --
> Fujii Masao
>
Yeah, here -1 is really more like “wait forever”, so just saying “disables the timeout” feels like it loses that distinction.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-11 09:14 Álvaro Herrera <alvherre@kurilemu.de>
parent: Chao Li <li.evan.chao@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Álvaro Herrera @ 2026-09-11 09:14 UTC (permalink / raw)
To: Chao Li <li.evan.chao@gmail.com>; +Cc: Fujii Masao <masao.fujii@gmail.com>; Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; Nathan Bossart <nathandbossart@gmail.com>; pgsql-hackers
On 2026-Sep-11, Chao Li wrote:
> > On Sep 11, 2026, at 08:54, Fujii Masao <masao.fujii@gmail.com> wrote:
> > - long_desc => '-1 disables the timeout and waits for the receiver to
> > catch up; 0 does not wait for the receiver to catch up.',
> > + long_desc => '-1 disables the timeout. 0 means do not wait for the
> > receiver to catch up.',
>
> Yeah, here -1 is really more like “wait forever”, so just saying “disables the timeout” feels like it loses that distinction.
Maybe it should say "0 means do not wait, -1 means wait indefinitely."
This complements the short_desc,
Sets the maximum time the server waits during shutdown for all WAL data
to be replicated to the receiver.
I think the words "for the receiver to catch up" is somehow at odds with
the short_desc's "for all WAL data to be replicated". They should be
saying the same thing, but aren't.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Si no sabes adonde vas, es muy probable que acabes en otra parte.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-11 15:34 Nathan Bossart <nathandbossart@gmail.com>
parent: Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-09-11 15:34 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; +Cc: Chao Li <li.evan.chao@gmail.com>; Fujii Masao <masao.fujii@gmail.com>; Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; pgsql-hackers
On Fri, Sep 11, 2026 at 11:14:03AM +0200, Álvaro Herrera wrote:
> Maybe it should say "0 means do not wait, -1 means wait indefinitely."
> This complements the short_desc,
>
> Sets the maximum time the server waits during shutdown for all WAL data
> to be replicated to the receiver.
>
> I think the words "for the receiver to catch up" is somehow at odds with
> the short_desc's "for all WAL data to be replicated". They should be
> saying the same thing, but aren't.
WFM. v2 uses that wording, except -1 is listed first so that the special
values stay in ascending order.
I was considering back-patching this to v19. I'd rather not update the
descriptions in released versions, although I'm not even sure anything in
released versions need fixing. Any concerns about this?
--
nathan
From 2ea9715a91a3101641e2ff8e8271eb2a6236efb4 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Fri, 11 Sep 2026 10:27:16 -0500
Subject: [PATCH v2 1/1] Describe special values in more GUC descriptions.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Commit 977d865c36 established some rules for mentioning special
values (e.g., -1, 0, an empty string) in GUC descriptions. A few
parameters either neglect to mention their special values or
describe them in a way that doesn't follow those rules. Most of
these parameters were added after the aforementioned commit. This
commit fixes them.
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/aqMkIpRr62cVqtCZ%40nathan
---
src/backend/utils/misc/guc_parameters.dat | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/backend/utils/misc/guc_parameters.dat b/src/backend/utils/misc/guc_parameters.dat
index 93a434858bf..c57441f7d98 100644
--- a/src/backend/utils/misc/guc_parameters.dat
+++ b/src/backend/utils/misc/guc_parameters.dat
@@ -1303,6 +1303,7 @@
{ name => 'idle_replication_slot_timeout', type => 'int', context => 'PGC_SIGHUP', group => 'REPLICATION_SENDING',
short_desc => 'Sets the duration a replication slot can remain idle before it is invalidated.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_S',
variable => 'idle_replication_slot_timeout_secs',
boot_val => '0',
@@ -1389,6 +1390,7 @@
{ name => 'io_max_concurrency', type => 'int', context => 'PGC_POSTMASTER', group => 'RESOURCES_IO',
short_desc => 'Max number of IOs that one process can execute simultaneously.',
+ long_desc => '-1 means use a value based on "shared_buffers" and the maximum number of processes.',
variable => 'io_max_concurrency',
boot_val => '-1',
min => '-1',
@@ -1876,7 +1878,7 @@
{ name => 'log_statement_max_length', type => 'int', context => 'PGC_SUSET', group => 'LOGGING_WHAT',
short_desc => 'Sets the maximum length in bytes of logged statement text.',
- long_desc => '-1 means log statement in full; 0 means log only an ellipsis.',
+ long_desc => '-1 means log statements in full. 0 means log only an ellipsis.',
flags => 'GUC_UNIT_BYTE',
variable => 'log_statement_max_length',
boot_val => '-1',
@@ -2368,7 +2370,7 @@
{ name => 'password_expiration_warning_threshold', type => 'int', context => 'PGC_SIGHUP', group => 'CONN_AUTH_AUTH',
short_desc => 'Threshold for password expiration warnings.',
- long_desc => '0 means not to emit these warnings.',
+ long_desc => '0 disables these warnings.',
flags => 'GUC_UNIT_S',
variable => 'password_expiration_warning_threshold',
boot_val => '604800',
@@ -3580,7 +3582,7 @@
{ name => 'wal_sender_shutdown_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time the server waits during shutdown for all WAL data to be replicated to the receiver.',
- long_desc => '-1 disables the timeout and waits for the receiver to catch up; 0 does not wait for the receiver to catch up.',
+ long_desc => '-1 means wait indefinitely. 0 means do not wait.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_shutdown_timeout',
boot_val => '-1',
@@ -3590,6 +3592,7 @@
{ name => 'wal_sender_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time to wait for WAL replication.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_timeout',
boot_val => '60 * 1000',
--
2.55.0
Attachments:
[text/plain] v2-0001-Describe-special-values-in-more-GUC-descriptions.patch (3.7K, ../../aqQfleGBvlEiDQbE@nathan/2-v2-0001-Describe-special-values-in-more-GUC-descriptions.patch)
download | inline diff:
From 2ea9715a91a3101641e2ff8e8271eb2a6236efb4 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Fri, 11 Sep 2026 10:27:16 -0500
Subject: [PATCH v2 1/1] Describe special values in more GUC descriptions.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Commit 977d865c36 established some rules for mentioning special
values (e.g., -1, 0, an empty string) in GUC descriptions. A few
parameters either neglect to mention their special values or
describe them in a way that doesn't follow those rules. Most of
these parameters were added after the aforementioned commit. This
commit fixes them.
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/aqMkIpRr62cVqtCZ%40nathan
---
src/backend/utils/misc/guc_parameters.dat | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/backend/utils/misc/guc_parameters.dat b/src/backend/utils/misc/guc_parameters.dat
index 93a434858bf..c57441f7d98 100644
--- a/src/backend/utils/misc/guc_parameters.dat
+++ b/src/backend/utils/misc/guc_parameters.dat
@@ -1303,6 +1303,7 @@
{ name => 'idle_replication_slot_timeout', type => 'int', context => 'PGC_SIGHUP', group => 'REPLICATION_SENDING',
short_desc => 'Sets the duration a replication slot can remain idle before it is invalidated.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_S',
variable => 'idle_replication_slot_timeout_secs',
boot_val => '0',
@@ -1389,6 +1390,7 @@
{ name => 'io_max_concurrency', type => 'int', context => 'PGC_POSTMASTER', group => 'RESOURCES_IO',
short_desc => 'Max number of IOs that one process can execute simultaneously.',
+ long_desc => '-1 means use a value based on "shared_buffers" and the maximum number of processes.',
variable => 'io_max_concurrency',
boot_val => '-1',
min => '-1',
@@ -1876,7 +1878,7 @@
{ name => 'log_statement_max_length', type => 'int', context => 'PGC_SUSET', group => 'LOGGING_WHAT',
short_desc => 'Sets the maximum length in bytes of logged statement text.',
- long_desc => '-1 means log statement in full; 0 means log only an ellipsis.',
+ long_desc => '-1 means log statements in full. 0 means log only an ellipsis.',
flags => 'GUC_UNIT_BYTE',
variable => 'log_statement_max_length',
boot_val => '-1',
@@ -2368,7 +2370,7 @@
{ name => 'password_expiration_warning_threshold', type => 'int', context => 'PGC_SIGHUP', group => 'CONN_AUTH_AUTH',
short_desc => 'Threshold for password expiration warnings.',
- long_desc => '0 means not to emit these warnings.',
+ long_desc => '0 disables these warnings.',
flags => 'GUC_UNIT_S',
variable => 'password_expiration_warning_threshold',
boot_val => '604800',
@@ -3580,7 +3582,7 @@
{ name => 'wal_sender_shutdown_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time the server waits during shutdown for all WAL data to be replicated to the receiver.',
- long_desc => '-1 disables the timeout and waits for the receiver to catch up; 0 does not wait for the receiver to catch up.',
+ long_desc => '-1 means wait indefinitely. 0 means do not wait.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_shutdown_timeout',
boot_val => '-1',
@@ -3590,6 +3592,7 @@
{ name => 'wal_sender_timeout', type => 'int', context => 'PGC_USERSET', group => 'REPLICATION_SENDING',
short_desc => 'Sets the maximum time to wait for WAL replication.',
+ long_desc => '0 disables the timeout.',
flags => 'GUC_UNIT_MS',
variable => 'wal_sender_timeout',
boot_val => '60 * 1000',
--
2.55.0
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-12 03:14 Chao Li <li.evan.chao@gmail.com>
parent: Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Chao Li @ 2026-09-12 03:14 UTC (permalink / raw)
To: Nathan Bossart <nathandbossart@gmail.com>; +Cc: Álvaro Herrera <alvherre@kurilemu.de>; Fujii Masao <masao.fujii@gmail.com>; Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; pgsql-hackers
> On Sep 11, 2026, at 23:34, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Fri, Sep 11, 2026 at 11:14:03AM +0200, Álvaro Herrera wrote:
>> Maybe it should say "0 means do not wait, -1 means wait indefinitely."
>> This complements the short_desc,
>>
>> Sets the maximum time the server waits during shutdown for all WAL data
>> to be replicated to the receiver.
>>
>> I think the words "for the receiver to catch up" is somehow at odds with
>> the short_desc's "for all WAL data to be replicated". They should be
>> saying the same thing, but aren't.
>
> WFM. v2 uses that wording, except -1 is listed first so that the special
> values stay in ascending order.
>
> I was considering back-patching this to v19. I'd rather not update the
> descriptions in released versions, although I'm not even sure anything in
> released versions need fixing. Any concerns about this?
>
> --
> nathan
> <v2-0001-Describe-special-values-in-more-GUC-descriptions.patch>
V2 LGTM.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: fixes for a few GUC descriptions
@ 2026-09-14 14:18 Nathan Bossart <nathandbossart@gmail.com>
parent: Chao Li <li.evan.chao@gmail.com>
0 siblings, 0 replies; 8+ messages in thread
From: Nathan Bossart @ 2026-09-14 14:18 UTC (permalink / raw)
To: Chao Li <li.evan.chao@gmail.com>; +Cc: Álvaro Herrera <alvherre@kurilemu.de>; Fujii Masao <masao.fujii@gmail.com>; Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; pgsql-hackers
On Sat, Sep 12, 2026 at 11:14:08AM +0800, Chao Li wrote:
> V2 LGTM.
Committed, thanks for looking.
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2026-09-14 14:18 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 21:41 fixes for a few GUC descriptions Nathan Bossart <nathandbossart@gmail.com>
2026-09-11 00:18 ` Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
2026-09-11 00:54 ` Fujii Masao <masao.fujii@gmail.com>
2026-09-11 03:41 ` Chao Li <li.evan.chao@gmail.com>
2026-09-11 09:14 ` Álvaro Herrera <alvherre@kurilemu.de>
2026-09-11 15:34 ` Nathan Bossart <nathandbossart@gmail.com>
2026-09-12 03:14 ` Chao Li <li.evan.chao@gmail.com>
2026-09-14 14:18 ` Nathan Bossart <nathandbossart@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox