public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 4/6] 0002 review
25+ messages / 4 participants
[nested] [flat]
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 25+ messages in thread
* Re: Elimination of the repetitive code at the SLRU bootstrap functions.
@ 2025-02-14 06:54 Evgeny Voropaev <[email protected]>
2025-02-17 12:18 ` Re: Elimination of the repetitive code at the SLRU bootstrap functions. Andrey Borodin <[email protected]>
0 siblings, 1 reply; 25+ messages in thread
From: Evgeny Voropaev @ 2025-02-14 06:54 UTC (permalink / raw)
To: [email protected]; pgsql-hackers; [email protected]
Hello Aleksander!
Hello Álvaro!
Thank you for your attention to the patch.
> Since BootStrapSlruPage() is the only caller of ZeroPage() it seems to
> me that it merely wastes space in SlruCtlData. On top of that I'm not
> 100% sure if all the supported platforms have C99 compilers with
> designated initializers support.
> Wouldn't it be simpler to pass the callback straight to
> BootStrapSlruPage()?
I agree with your proposals. Moreover, similar solution is also implemented and exploited at
Tantor's versions of the xid64 patch (https://www.postgresql.org/message-id/5ca56aed-dc69-4c3e-968f-a822ae0937b5%40gmail.com).
The corrected patch version implementing these proposals is attached.
Best regards,
Evgeny Voropaev,
Tantor Labs LLC.
Attachments:
[text/x-patch] v2-0001-Elimination-of-the-repetitive-code-at-the-SLRU-bo.patch (9.6K, ../../[email protected]/2-v2-0001-Elimination-of-the-repetitive-code-at-the-SLRU-bo.patch)
download | inline diff:
From a5a29cdbb37834bfcd23cd22db90a78a7db43d18 Mon Sep 17 00:00:00 2001
From: Evgeny Voropaev <[email protected]>
Date: Fri, 14 Feb 2025 14:03:01 +0800
Subject: [PATCH v2] Elimination of the repetitive code at the SLRU bootstrap
functions.
The functions bootstrapping SLRU pages used to have a lot of repetitive code. The new
realized function BootStrapSlruPage has moved duplicating code into the
single place and eliminated code repetitions.
Author: Evgeny Voropaev <[email protected]> <[email protected]>
---
src/backend/access/transam/clog.c | 27 +------------
src/backend/access/transam/commit_ts.c | 24 +-----------
src/backend/access/transam/multixact.c | 54 ++------------------------
src/backend/access/transam/slru.c | 35 +++++++++++++++++
src/backend/access/transam/subtrans.c | 28 ++++++-------
src/include/access/slru.h | 1 +
6 files changed, 55 insertions(+), 114 deletions(-)
diff --git a/src/backend/access/transam/clog.c b/src/backend/access/transam/clog.c
index 0d556c00b8c..5ae684da6af 100644
--- a/src/backend/access/transam/clog.c
+++ b/src/backend/access/transam/clog.c
@@ -832,19 +832,7 @@ check_transaction_buffers(int *newval, void **extra, GucSource source)
void
BootStrapCLOG(void)
{
- int slotno;
- LWLock *lock = SimpleLruGetBankLock(XactCtl, 0);
-
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- /* Create and zero the first page of the commit log */
- slotno = ZeroCLOGPage(0, false);
-
- /* Make sure it's written out */
- SimpleLruWritePage(XactCtl, slotno);
- Assert(!XactCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(XactCtl, 0, ZeroCLOGPage);
}
/*
@@ -1114,19 +1102,8 @@ clog_redo(XLogReaderState *record)
if (info == CLOG_ZEROPAGE)
{
int64 pageno;
- int slotno;
- LWLock *lock;
-
memcpy(&pageno, XLogRecGetData(record), sizeof(pageno));
-
- lock = SimpleLruGetBankLock(XactCtl, pageno);
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- slotno = ZeroCLOGPage(pageno, false);
- SimpleLruWritePage(XactCtl, slotno);
- Assert(!XactCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(XactCtl, pageno, ZeroCLOGPage);
}
else if (info == CLOG_TRUNCATE)
{
diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c
index 95049acd0b5..54600f1b69c 100644
--- a/src/backend/access/transam/commit_ts.c
+++ b/src/backend/access/transam/commit_ts.c
@@ -747,16 +747,7 @@ ActivateCommitTs(void)
/* Create the current segment file, if necessary */
if (!SimpleLruDoesPhysicalPageExist(CommitTsCtl, pageno))
- {
- LWLock *lock = SimpleLruGetBankLock(CommitTsCtl, pageno);
- int slotno;
-
- LWLockAcquire(lock, LW_EXCLUSIVE);
- slotno = ZeroCommitTsPage(pageno, false);
- SimpleLruWritePage(CommitTsCtl, slotno);
- Assert(!CommitTsCtl->shared->page_dirty[slotno]);
- LWLockRelease(lock);
- }
+ BootStrapSlruPage(CommitTsCtl, pageno, ZeroCommitTsPage);
/* Change the activation status in shared memory. */
LWLockAcquire(CommitTsLock, LW_EXCLUSIVE);
@@ -1023,19 +1014,8 @@ commit_ts_redo(XLogReaderState *record)
if (info == COMMIT_TS_ZEROPAGE)
{
int64 pageno;
- int slotno;
- LWLock *lock;
-
memcpy(&pageno, XLogRecGetData(record), sizeof(pageno));
-
- lock = SimpleLruGetBankLock(CommitTsCtl, pageno);
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- slotno = ZeroCommitTsPage(pageno, false);
- SimpleLruWritePage(CommitTsCtl, slotno);
- Assert(!CommitTsCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(CommitTsCtl, pageno, ZeroCommitTsPage);
}
else if (info == COMMIT_TS_TRUNCATE)
{
diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index 27ccdf9500f..30cc47021f7 100644
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -2033,32 +2033,8 @@ check_multixact_member_buffers(int *newval, void **extra, GucSource source)
void
BootStrapMultiXact(void)
{
- int slotno;
- LWLock *lock;
-
- lock = SimpleLruGetBankLock(MultiXactOffsetCtl, 0);
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- /* Create and zero the first page of the offsets log */
- slotno = ZeroMultiXactOffsetPage(0, false);
-
- /* Make sure it's written out */
- SimpleLruWritePage(MultiXactOffsetCtl, slotno);
- Assert(!MultiXactOffsetCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
-
- lock = SimpleLruGetBankLock(MultiXactMemberCtl, 0);
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- /* Create and zero the first page of the members log */
- slotno = ZeroMultiXactMemberPage(0, false);
-
- /* Make sure it's written out */
- SimpleLruWritePage(MultiXactMemberCtl, slotno);
- Assert(!MultiXactMemberCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(MultiXactOffsetCtl, 0, ZeroMultiXactOffsetPage);
+ BootStrapSlruPage(MultiXactMemberCtl, 0, ZeroMultiXactMemberPage);
}
/*
@@ -3401,36 +3377,14 @@ multixact_redo(XLogReaderState *record)
if (info == XLOG_MULTIXACT_ZERO_OFF_PAGE)
{
int64 pageno;
- int slotno;
- LWLock *lock;
-
memcpy(&pageno, XLogRecGetData(record), sizeof(pageno));
-
- lock = SimpleLruGetBankLock(MultiXactOffsetCtl, pageno);
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- slotno = ZeroMultiXactOffsetPage(pageno, false);
- SimpleLruWritePage(MultiXactOffsetCtl, slotno);
- Assert(!MultiXactOffsetCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(MultiXactOffsetCtl, pageno, ZeroMultiXactOffsetPage);
}
else if (info == XLOG_MULTIXACT_ZERO_MEM_PAGE)
{
int64 pageno;
- int slotno;
- LWLock *lock;
-
memcpy(&pageno, XLogRecGetData(record), sizeof(pageno));
-
- lock = SimpleLruGetBankLock(MultiXactMemberCtl, pageno);
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- slotno = ZeroMultiXactMemberPage(pageno, false);
- SimpleLruWritePage(MultiXactMemberCtl, slotno);
- Assert(!MultiXactMemberCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(MultiXactMemberCtl, pageno, ZeroMultiXactMemberPage);
}
else if (info == XLOG_MULTIXACT_CREATE_ID)
{
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
index 9ce628e62a5..fd332fd4c64 100644
--- a/src/backend/access/transam/slru.c
+++ b/src/backend/access/transam/slru.c
@@ -1850,3 +1850,38 @@ SlruSyncFileTag(SlruCtl ctl, const FileTag *ftag, char *path)
errno = save_errno;
return result;
}
+
+/*
+ * BootStrapSlruPage is a workhorse for functions bootstraping
+ * SLRU pages, including:
+ * BootStrapMultiXact,
+ * BootStrapCLOG,
+ * ActivateCommitTs,
+ * multixact_redo,
+ * commit_ts_redo.
+ *
+ * It performs all of the rut such as acquiring a lock, zeroing,
+ * ensuring that a bootstrapped page is written out, and releasing the lock.
+ *
+ * A caller has to provide a proper zerofunc appropriate for the type of
+ * the page.
+ *
+ */
+void
+BootStrapSlruPage(SlruCtl ctl, int64 pageno, int(*zerofunc)(int64, bool) )
+{
+ int slotno;
+ LWLock *lock;
+
+ lock = SimpleLruGetBankLock(ctl, pageno);
+ LWLockAcquire(lock, LW_EXCLUSIVE);
+
+ /* Create and zero the page*/
+ slotno = (*zerofunc)(pageno, false);
+
+ /* Make sure it's written out */
+ SimpleLruWritePage(ctl, slotno);
+ Assert(!ctl->shared->page_dirty[slotno]);
+
+ LWLockRelease(lock);
+}
diff --git a/src/backend/access/transam/subtrans.c b/src/backend/access/transam/subtrans.c
index 15153618fad..ec63c823d66 100644
--- a/src/backend/access/transam/subtrans.c
+++ b/src/backend/access/transam/subtrans.c
@@ -74,7 +74,7 @@ static SlruCtlData SubTransCtlData;
#define SubTransCtl (&SubTransCtlData)
-static int ZeroSUBTRANSPage(int64 pageno);
+static int ZeroSUBTRANSPage(int64 pageno, bool unused);
static bool SubTransPagePrecedes(int64 page1, int64 page2);
@@ -269,19 +269,7 @@ check_subtrans_buffers(int *newval, void **extra, GucSource source)
void
BootStrapSUBTRANS(void)
{
- int slotno;
- LWLock *lock = SimpleLruGetBankLock(SubTransCtl, 0);
-
- LWLockAcquire(lock, LW_EXCLUSIVE);
-
- /* Create and zero the first page of the subtrans log */
- slotno = ZeroSUBTRANSPage(0);
-
- /* Make sure it's written out */
- SimpleLruWritePage(SubTransCtl, slotno);
- Assert(!SubTransCtl->shared->page_dirty[slotno]);
-
- LWLockRelease(lock);
+ BootStrapSlruPage(SubTransCtl, 0, ZeroSUBTRANSPage);
}
/*
@@ -291,10 +279,16 @@ BootStrapSUBTRANS(void)
* The slot number of the new page is returned.
*
* Control lock must be held at entry, and will be held at exit.
+ *
+ * "bool unused" is a parameter required to provide matching of the
+ * ZeroSUBTRANSPage function to the zerofunc function prototype
+ * used by BootStrapSlruPage.
*/
static int
-ZeroSUBTRANSPage(int64 pageno)
+ZeroSUBTRANSPage(int64 pageno, bool unused)
{
+ (void)unused; /* Supress compiler warning */
+
return SimpleLruZeroPage(SubTransCtl, pageno);
}
@@ -335,7 +329,7 @@ StartupSUBTRANS(TransactionId oldestActiveXID)
prevlock = lock;
}
- (void) ZeroSUBTRANSPage(startPage);
+ (void) ZeroSUBTRANSPage(startPage, false);
if (startPage == endPage)
break;
@@ -395,7 +389,7 @@ ExtendSUBTRANS(TransactionId newestXact)
LWLockAcquire(lock, LW_EXCLUSIVE);
/* Zero the page */
- ZeroSUBTRANSPage(pageno);
+ ZeroSUBTRANSPage(pageno, false);
LWLockRelease(lock);
}
diff --git a/src/include/access/slru.h b/src/include/access/slru.h
index e142800aab2..515986b4506 100644
--- a/src/include/access/slru.h
+++ b/src/include/access/slru.h
@@ -214,5 +214,6 @@ extern bool SlruScanDirCbReportPresence(SlruCtl ctl, char *filename,
extern bool SlruScanDirCbDeleteAll(SlruCtl ctl, char *filename, int64 segpage,
void *data);
extern bool check_slru_buffers(const char *name, int *newval);
+extern void BootStrapSlruPage( SlruCtl ctl, int64 pageno, int(*zerofunc)(int64, bool) );
#endif /* SLRU_H */
--
2.47.1
^ permalink raw reply [nested|flat] 25+ messages in thread
* Re: Elimination of the repetitive code at the SLRU bootstrap functions.
2025-02-14 06:54 Re: Elimination of the repetitive code at the SLRU bootstrap functions. Evgeny Voropaev <[email protected]>
@ 2025-02-17 12:18 ` Andrey Borodin <[email protected]>
2025-02-17 13:00 ` Re: Elimination of the repetitive code at the SLRU bootstrap functions. Álvaro Herrera <[email protected]>
0 siblings, 1 reply; 25+ messages in thread
From: Andrey Borodin @ 2025-02-17 12:18 UTC (permalink / raw)
To: Evgeny Voropaev <[email protected]>; +Cc: Aleksander Alekseev <[email protected]>; pgsql-hackers; [email protected]
> On 14 Feb 2025, at 11:54, Evgeny Voropaev <[email protected]> wrote:
>
> <v2-0001-Elimination-of-the-repetitive-code-at-the-SLRU-bo.patch>
Hi! Nice patch!
BootStrapSlruPage() always calls zerofunc(pageno, false) with second argument false.
In case of every possible argument (ZeroCLOGPage, ZeroCommitTsPage, ZeroMultiXactOffsetPage, ZeroMultiXactMemberPage, ZeroSUBTRANSPage) it means just a call to SimpleLruZeroPage().
I think we can safely replace
+ slotno = (*zerofunc)(pageno, false);
with
+ slotno = SimpleLruZeroPage(pageno);
Thus we will not need zerofunc argument at all.
Thanks!
Best regards, Andrey Borodin.
^ permalink raw reply [nested|flat] 25+ messages in thread
* Re: Elimination of the repetitive code at the SLRU bootstrap functions.
2025-02-14 06:54 Re: Elimination of the repetitive code at the SLRU bootstrap functions. Evgeny Voropaev <[email protected]>
2025-02-17 12:18 ` Re: Elimination of the repetitive code at the SLRU bootstrap functions. Andrey Borodin <[email protected]>
@ 2025-02-17 13:00 ` Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 25+ messages in thread
From: Álvaro Herrera @ 2025-02-17 13:00 UTC (permalink / raw)
To: Andrey Borodin <[email protected]>; +Cc: Evgeny Voropaev <[email protected]>; Aleksander Alekseev <[email protected]>; pgsql-hackers
On 2025-Feb-17, Andrey Borodin wrote:
> BootStrapSlruPage() always calls zerofunc(pageno, false) with second argument false.
> In case of every possible argument (ZeroCLOGPage, ZeroCommitTsPage,
> ZeroMultiXactOffsetPage, ZeroMultiXactMemberPage, ZeroSUBTRANSPage) it
> means just a call to SimpleLruZeroPage().
> I think we can safely replace
>
> + slotno = (*zerofunc)(pageno, false);
>
> with
>
> + slotno = SimpleLruZeroPage(pageno);
>
> Thus we will not need zerofunc argument at all.
Good observation. This also suggests another change: because this new
function is used not only for bootstrapping but also during WAL replay,
we can call the new function SimpleLruUnloggedZeroPage() and place it
immediately after SimpleLruZeroPage, instead of at the end of the file.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La persona que no quería pecar / estaba obligada a sentarse
en duras y empinadas sillas / desprovistas, por cierto
de blandos atenuantes" (Patricio Vogel)
^ permalink raw reply [nested|flat] 25+ messages in thread
end of thread, other threads:[~2025-02-17 13:00 UTC | newest]
Thread overview: 25+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2025-02-14 06:54 Re: Elimination of the repetitive code at the SLRU bootstrap functions. Evgeny Voropaev <[email protected]>
2025-02-17 12:18 ` Re: Elimination of the repetitive code at the SLRU bootstrap functions. Andrey Borodin <[email protected]>
2025-02-17 13:00 ` Re: Elimination of the repetitive code at the SLRU bootstrap functions. Álvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox