agora inbox for [email protected]
help / color / mirror / Atom feed[PATCH 4/6] 0002 review
41+ messages / 9 participants
[nested] [flat]
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)
---
doc/src/sgml/ref/analyze.sgml | 2 +-
doc/src/sgml/ref/cluster.sgml | 2 +-
doc/src/sgml/ref/copy.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 2 +-
doc/src/sgml/ref/reindex.sgml | 2 +-
doc/src/sgml/ref/vacuum.sgml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
</para>
<para>
- Each backend running the <command>ANALYZE</command> command will report their
+ Each backend running the <command>ANALYZE</command> command will report its
progress to the <structname>pg_stat_progress_analyze</structname> view.
See <xref linkend="analyze-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
</para>
<para>
- Each backend running the <command>CLUSTER</command> command will report their
+ Each backend running the <command>CLUSTER</command> command will report its
progress to the <structname>pg_stat_progress_cluster</structname> view.
See <xref linkend="cluster-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
- Each backend running the <command>COPY</command> command will report their
+ Each backend running the <command>COPY</command> command will report its
progress to the <structname>pg_stat_progress_copy</structname> view.
See <xref linkend="copy-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
<para>
Each backend running the <command>CREATE INDEX</command> command will
- report their progress to the
+ report it's progress to the
<structname>pg_stat_progress_create_index</structname> view.
See <xref linkend="create-index-progress-reporting"/> for details.
</para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
<para>
Each backend running the <command>REINDEX</command> command will report
- their progress to the <structname>pg_stat_progress_create_index</structname>
+ its progress to the <structname>pg_stat_progress_create_index</structname>
view. See <xref linkend="create-index-progress-reporting"/> for details.
</para>
</refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
</para>
<para>
Each backend running the <command>VACUUM</command> command without the
- <literal>FULL</literal> option will report their progress in the
+ <literal>FULL</literal> option will report its progress in the
<structname>pg_stat_progress_vacuum</structname> view. Backends running
<command>VACUUM</command> with the <literal>FULL</literal> option report
progress in the <structname>pg_stat_progress_cluster</structname> instead.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
^ permalink raw reply [nested|flat] 41+ messages in thread
* Allowing REINDEX to have an optional name
@ 2022-05-10 09:13 Simon Riggs <[email protected]>
0 siblings, 2 replies; 41+ messages in thread
From: Simon Riggs @ 2022-05-10 09:13 UTC (permalink / raw)
To: pgsql-hackers
A minor issue, and patch.
REINDEX DATABASE currently requires you to write REINDEX DATABASE
dbname, which makes this a little less usable than we might like.
REINDEX on the catalog can cause deadlocks, which also makes REINDEX
DATABASE not much use in practice, and is the reason there is no test
for REINDEX DATABASE. Another reason why it is a little less usable
than we might like.
Seems we should do something about these historic issues in the name
of product usability.
Attached patch allows new syntax for REINDEX DATABASE, without needing
to specify dbname. That version of the command skips catalog tables,
as a way of avoiding the known deadlocks. Patch also adds a test.
--
Simon Riggs http://www.EnterpriseDB.com/
Attachments:
[application/octet-stream] reindex_not_require_database_name.v2.patch (6.6K, ../../CANbhV-H=NH6Om4-X6cRjDWfH_Mu1usqwkuYVp-hwdB_PSHWRfg@mail.gmail.com/2-reindex_not_require_database_name.v2.patch)
download | inline diff:
REINDEX DATABASE omitting dbname
(also works for REINDEX SYSTEM)
Currently, REINDEX DATABASE is not tested because reindexing the catalog can cause deadlocks.
So we want a test for REINDEX DATABASE *and* a user command that doesn't cause deadlocks
on user systems, as well as one that is easy to setup maintenance commands for.
Additional syntax:
REINDEX SYSTEM - reindexes all catalog tables (only)
REINDEX DATABASE - reindexes all user tables (only) - exactly opposite set from REINDEX SYSTEM
Test for REINDEX DATABASE added. Docs updated.
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index e6b25ee670..5d38ca786e 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -22,6 +22,7 @@ PostgreSQL documentation
<refsynopsisdiv>
<synopsis>
REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { INDEX | TABLE | SCHEMA | DATABASE | SYSTEM } [ CONCURRENTLY ] <replaceable class="parameter">name</replaceable>
+REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { DATABASE | SYSTEM } [ CONCURRENTLY ] [ <replaceable class="parameter">name</replaceable> ]
<phrase>where <replaceable class="parameter">option</replaceable> can be one of:</phrase>
@@ -127,7 +128,8 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
<listitem>
<para>
Recreate all indexes within the current database.
- Indexes on shared system catalogs are also processed.
+ Indexes on shared system catalogs are also processed, unless the
+ database name is omitted, in which case system catalog indexes are skipped.
This form of <command>REINDEX</command> cannot be executed inside a
transaction block.
</para>
@@ -155,7 +157,7 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
reindexed. Index and table names can be schema-qualified.
Presently, <command>REINDEX DATABASE</command> and <command>REINDEX SYSTEM</command>
can only reindex the current database, so their parameter must match
- the current database's name.
+ the current database's name, though supplying the name is optional.
</para>
</listitem>
</varlistentry>
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
index cd30f15eba..d75abb4e13 100644
--- a/src/backend/commands/indexcmds.c
+++ b/src/backend/commands/indexcmds.c
@@ -2759,10 +2759,10 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
bool concurrent_warning = false;
bool tablespace_warning = false;
- AssertArg(objectName);
Assert(objectKind == REINDEX_OBJECT_SCHEMA ||
objectKind == REINDEX_OBJECT_SYSTEM ||
objectKind == REINDEX_OBJECT_DATABASE);
+ AssertArg(objectName || objectKind != REINDEX_OBJECT_SCHEMA);
if (objectKind == REINDEX_OBJECT_SYSTEM &&
(params->options & REINDEXOPT_CONCURRENTLY) != 0)
@@ -2788,13 +2788,13 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
{
objectOid = MyDatabaseId;
- if (strcmp(objectName, get_database_name(objectOid)) != 0)
+ if (objectName && strcmp(objectName, get_database_name(objectOid)) != 0)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("can only reindex the currently open database")));
if (!pg_database_ownercheck(objectOid, GetUserId()))
aclcheck_error(ACLCHECK_NOT_OWNER, OBJECT_DATABASE,
- objectName);
+ get_database_name(objectOid));
}
/*
@@ -2857,6 +2857,12 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
!IsSystemClass(relid, classtuple))
continue;
+ /* Unqualified REINDEX DATABASE will skip catalog tables */
+ if (objectKind == REINDEX_OBJECT_DATABASE &&
+ objectName == NULL &&
+ IsSystemClass(relid, classtuple))
+ continue;
+
/*
* The table can be reindexed if the user is superuser, the table
* owner, or the database/schema owner (but in the latter case, only
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index a03b33b53b..7ddd39ed72 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -547,7 +547,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
%type <defelt> generic_option_elem alter_generic_option_elem
%type <list> generic_option_list alter_generic_option_list
-%type <ival> reindex_target_type reindex_target_multitable
+%type <ival> reindex_target_type reindex_target_multitable reindex_no_name
%type <node> copy_generic_opt_arg copy_generic_opt_arg_list_item
%type <defelt> copy_generic_opt_elem
@@ -8512,6 +8512,24 @@ ReindexStmt:
makeDefElem("concurrently", NULL, @3));
$$ = (Node *)n;
}
+ | REINDEX reindex_no_name
+ {
+ ReindexStmt *n = makeNode(ReindexStmt);
+ n->kind = $2;
+ n->name = NULL;
+ n->relation = NULL;
+ n->params = NIL;
+ $$ = (Node *)n;
+ }
+ | REINDEX '(' utility_option_list ')' reindex_no_name
+ {
+ ReindexStmt *n = makeNode(ReindexStmt);
+ n->kind = $5;
+ n->name = NULL;
+ n->relation = NULL;
+ n->params = $3;
+ $$ = (Node *)n;
+ }
| REINDEX '(' utility_option_list ')' reindex_target_type opt_concurrently qualified_name
{
ReindexStmt *n = makeNode(ReindexStmt);
@@ -8546,6 +8564,10 @@ reindex_target_multitable:
| SYSTEM_P { $$ = REINDEX_OBJECT_SYSTEM; }
| DATABASE { $$ = REINDEX_OBJECT_DATABASE; }
;
+reindex_no_name:
+ SYSTEM_P { $$ = REINDEX_OBJECT_SYSTEM; }
+ | DATABASE { $$ = REINDEX_OBJECT_DATABASE; }
+ ;
/*****************************************************************************
*
diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out
index d55aec3a1d..1f4e15557b 100644
--- a/src/test/regress/expected/create_index.out
+++ b/src/test/regress/expected/create_index.out
@@ -2808,6 +2808,8 @@ ERROR: REINDEX SCHEMA cannot run inside a transaction block
END;
-- concurrently
REINDEX SCHEMA CONCURRENTLY schema_to_reindex;
+-- unqualified reindex database
+REINDEX DATABASE;
-- Failure for unauthorized user
CREATE ROLE regress_reindexuser NOLOGIN;
SET SESSION ROLE regress_reindexuser;
diff --git a/src/test/regress/sql/create_index.sql b/src/test/regress/sql/create_index.sql
index d8fded3d93..74c0d0f1c9 100644
--- a/src/test/regress/sql/create_index.sql
+++ b/src/test/regress/sql/create_index.sql
@@ -1235,6 +1235,9 @@ END;
-- concurrently
REINDEX SCHEMA CONCURRENTLY schema_to_reindex;
+-- unqualified reindex database
+REINDEX DATABASE;
+
-- Failure for unauthorized user
CREATE ROLE regress_reindexuser NOLOGIN;
SET SESSION ROLE regress_reindexuser;
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-10 12:29 Bernd Helmle <[email protected]>
parent: Simon Riggs <[email protected]>
1 sibling, 0 replies; 41+ messages in thread
From: Bernd Helmle @ 2022-05-10 12:29 UTC (permalink / raw)
To: Simon Riggs <[email protected]>; pgsql-hackers
Hi,
Am Dienstag, dem 10.05.2022 um 10:13 +0100 schrieb Simon Riggs:
> A minor issue, and patch.
>
> REINDEX DATABASE currently requires you to write REINDEX DATABASE
> dbname, which makes this a little less usable than we might like.
>
> REINDEX on the catalog can cause deadlocks, which also makes REINDEX
> DATABASE not much use in practice, and is the reason there is no test
> for REINDEX DATABASE. Another reason why it is a little less usable
> than we might like.
>
> Seems we should do something about these historic issues in the name
> of product usability.
>
Wow, i just recently had a look into that code and talked with my
colleagues on how the current behavior annoyed me last week....and
there you are! This community rocks ;)
> Attached patch allows new syntax for REINDEX DATABASE, without
> needing
> to specify dbname. That version of the command skips catalog tables,
> as a way of avoiding the known deadlocks. Patch also adds a test.
>
+ /* Unqualified REINDEX DATABASE will skip catalog
tables */
+ if (objectKind == REINDEX_OBJECT_DATABASE &&
+ objectName == NULL &&
+ IsSystemClass(relid, classtuple))
+ continue;
Hmm, shouldn't we just print a NOTICE or something like this in
addition to this check to tell the user that we are *not* really
reindexing all things (and probably give him a hint to use REINDEX
SYSTEM to cover them)?
Thanks,
Bernd
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-10 13:47 Ashutosh Bapat <[email protected]>
parent: Simon Riggs <[email protected]>
1 sibling, 1 reply; 41+ messages in thread
From: Ashutosh Bapat @ 2022-05-10 13:47 UTC (permalink / raw)
To: Simon Riggs <[email protected]>; +Cc: pgsql-hackers; Ashutosh Bapat <[email protected]>
On Tue, May 10, 2022 at 2:43 PM Simon Riggs
<[email protected]> wrote:
>
> A minor issue, and patch.
>
> REINDEX DATABASE currently requires you to write REINDEX DATABASE
> dbname, which makes this a little less usable than we might like.
>
> REINDEX on the catalog can cause deadlocks, which also makes REINDEX
> DATABASE not much use in practice, and is the reason there is no test
> for REINDEX DATABASE. Another reason why it is a little less usable
> than we might like.
>
> Seems we should do something about these historic issues in the name
> of product usability.
>
> Attached patch allows new syntax for REINDEX DATABASE, without needing
> to specify dbname. That version of the command skips catalog tables,
> as a way of avoiding the known deadlocks. Patch also adds a test.
>
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-10 14:00 Simon Riggs <[email protected]>
parent: Ashutosh Bapat <[email protected]>
0 siblings, 2 replies; 41+ messages in thread
From: Simon Riggs @ 2022-05-10 14:00 UTC (permalink / raw)
To: Ashutosh Bapat <[email protected]>; +Cc: pgsql-hackers; Ashutosh Bapat <[email protected]>
On Tue, 10 May 2022 at 14:47, Ashutosh Bapat
<[email protected]> wrote:
>
> On Tue, May 10, 2022 at 2:43 PM Simon Riggs
> <[email protected]> wrote:
> >
> > A minor issue, and patch.
> >
> > REINDEX DATABASE currently requires you to write REINDEX DATABASE
> > dbname, which makes this a little less usable than we might like.
> >
> > REINDEX on the catalog can cause deadlocks, which also makes REINDEX
> > DATABASE not much use in practice, and is the reason there is no test
> > for REINDEX DATABASE. Another reason why it is a little less usable
> > than we might like.
> >
> > Seems we should do something about these historic issues in the name
> > of product usability.
> >
> > Attached patch allows new syntax for REINDEX DATABASE, without needing
> > to specify dbname. That version of the command skips catalog tables,
> > as a way of avoiding the known deadlocks. Patch also adds a test.
> >
>
> From the patch it looks like with the patch applied running REINDEX
> DATABASE is equivalent to running REINDEX DATABASE <current database>
> except reindexing the shared catalogs. Is that correct?
Yes
> Though the patch adds following change
> + Indexes on shared system catalogs are also processed, unless the
> + database name is omitted, in which case system catalog indexes
> are skipped.
>
> the syntax looks unintuitive.
>
> I think REINDEX DATABASE reindexing the current database is a good
> usability improvement in itself. But skipping the shared catalogs
> needs an explicity syntax. Not sure how feasible it is but something
> like REINDEX DATABASE skip SHARED/SYSTEM.
There are two commands:
REINDEX DATABASE does every except system catalogs
REINDEX SYSTEM does system catalogs only
So taken together, the two commands seem intuitive to me.
It is designed like this because it is dangerous to REINDEX the system
catalogs because of potential deadlocks, so we want a way to avoid
that problem.
Perhaps I can improve the docs more, will look.
--
Simon Riggs http://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-11 04:24 Ashutosh Bapat <[email protected]>
parent: Simon Riggs <[email protected]>
1 sibling, 2 replies; 41+ messages in thread
From: Ashutosh Bapat @ 2022-05-11 04:24 UTC (permalink / raw)
To: Simon Riggs <[email protected]>; +Cc: Ashutosh Bapat <[email protected]>; pgsql-hackers
On Tue, May 10, 2022 at 7:30 PM Simon Riggs <[email protected]>
wrote:
> On Tue, 10 May 2022 at 14:47, Ashutosh Bapat
> <[email protected]> wrote:
> >
> > On Tue, May 10, 2022 at 2:43 PM Simon Riggs
> > <[email protected]> wrote:
> > >
> > > A minor issue, and patch.
> > >
> > > REINDEX DATABASE currently requires you to write REINDEX DATABASE
> > > dbname, which makes this a little less usable than we might like.
> > >
> > > REINDEX on the catalog can cause deadlocks, which also makes REINDEX
> > > DATABASE not much use in practice, and is the reason there is no test
> > > for REINDEX DATABASE. Another reason why it is a little less usable
> > > than we might like.
> > >
> > > Seems we should do something about these historic issues in the name
> > > of product usability.
> > >
> > > Attached patch allows new syntax for REINDEX DATABASE, without needing
> > > to specify dbname. That version of the command skips catalog tables,
> > > as a way of avoiding the known deadlocks. Patch also adds a test.
> > >
> >
> > From the patch it looks like with the patch applied running REINDEX
> > DATABASE is equivalent to running REINDEX DATABASE <current database>
> > except reindexing the shared catalogs. Is that correct?
>
> Yes
>
> > Though the patch adds following change
> > + Indexes on shared system catalogs are also processed, unless the
> > + database name is omitted, in which case system catalog indexes
> > are skipped.
> >
> > the syntax looks unintuitive.
> >
> > I think REINDEX DATABASE reindexing the current database is a good
> > usability improvement in itself. But skipping the shared catalogs
> > needs an explicity syntax. Not sure how feasible it is but something
> > like REINDEX DATABASE skip SHARED/SYSTEM.
>
> There are two commands:
>
> REINDEX DATABASE does every except system catalogs
> REINDEX SYSTEM does system catalogs only
>
IIUC
REINDEX DATABASE <database name> does system catalogs as well
REINDEX DATABASE does everything except system catalogs
That's confusing and unintuitive.
Not providing the database name leads to ignoring system catalogs. I won't
expect that from this syntax.
> So taken together, the two commands seem intuitive to me.
>
> It is designed like this because it is dangerous to REINDEX the system
> catalogs because of potential deadlocks, so we want a way to avoid
> that problem.
>
It's more clear if we add SKIP SYSTEM CATALOGS or some such explicit syntax.
--
Best Wishes,
Ashutosh
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-11 05:42 Michael Paquier <[email protected]>
parent: Ashutosh Bapat <[email protected]>
1 sibling, 1 reply; 41+ messages in thread
From: Michael Paquier @ 2022-05-11 05:42 UTC (permalink / raw)
To: Ashutosh Bapat <[email protected]>; +Cc: Simon Riggs <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers
On Wed, May 11, 2022 at 09:54:17AM +0530, Ashutosh Bapat wrote:
> REINDEX DATABASE <database name> does system catalogs as well
> REINDEX DATABASE does everything except system catalogs
>
> That's confusing and unintuitive.
Agreed. Nobody is going to remember the difference. REINDEX's
parsing grammar is designed to be extensible because we have the
parenthesized flavor. Why don't you add an option there to skip the
catalogs, like a SKIP_CATALOG?
> Not providing the database name leads to ignoring system catalogs. I won't
> expect that from this syntax.
I don't disagree with having a shortened grammar where the database
name is not required because one cannot reindex a database different
than the one connected to, but changing a behavior based on such a
grammar difference is not a good user experience.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-11 08:00 Bernd Helmle <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Bernd Helmle @ 2022-05-11 08:00 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; Ashutosh Bapat <[email protected]>; +Cc: Simon Riggs <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers
Am Mittwoch, dem 11.05.2022 um 14:42 +0900 schrieb Michael Paquier:
> Agreed. Nobody is going to remember the difference. REINDEX's
> parsing grammar is designed to be extensible because we have the
> parenthesized flavor. Why don't you add an option there to skip the
> catalogs, like a SKIP_CATALOG?
+1
Having an option is probably the best idea. Though we have REINDEX
SYSTEM, so i throw SKIP_SYSTEM into the ring as an alternative. This
would be consistent with the meaning of both commands/options.
Thanks,
Bernd
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-11 14:33 Simon Riggs <[email protected]>
parent: Ashutosh Bapat <[email protected]>
1 sibling, 2 replies; 41+ messages in thread
From: Simon Riggs @ 2022-05-11 14:33 UTC (permalink / raw)
To: Ashutosh Bapat <[email protected]>; +Cc: Ashutosh Bapat <[email protected]>; pgsql-hackers
On Wed, 11 May 2022 at 05:24, Ashutosh Bapat
<[email protected]> wrote:
>> It is designed like this because it is dangerous to REINDEX the system
>> catalogs because of potential deadlocks, so we want a way to avoid
>> that problem.
>
> It's more clear if we add SKIP SYSTEM CATALOGS or some such explicit syntax.
Clarity is not the issue. I am opposed to a default mode that does
something bad and non-useful.
If you want to reindex the system catalogs then we already have REINDEX SYSTEM.
So REINDEX (SKIP_SYSTEM_CATALOGS OFF) DATABASE would do the same thing.
But you don't want to run either of them because of deadlocking.
The only action that makes sense is to reindex the database, skipping
the catalog tables.
So I'm proposing a command that has useful default behavior.
i.e. REINDEX DATABASE is the same as REINDEX (SKIP_SYSTEM_CATALOGS ON) DATABASE.
If you make REINDEX DATABASE the same as REINDEX (SKIP_SYSTEM_CATALOGS
OFF) DATABASE then it is just dangerous and annoying, i.e. a POLA
violation.
The point of this was a usability improvement, not just new syntax.
--
Simon Riggs http://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-27 19:08 Cary Huang <[email protected]>
parent: Simon Riggs <[email protected]>
1 sibling, 1 reply; 41+ messages in thread
From: Cary Huang @ 2022-05-27 19:08 UTC (permalink / raw)
To: [email protected]; +Cc: Simon Riggs <[email protected]>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hello
The patch applies and tests fine and I think this patch has good intentions to prevent the default behavior of REINDEX DATABASE to cause a deadlock. However, I am not in favor of simply omitting the database name after DATABASE clause because of consistency. Almost all other queries involving the DATABASE clause require database name to be given following after. For example, ALTER DATABASE [dbname].
Being able to omit database name for REINDEX DATABASE seems inconsistent to me.
The documentation states that REINDEX DATABASE only works on the current database, but it still requires the user to provide a database name and require that it must match the current database. Not very useful option, isn’t it? But it is still required from the user to stay consistent with other DATABASE clauses.
Maybe the best way is to keep the query clause as is (with the database name still required) and simply don’t let it reindex system catalog to prevent deadlock. At the end, give user a notification that system catalogs have not been reindexed, and tell them to use REINDEX SYSTEM instead.
Cary Huang
-----------------
HighGo Software Canada
www.highgo.ca
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-31 08:51 Bernd Helmle <[email protected]>
parent: Cary Huang <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Bernd Helmle @ 2022-05-31 08:51 UTC (permalink / raw)
To: Cary Huang <[email protected]>; [email protected]; +Cc: Simon Riggs <[email protected]>
Am Freitag, dem 27.05.2022 um 19:08 +0000 schrieb Cary Huang:
[...]
> The patch applies and tests fine and I think this patch has good
> intentions to prevent the default behavior of REINDEX DATABASE to
> cause a deadlock. However, I am not in favor of simply omitting the
> database name after DATABASE clause because of consistency. Almost
> all other queries involving the DATABASE clause require database name
> to be given following after. For example, ALTER DATABASE [dbname].
>
> Being able to omit database name for REINDEX DATABASE seems
> inconsistent to me.
>
> The documentation states that REINDEX DATABASE only works on the
> current database, but it still requires the user to provide a
> database name and require that it must match the current database.
> Not very useful option, isn’t it? But it is still required from the
> user to stay consistent with other DATABASE clauses.
>
Hmm, right, but you can see this from another perspective, too: For
example, ALTER DATABASE works by adjusting properties of other
databases very well, SET TABLESPACE can be used when not connected to
the target database only, so you are required to specify its name in
that case.
REINDEX DATABASE cannot reindex other databases than the one we're
connected to. Seen from that point, i currently can't see the logical
justification to have the database name there, besides of "yes, i
really meant that database i am connected to" or consistency.
> Maybe the best way is to keep the query clause as is (with the
> database name still required) and simply don’t let it reindex system
> catalog to prevent deadlock. At the end, give user a notification
> that system catalogs have not been reindexed, and tell them to use
> REINDEX SYSTEM instead.
+1
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-31 09:04 Bernd Helmle <[email protected]>
parent: Simon Riggs <[email protected]>
1 sibling, 1 reply; 41+ messages in thread
From: Bernd Helmle @ 2022-05-31 09:04 UTC (permalink / raw)
To: Simon Riggs <[email protected]>; Ashutosh Bapat <[email protected]>; +Cc: pgsql-hackers; Ashutosh Bapat <[email protected]>
Am Dienstag, dem 10.05.2022 um 15:00 +0100 schrieb Simon Riggs:
[...]
>
> > I think REINDEX DATABASE reindexing the current database is a good
> > usability improvement in itself. But skipping the shared catalogs
> > needs an explicity syntax. Not sure how feasible it is but
> > something
> > like REINDEX DATABASE skip SHARED/SYSTEM.
>
> There are two commands:
>
> REINDEX DATABASE does every except system catalogs
> REINDEX SYSTEM does system catalogs only
>
> So taken together, the two commands seem intuitive to me.
>
> It is designed like this because it is dangerous to REINDEX the
> system
> catalogs because of potential deadlocks, so we want a way to avoid
> that problem.
>
> Perhaps I can improve the docs more, will look.
>
And we already have a situation where this already happens with REINDEX
DATABASE: if you use CONCURRENTLY, it skips system catalogs already and
prints a warning. In both cases there are good technical reasons to
skip catalog indexes and to change the workflow to use separate
commands.
Bernd
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-31 12:09 Michael Paquier <[email protected]>
parent: Bernd Helmle <[email protected]>
0 siblings, 1 reply; 41+ messages in thread
From: Michael Paquier @ 2022-05-31 12:09 UTC (permalink / raw)
To: Bernd Helmle <[email protected]>; +Cc: Simon Riggs <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On Tue, May 31, 2022 at 11:04:58AM +0200, Bernd Helmle wrote:
> And we already have a situation where this already happens with REINDEX
> DATABASE: if you use CONCURRENTLY, it skips system catalogs already and
> prints a warning. In both cases there are good technical reasons to
> skip catalog indexes and to change the workflow to use separate
> commands.
The case with CONCURRENTLY is different though: the option will never
work on system catalogs so we have to skip them. Echoing with others
on this thread, I don't think that we should introduce a different
behavior on what's basically the same grammar. That's just going to
lead to more confusion. So REINDEX DATABASE with or without a
database name appended to it should always mean to reindex the
catalogs on top of the existing relations.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-05-31 12:30 Alvaro Herrera <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 1 reply; 41+ messages in thread
From: Alvaro Herrera @ 2022-05-31 12:30 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Bernd Helmle <[email protected]>; Simon Riggs <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On 2022-May-31, Michael Paquier wrote:
> The case with CONCURRENTLY is different though: the option will never
> work on system catalogs so we have to skip them. Echoing with others
> on this thread, I don't think that we should introduce a different
> behavior on what's basically the same grammar. That's just going to
> lead to more confusion. So REINDEX DATABASE with or without a
> database name appended to it should always mean to reindex the
> catalogs on top of the existing relations.
I was thinking the opposite: REINDEX DATABASE with or without a database
name should always process the user relations and skip system catalogs.
If the user wants to do both, then they can use REINDEX SYSTEM in
addition.
The reason for doing it like this is that there is no way to process
only user tables and skip catalogs. So this is better for
composability.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Most hackers will be perfectly comfortable conceptualizing users as entropy
sources, so let's move on." (Nathaniel Smith)
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-06-02 00:02 Michael Paquier <[email protected]>
parent: Alvaro Herrera <[email protected]>
0 siblings, 1 reply; 41+ messages in thread
From: Michael Paquier @ 2022-06-02 00:02 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; +Cc: Bernd Helmle <[email protected]>; Simon Riggs <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On Tue, May 31, 2022 at 02:30:32PM +0200, Alvaro Herrera wrote:
> I was thinking the opposite: REINDEX DATABASE with or without a database
> name should always process the user relations and skip system catalogs.
> If the user wants to do both, then they can use REINDEX SYSTEM in
> addition.
>
> The reason for doing it like this is that there is no way to process
> only user tables and skip catalogs. So this is better for
> composability.
No objections from me to keep this distinction at the end, as long as
the the database name in the command has no impact on the chosen
behavior. Could there be a point in having a REINDEX ALL though that
would process both the user relations and the catalogs, doing the same
thing as REINDEX DATABASE today?
By the way, the patch had better avoid putting a global REINDEX
command that would process everything. As far as I recall, we've
avoided such things on purpose because they are expensive, keeping
around only cases that generate errors or skip all the relations.
So having that in a TAP test would be better, I assume, for
isolation.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-06-28 00:18 Justin Pryzby <[email protected]>
parent: Simon Riggs <[email protected]>
1 sibling, 0 replies; 41+ messages in thread
From: Justin Pryzby @ 2022-06-28 00:18 UTC (permalink / raw)
To: Simon Riggs <[email protected]>; +Cc: Ashutosh Bapat <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers
Maybe the answer is to 1) add a parenthesized option REINDEX(SYSTEM) (to allow
the current behavior); and 2) make REINDEX DATABASE an alias which implies
"SYSTEM false"; 3) prohibit REINDEX (SYSTEM true) SYSTEM, or consider removing
"REINDEX SYSTEM;".
That avoids the opaque and surprising behavior that "REINDEX DATABASE" skips
system stuff but "REINDEX DATABASE foo" doesn't, while allowing the old
behavior (disabled by default).
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-06-28 07:29 Simon Riggs <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 1 reply; 41+ messages in thread
From: Simon Riggs @ 2022-06-28 07:29 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Bernd Helmle <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On Thu, 2 Jun 2022 at 01:02, Michael Paquier <[email protected]> wrote:
>
> On Tue, May 31, 2022 at 02:30:32PM +0200, Alvaro Herrera wrote:
> > I was thinking the opposite: REINDEX DATABASE with or without a database
> > name should always process the user relations and skip system catalogs.
> > If the user wants to do both, then they can use REINDEX SYSTEM in
> > addition.
> >
> > The reason for doing it like this is that there is no way to process
> > only user tables and skip catalogs. So this is better for
> > composability.
>
> No objections from me to keep this distinction at the end, as long as
> the the database name in the command has no impact on the chosen
> behavior.
OK, that's clear. Will progress.
> Could there be a point in having a REINDEX ALL though that
> would process both the user relations and the catalogs, doing the same
> thing as REINDEX DATABASE today?
A key point is that REINDEX SYSTEM has problems, so should be avoided.
Hence, including both database and system together in a new command
would not be great idea, at this time.
--
Simon Riggs http://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-06-28 10:02 Simon Riggs <[email protected]>
parent: Simon Riggs <[email protected]>
0 siblings, 1 reply; 41+ messages in thread
From: Simon Riggs @ 2022-06-28 10:02 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Bernd Helmle <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On Tue, 28 Jun 2022 at 08:29, Simon Riggs <[email protected]> wrote:
>
> On Thu, 2 Jun 2022 at 01:02, Michael Paquier <[email protected]> wrote:
> >
> > On Tue, May 31, 2022 at 02:30:32PM +0200, Alvaro Herrera wrote:
> > > I was thinking the opposite: REINDEX DATABASE with or without a database
> > > name should always process the user relations and skip system catalogs.
> > > If the user wants to do both, then they can use REINDEX SYSTEM in
> > > addition.
> > >
> > > The reason for doing it like this is that there is no way to process
> > > only user tables and skip catalogs. So this is better for
> > > composability.
> >
> > No objections from me to keep this distinction at the end, as long as
> > the the database name in the command has no impact on the chosen
> > behavior.
>
> OK, that's clear. Will progress.
Attached patch is tested, documented and imho ready to be committed,
so I will mark it so in CFapp.
--
Simon Riggs http://www.EnterpriseDB.com/
Attachments:
[application/octet-stream] reindex_not_require_database_name.v3.patch (7.3K, ../../CANbhV-EmOh-XTssH5TwannC2S1VDN5zK-b+oZKs8UdyUtc2oUw@mail.gmail.com/2-reindex_not_require_database_name.v3.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index 336ca24b31..ef74a72b3c 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -22,6 +22,7 @@ PostgreSQL documentation
<refsynopsisdiv>
<synopsis>
REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { INDEX | TABLE | SCHEMA | DATABASE | SYSTEM } [ CONCURRENTLY ] <replaceable class="parameter">name</replaceable>
+REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { DATABASE | SYSTEM } [ CONCURRENTLY ] [ <replaceable class="parameter">name</replaceable> ]
<phrase>where <replaceable class="parameter">option</replaceable> can be one of:</phrase>
@@ -126,8 +127,9 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
<term><literal>DATABASE</literal></term>
<listitem>
<para>
- Recreate all indexes within the current database.
- Indexes on shared system catalogs are also processed.
+ Recreate all indexes within the current database, except system
+ catalogs.
+ Indexes on shared system catalogs are not processed.
This form of <command>REINDEX</command> cannot be executed inside a
transaction block.
</para>
@@ -155,7 +157,7 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
reindexed. Index and table names can be schema-qualified.
Presently, <command>REINDEX DATABASE</command> and <command>REINDEX SYSTEM</command>
can only reindex the current database, so their parameter must match
- the current database's name.
+ the current database's name, if supplied, though supplying the name is optional.
</para>
</listitem>
</varlistentry>
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
index 99f5ab83c3..df10262f73 100644
--- a/src/backend/commands/indexcmds.c
+++ b/src/backend/commands/indexcmds.c
@@ -2877,10 +2877,13 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
bool concurrent_warning = false;
bool tablespace_warning = false;
- AssertArg(objectName);
Assert(objectKind == REINDEX_OBJECT_SCHEMA ||
objectKind == REINDEX_OBJECT_SYSTEM ||
objectKind == REINDEX_OBJECT_DATABASE);
+ /*
+ * This matches the options enforced by the grammar.
+ */
+ AssertArg(objectName || objectKind != REINDEX_OBJECT_SCHEMA);
if (objectKind == REINDEX_OBJECT_SYSTEM &&
(params->options & REINDEXOPT_CONCURRENTLY) != 0)
@@ -2906,13 +2909,13 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
{
objectOid = MyDatabaseId;
- if (strcmp(objectName, get_database_name(objectOid)) != 0)
+ if (objectName && strcmp(objectName, get_database_name(objectOid)) != 0)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("can only reindex the currently open database")));
if (!pg_database_ownercheck(objectOid, GetUserId()))
aclcheck_error(ACLCHECK_NOT_OWNER, OBJECT_DATABASE,
- objectName);
+ get_database_name(objectOid));
}
/*
@@ -2970,10 +2973,24 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
!isTempNamespace(classtuple->relnamespace))
continue;
- /* Check user/system classification, and optionally skip */
- if (objectKind == REINDEX_OBJECT_SYSTEM &&
- !IsSystemClass(relid, classtuple))
- continue;
+ /*
+ * Check user/system classification, and skip appropriately.
+ */
+ if (objectKind == REINDEX_OBJECT_SYSTEM)
+ {
+ if (!IsSystemClass(relid, classtuple))
+ continue;
+ }
+ else if (objectKind == REINDEX_OBJECT_DATABASE)
+ {
+ /*
+ * You might think it would be good to include catalogs,
+ * but doing that can deadlock, so isn't much use in real world,
+ * nor can we safely test that it even works.
+ */
+ if (IsSystemClass(relid, classtuple))
+ continue;
+ }
/*
* The table can be reindexed if the user is superuser, the table
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 969c9c158f..25a5192595 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -560,7 +560,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
%type <defelt> generic_option_elem alter_generic_option_elem
%type <list> generic_option_list alter_generic_option_list
-%type <ival> reindex_target_type reindex_target_multitable
+%type <ival> reindex_target_type reindex_target_multitable reindex_name_optional
%type <node> copy_generic_opt_arg copy_generic_opt_arg_list_item
%type <defelt> copy_generic_opt_elem
@@ -9105,6 +9105,24 @@ ReindexStmt:
makeDefElem("concurrently", NULL, @3));
$$ = (Node *) n;
}
+ | REINDEX reindex_name_optional
+ {
+ ReindexStmt *n = makeNode(ReindexStmt);
+ n->kind = $2;
+ n->name = NULL;
+ n->relation = NULL;
+ n->params = NIL;
+ $$ = (Node *)n;
+ }
+ | REINDEX '(' utility_option_list ')' reindex_name_optional
+ {
+ ReindexStmt *n = makeNode(ReindexStmt);
+ n->kind = $5;
+ n->name = NULL;
+ n->relation = NULL;
+ n->params = $3;
+ $$ = (Node *)n;
+ }
| REINDEX '(' utility_option_list ')' reindex_target_type opt_concurrently qualified_name
{
ReindexStmt *n = makeNode(ReindexStmt);
@@ -9141,6 +9159,11 @@ reindex_target_multitable:
| SYSTEM_P { $$ = REINDEX_OBJECT_SYSTEM; }
| DATABASE { $$ = REINDEX_OBJECT_DATABASE; }
;
+/* For these options the name is optional */
+reindex_name_optional:
+ SYSTEM_P { $$ = REINDEX_OBJECT_SYSTEM; }
+ | DATABASE { $$ = REINDEX_OBJECT_DATABASE; }
+ ;
/*****************************************************************************
*
diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out
index d55aec3a1d..e697da6e81 100644
--- a/src/test/regress/expected/create_index.out
+++ b/src/test/regress/expected/create_index.out
@@ -2808,6 +2808,12 @@ ERROR: REINDEX SCHEMA cannot run inside a transaction block
END;
-- concurrently
REINDEX SCHEMA CONCURRENTLY schema_to_reindex;
+-- unqualified reindex database
+-- if you want to test REINDEX DATABASE, uncomment the following line,
+-- but note that this adds about 0.5s to the regression tests and the
+-- results are volatile when run in parallel to other tasks. Note also
+-- that REINDEX SYSTEM is specifically not tested because it can deadlock.
+-- REINDEX (VERBOSE) DATABASE;
-- Failure for unauthorized user
CREATE ROLE regress_reindexuser NOLOGIN;
SET SESSION ROLE regress_reindexuser;
diff --git a/src/test/regress/sql/create_index.sql b/src/test/regress/sql/create_index.sql
index d8fded3d93..19abc1d210 100644
--- a/src/test/regress/sql/create_index.sql
+++ b/src/test/regress/sql/create_index.sql
@@ -1235,6 +1235,13 @@ END;
-- concurrently
REINDEX SCHEMA CONCURRENTLY schema_to_reindex;
+-- unqualified reindex database
+-- if you want to test REINDEX DATABASE, uncomment the following line,
+-- but note that this adds about 0.5s to the regression tests and the
+-- results are volatile when run in parallel to other tasks. Note also
+-- that REINDEX SYSTEM is specifically not tested because it can deadlock.
+-- REINDEX (VERBOSE) DATABASE;
+
-- Failure for unauthorized user
CREATE ROLE regress_reindexuser NOLOGIN;
SET SESSION ROLE regress_reindexuser;
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-06-29 04:35 Michael Paquier <[email protected]>
parent: Simon Riggs <[email protected]>
0 siblings, 1 reply; 41+ messages in thread
From: Michael Paquier @ 2022-06-29 04:35 UTC (permalink / raw)
To: Simon Riggs <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Bernd Helmle <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On Tue, Jun 28, 2022 at 11:02:25AM +0100, Simon Riggs wrote:
> Attached patch is tested, documented and imho ready to be committed,
> so I will mark it so in CFapp.
The behavior introduced by this patch should be reflected in
reindexdb. See in particular reindex_one_database(), where a
REINDEX_SYSTEM is enforced first on the catalogs for the
non-concurrent mode when running the reindex on a database.
+-- unqualified reindex database
+-- if you want to test REINDEX DATABASE, uncomment the following line,
+-- but note that this adds about 0.5s to the regression tests and the
+-- results are volatile when run in parallel to other tasks. Note also
+-- that REINDEX SYSTEM is specifically not tested because it can deadlock.
+-- REINDEX (VERBOSE) DATABASE;
No need to add that IMHO.
REINDEX [ ( <replaceable class="parameter">option</replaceable> [,
...] ) ] { INDEX | TABLE | SCHEMA | DATABASE | SYSTEM } [
CONCURRENTLY ] <replaceable class="parameter">name</replaceable>
+REINDEX [ ( <replaceable class="parameter">option</replaceable> [,
...] ) ] { DATABASE | SYSTEM } [ CONCURRENTLY ] [ <replaceable
class="parameter">name</replaceable> ]
Shouldn't you remove DATABASE and SYSTEM from the first line, keeping
only INDEX. TABLE and SCHEMA? The second line, with its optional
"name" would cover the DATABASE and SYSTEM cases at 100%.
- if (strcmp(objectName, get_database_name(objectOid)) != 0)
+ if (objectName && strcmp(objectName, get_database_name(objectOid)) != 0)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("can only reindex the currently open database")));
if (!pg_database_ownercheck(objectOid, GetUserId()))
aclcheck_error(ACLCHECK_NOT_OWNER, OBJECT_DATABASE,
- objectName);
+ get_database_name(objectOid));
This could call get_database_name() just once.
+ * You might think it would be good to include catalogs,
+ * but doing that can deadlock, so isn't much use in real world,
+ * nor can we safely test that it even works.
Not sure what you mean here exactly.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../YrvWoAsaX%[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 41+ messages in thread
* Re: Allowing REINDEX to have an optional name
@ 2022-06-29 14:02 Simon Riggs <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 0 replies; 41+ messages in thread
From: Simon Riggs @ 2022-06-29 14:02 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Bernd Helmle <[email protected]>; Ashutosh Bapat <[email protected]>; pgsql-hackers; Ashutosh Bapat <[email protected]>
On Wed, 29 Jun 2022 at 05:35, Michael Paquier <[email protected]> wrote:
>
> On Tue, Jun 28, 2022 at 11:02:25AM +0100, Simon Riggs wrote:
> > Attached patch is tested, documented and imho ready to be committed,
> > so I will mark it so in CFapp.
Thanks for the review Michael.
> The behavior introduced by this patch should be reflected in
> reindexdb. See in particular reindex_one_database(), where a
> REINDEX_SYSTEM is enforced first on the catalogs for the
> non-concurrent mode when running the reindex on a database.
Originally, I was trying to avoid changing prior behavior, but now
that we have agreed to do so, this makes sense.
That section of code has been removed, tests updated. No changes to
docs seem to be required.
> +-- unqualified reindex database
> +-- if you want to test REINDEX DATABASE, uncomment the following line,
> +-- but note that this adds about 0.5s to the regression tests and the
> +-- results are volatile when run in parallel to other tasks. Note also
> +-- that REINDEX SYSTEM is specifically not tested because it can deadlock.
> +-- REINDEX (VERBOSE) DATABASE;
>
> No need to add that IMHO.
That was more a comment to reviewer, but I think something should be
said for later developers.
> REINDEX [ ( <replaceable class="parameter">option</replaceable> [,
> ...] ) ] { INDEX | TABLE | SCHEMA | DATABASE | SYSTEM } [
> CONCURRENTLY ] <replaceable class="parameter">name</replaceable>
> +REINDEX [ ( <replaceable class="parameter">option</replaceable> [,
> ...] ) ] { DATABASE | SYSTEM } [ CONCURRENTLY ] [ <replaceable
> class="parameter">name</replaceable> ]
>
> Shouldn't you remove DATABASE and SYSTEM from the first line, keeping
> only INDEX. TABLE and SCHEMA? The second line, with its optional
> "name" would cover the DATABASE and SYSTEM cases at 100%.
I agree that your proposal is clearer. Done.
> - if (strcmp(objectName, get_database_name(objectOid)) != 0)
> + if (objectName && strcmp(objectName, get_database_name(objectOid)) != 0)
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> errmsg("can only reindex the currently open database")));
> if (!pg_database_ownercheck(objectOid, GetUserId()))
> aclcheck_error(ACLCHECK_NOT_OWNER, OBJECT_DATABASE,
> - objectName);
> + get_database_name(objectOid));
>
> This could call get_database_name() just once.
It could, but I couldn't see any benefit in changing that for the code
under discussion.
If calling get_database_name() multiple times is an issue, I've added
a cache for that - another patch attached, if you think its worth it.
> + * You might think it would be good to include catalogs,
> + * but doing that can deadlock, so isn't much use in real world,
> + * nor can we safely test that it even works.
>
> Not sure what you mean here exactly.
REINDEX SYSTEM can deadlock, which is why we are avoiding it.
This was a comment to later developers as to why things are done that
way. Feel free to update the wording or location, but something should
be mentioned to avoid later discussion.
Thanks for the review, new version attached.
--
Simon Riggs http://www.EnterpriseDB.com/
Attachments:
[application/octet-stream] reindex_not_require_database_name.v5.patch (9.6K, ../../CANbhV-EL4+RK49Qmk66zFmTiEEhT6TKia0ow_t5zogV1-FfAEw@mail.gmail.com/2-reindex_not_require_database_name.v5.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index 336ca24b31..143847dfa9 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -21,7 +21,8 @@ PostgreSQL documentation
<refsynopsisdiv>
<synopsis>
-REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { INDEX | TABLE | SCHEMA | DATABASE | SYSTEM } [ CONCURRENTLY ] <replaceable class="parameter">name</replaceable>
+REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { INDEX | TABLE | SCHEMA } [ CONCURRENTLY ] <replaceable class="parameter">name</replaceable>
+REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { DATABASE | SYSTEM } [ CONCURRENTLY ] [ <replaceable class="parameter">name</replaceable> ]
<phrase>where <replaceable class="parameter">option</replaceable> can be one of:</phrase>
@@ -126,8 +127,9 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
<term><literal>DATABASE</literal></term>
<listitem>
<para>
- Recreate all indexes within the current database.
- Indexes on shared system catalogs are also processed.
+ Recreate all indexes within the current database, except system
+ catalogs.
+ Indexes on shared system catalogs are not processed.
This form of <command>REINDEX</command> cannot be executed inside a
transaction block.
</para>
@@ -155,7 +157,7 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
reindexed. Index and table names can be schema-qualified.
Presently, <command>REINDEX DATABASE</command> and <command>REINDEX SYSTEM</command>
can only reindex the current database, so their parameter must match
- the current database's name.
+ the current database's name, if supplied, though supplying the name is optional.
</para>
</listitem>
</varlistentry>
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
index 99f5ab83c3..df10262f73 100644
--- a/src/backend/commands/indexcmds.c
+++ b/src/backend/commands/indexcmds.c
@@ -2877,10 +2877,13 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
bool concurrent_warning = false;
bool tablespace_warning = false;
- AssertArg(objectName);
Assert(objectKind == REINDEX_OBJECT_SCHEMA ||
objectKind == REINDEX_OBJECT_SYSTEM ||
objectKind == REINDEX_OBJECT_DATABASE);
+ /*
+ * This matches the options enforced by the grammar.
+ */
+ AssertArg(objectName || objectKind != REINDEX_OBJECT_SCHEMA);
if (objectKind == REINDEX_OBJECT_SYSTEM &&
(params->options & REINDEXOPT_CONCURRENTLY) != 0)
@@ -2906,13 +2909,13 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
{
objectOid = MyDatabaseId;
- if (strcmp(objectName, get_database_name(objectOid)) != 0)
+ if (objectName && strcmp(objectName, get_database_name(objectOid)) != 0)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("can only reindex the currently open database")));
if (!pg_database_ownercheck(objectOid, GetUserId()))
aclcheck_error(ACLCHECK_NOT_OWNER, OBJECT_DATABASE,
- objectName);
+ get_database_name(objectOid));
}
/*
@@ -2970,10 +2973,24 @@ ReindexMultipleTables(const char *objectName, ReindexObjectType objectKind,
!isTempNamespace(classtuple->relnamespace))
continue;
- /* Check user/system classification, and optionally skip */
- if (objectKind == REINDEX_OBJECT_SYSTEM &&
- !IsSystemClass(relid, classtuple))
- continue;
+ /*
+ * Check user/system classification, and skip appropriately.
+ */
+ if (objectKind == REINDEX_OBJECT_SYSTEM)
+ {
+ if (!IsSystemClass(relid, classtuple))
+ continue;
+ }
+ else if (objectKind == REINDEX_OBJECT_DATABASE)
+ {
+ /*
+ * You might think it would be good to include catalogs,
+ * but doing that can deadlock, so isn't much use in real world,
+ * nor can we safely test that it even works.
+ */
+ if (IsSystemClass(relid, classtuple))
+ continue;
+ }
/*
* The table can be reindexed if the user is superuser, the table
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 969c9c158f..25a5192595 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -560,7 +560,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
%type <defelt> generic_option_elem alter_generic_option_elem
%type <list> generic_option_list alter_generic_option_list
-%type <ival> reindex_target_type reindex_target_multitable
+%type <ival> reindex_target_type reindex_target_multitable reindex_name_optional
%type <node> copy_generic_opt_arg copy_generic_opt_arg_list_item
%type <defelt> copy_generic_opt_elem
@@ -9105,6 +9105,24 @@ ReindexStmt:
makeDefElem("concurrently", NULL, @3));
$$ = (Node *) n;
}
+ | REINDEX reindex_name_optional
+ {
+ ReindexStmt *n = makeNode(ReindexStmt);
+ n->kind = $2;
+ n->name = NULL;
+ n->relation = NULL;
+ n->params = NIL;
+ $$ = (Node *)n;
+ }
+ | REINDEX '(' utility_option_list ')' reindex_name_optional
+ {
+ ReindexStmt *n = makeNode(ReindexStmt);
+ n->kind = $5;
+ n->name = NULL;
+ n->relation = NULL;
+ n->params = $3;
+ $$ = (Node *)n;
+ }
| REINDEX '(' utility_option_list ')' reindex_target_type opt_concurrently qualified_name
{
ReindexStmt *n = makeNode(ReindexStmt);
@@ -9141,6 +9159,11 @@ reindex_target_multitable:
| SYSTEM_P { $$ = REINDEX_OBJECT_SYSTEM; }
| DATABASE { $$ = REINDEX_OBJECT_DATABASE; }
;
+/* For these options the name is optional */
+reindex_name_optional:
+ SYSTEM_P { $$ = REINDEX_OBJECT_SYSTEM; }
+ | DATABASE { $$ = REINDEX_OBJECT_DATABASE; }
+ ;
/*****************************************************************************
*
diff --git a/src/bin/scripts/reindexdb.c b/src/bin/scripts/reindexdb.c
index f3b03ec325..0e93a4eeff 100644
--- a/src/bin/scripts/reindexdb.c
+++ b/src/bin/scripts/reindexdb.c
@@ -360,18 +360,6 @@ reindex_one_database(ConnParams *cparams, ReindexType type,
{
case REINDEX_DATABASE:
- /*
- * Database-wide parallel reindex requires special processing.
- * If multiple jobs were asked, we have to reindex system
- * catalogs first as they cannot be processed in parallel.
- */
- if (concurrently)
- pg_log_warning("cannot reindex system catalogs concurrently, skipping all");
- else
- run_reindex_command(conn, REINDEX_SYSTEM, PQdb(conn), echo,
- verbose, concurrently, false,
- tablespace);
-
/* Build a list of relations from the database */
process_list = get_parallel_object_list(conn, process_type,
user_list, echo);
diff --git a/src/bin/scripts/t/090_reindexdb.pl b/src/bin/scripts/t/090_reindexdb.pl
index 398fc4e6bb..fd422b3d3d 100644
--- a/src/bin/scripts/t/090_reindexdb.pl
+++ b/src/bin/scripts/t/090_reindexdb.pl
@@ -176,11 +176,6 @@ $node->command_fails(
$node->command_fails(
[ 'reindexdb', '-j', '2', '-i', 'i1', 'postgres' ],
'parallel reindexdb cannot process indexes');
-$node->issues_sql_like(
- [ 'reindexdb', '-j', '2', 'postgres' ],
- qr/statement:\ REINDEX SYSTEM postgres;
-.*statement:\ REINDEX TABLE public\.test1/s,
- 'parallel reindexdb for database issues REINDEX SYSTEM first');
# Note that the ordering of the commands is not stable, so the second
# command for s2.t2 is not checked after.
$node->issues_sql_like(
@@ -190,13 +185,8 @@ $node->issues_sql_like(
$node->command_ok(
[ 'reindexdb', '-j', '2', '-S', 's3' ],
'parallel reindexdb with empty schema');
-$node->command_checks_all(
+$node->command_ok(
[ 'reindexdb', '-j', '2', '--concurrently', '-d', 'postgres' ],
- 0,
- [qr/^$/],
- [
- qr/^reindexdb: warning: cannot reindex system catalogs concurrently, skipping all/s
- ],
- 'parallel reindexdb for system with --concurrently skips catalogs');
+ 'parallel reindexdb with empty schema, concurrently');
done_testing();
diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out
index d55aec3a1d..e697da6e81 100644
--- a/src/test/regress/expected/create_index.out
+++ b/src/test/regress/expected/create_index.out
@@ -2808,6 +2808,12 @@ ERROR: REINDEX SCHEMA cannot run inside a transaction block
END;
-- concurrently
REINDEX SCHEMA CONCURRENTLY schema_to_reindex;
+-- unqualified reindex database
+-- if you want to test REINDEX DATABASE, uncomment the following line,
+-- but note that this adds about 0.5s to the regression tests and the
+-- results are volatile when run in parallel to other tasks. Note also
+-- that REINDEX SYSTEM is specifically not tested because it can deadlock.
+-- REINDEX (VERBOSE) DATABASE;
-- Failure for unauthorized user
CREATE ROLE regress_reindexuser NOLOGIN;
SET SESSION ROLE regress_reindexuser;
diff --git a/src/test/regress/sql/create_index.sql b/src/test/regress/sql/create_index.sql
index d8fded3d93..19abc1d210 100644
--- a/src/test/regress/sql/create_index.sql
+++ b/src/test/regress/sql/create_index.sql
@@ -1235,6 +1235,13 @@ END;
-- concurrently
REINDEX SCHEMA CONCURRENTLY schema_to_reindex;
+-- unqualified reindex database
+-- if you want to test REINDEX DATABASE, uncomment the following line,
+-- but note that this adds about 0.5s to the regression tests and the
+-- results are volatile when run in parallel to other tasks. Note also
+-- that REINDEX SYSTEM is specifically not tested because it can deadlock.
+-- REINDEX (VERBOSE) DATABASE;
+
-- Failure for unauthorized user
CREATE ROLE regress_reindexuser NOLOGIN;
SET SESSION ROLE regress_reindexuser;
[application/octet-stream] cache_get_database_name.v1.patch (1.2K, ../../CANbhV-EL4+RK49Qmk66zFmTiEEhT6TKia0ow_t5zogV1-FfAEw@mail.gmail.com/3-cache_get_database_name.v1.patch)
download | inline diff:
diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c
index f269168401..dcd6e3b01c 100644
--- a/src/backend/commands/dbcommands.c
+++ b/src/backend/commands/dbcommands.c
@@ -2988,18 +2988,31 @@ get_database_oid(const char *dbname, bool missing_ok)
/*
* get_database_name - given a database OID, look up the name
*
- * Returns a palloc'd string, or NULL if no such database.
+ * Returns NULL if no such database, or if dbid matches MyDatabaseId
+ * it returns a pointer to a static string, otherwise a palloc'd string.
*/
char *
get_database_name(Oid dbid)
{
HeapTuple dbtuple;
+ static char MyDatabaseName[NAMEDATALEN];
+ static bool cached = false;
char *result;
+ if (cached && dbid == MyDatabaseId)
+ return MyDatabaseName;
+
dbtuple = SearchSysCache1(DATABASEOID, ObjectIdGetDatum(dbid));
if (HeapTupleIsValid(dbtuple))
{
- result = pstrdup(NameStr(((Form_pg_database) GETSTRUCT(dbtuple))->datname));
+ if (!cached && dbid == MyDatabaseId)
+ {
+ strcpy(MyDatabaseName, NameStr(((Form_pg_database) GETSTRUCT(dbtuple))->datname));
+ cached = true;
+ result = MyDatabaseName;
+ }
+ else
+ result = pstrdup(NameStr(((Form_pg_database) GETSTRUCT(dbtuple))->datname));
ReleaseSysCache(dbtuple);
}
else
^ permalink raw reply [nested|flat] 41+ messages in thread
end of thread, other threads:[~2022-06-29 14:02 UTC | newest]
Thread overview: 41+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2022-05-10 09:13 Allowing REINDEX to have an optional name Simon Riggs <[email protected]>
2022-05-10 12:29 ` Re: Allowing REINDEX to have an optional name Bernd Helmle <[email protected]>
2022-05-10 13:47 ` Re: Allowing REINDEX to have an optional name Ashutosh Bapat <[email protected]>
2022-05-10 14:00 ` Re: Allowing REINDEX to have an optional name Simon Riggs <[email protected]>
2022-05-11 04:24 ` Re: Allowing REINDEX to have an optional name Ashutosh Bapat <[email protected]>
2022-05-11 05:42 ` Re: Allowing REINDEX to have an optional name Michael Paquier <[email protected]>
2022-05-11 08:00 ` Re: Allowing REINDEX to have an optional name Bernd Helmle <[email protected]>
2022-05-11 14:33 ` Re: Allowing REINDEX to have an optional name Simon Riggs <[email protected]>
2022-05-27 19:08 ` Re: Allowing REINDEX to have an optional name Cary Huang <[email protected]>
2022-05-31 08:51 ` Re: Allowing REINDEX to have an optional name Bernd Helmle <[email protected]>
2022-06-28 00:18 ` Re: Allowing REINDEX to have an optional name Justin Pryzby <[email protected]>
2022-05-31 09:04 ` Re: Allowing REINDEX to have an optional name Bernd Helmle <[email protected]>
2022-05-31 12:09 ` Re: Allowing REINDEX to have an optional name Michael Paquier <[email protected]>
2022-05-31 12:30 ` Re: Allowing REINDEX to have an optional name Alvaro Herrera <[email protected]>
2022-06-02 00:02 ` Re: Allowing REINDEX to have an optional name Michael Paquier <[email protected]>
2022-06-28 07:29 ` Re: Allowing REINDEX to have an optional name Simon Riggs <[email protected]>
2022-06-28 10:02 ` Re: Allowing REINDEX to have an optional name Simon Riggs <[email protected]>
2022-06-29 04:35 ` Re: Allowing REINDEX to have an optional name Michael Paquier <[email protected]>
2022-06-29 14:02 ` Re: Allowing REINDEX to have an optional name Simon Riggs <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox