public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 6/6] 0003 review 24+ messages / 3 participants [nested] [flat]
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review @ 2021-02-15 15:36 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw) --- src/test/regress/input/copy.source | 4 ++-- src/test/regress/output/copy.source | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source index ddde33e7cc..4ee1b26326 100644 --- a/src/test/regress/input/copy.source +++ b/src/test/regress/input/copy.source @@ -204,7 +204,7 @@ drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set @@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source index 60f4206aa1..8ebfb7ae81 100644 --- a/src/test/regress/output/copy.source +++ b/src/test/regress/output/copy.source @@ -167,7 +167,7 @@ select * from parted_copytest where b = 2; drop table parted_copytest; -- -- progress reporting --- +-- -- setup -- reuse employer datatype, that has a small sized data set create table progress_reporting ( @@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS $$ declare report record; begin - -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to + -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to -- variance in system process ids, and concurrency in runs of tests. -- Additionally, due to the usage of this test in pg_regress, the 'datid' -- also is not consistent between runs. -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5-- ^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: [DOCS] Stats views and functions not in order? @ 2023-01-11 06:11 Peter Smith <[email protected]> 0 siblings, 1 reply; 24+ messages in thread From: Peter Smith @ 2023-01-11 06:11 UTC (permalink / raw) To: vignesh C <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; David G. Johnston <[email protected]>; Tom Lane <[email protected]>; PostgreSQL Hackers <[email protected]> On Wed, Jan 4, 2023 at 6:08 PM vignesh C <[email protected]> wrote: > > On Mon, 2 Jan 2023 at 13:47, Peter Eisentraut > <[email protected]> wrote: > > > > On 08.12.22 03:30, Peter Smith wrote: > > > PSA patches for v9* > > > > > > v9-0001 - Now the table rows are ordered per PeterE's suggestions [1] > > > > committed Thanks for pushing. > > > > > v9-0002 - All the review comments from DavidJ [2] are addressed > > > > I'm not sure about this one. It removes the "see [link] for details" > > phrases and instead makes the view name a link. I think this loses the > > cue that there is more information elsewhere. Otherwise, one could > > think that, say, the entry about pg_stat_activity is the primary source > > and the link just links to itself. Also keep in mind that people use > > media where links are not that apparent (PDF), so the presence of a link > > by itself cannot be the only cue about the flow of the information. > PSA new patch for v10-0001 v9-0001 --> pushed, thanks! v9-0002 --> I removed this based on the reject reason above v9-0003 --> v10-0001 > I'm not sure if anything is pending for v9-0003, if there is something > pending, please post an updated patch for the same. > Thanks for the reminder. PSA v10. ------ Kind Regards, Peter Smith. Fujitsu Australia Attachments: [application/octet-stream] v10-0001-Add-Statistics-Views-section-and-refentry-for-ea.patch (13.0K, ../../CAHut+PuHs=52Ag5RH2OExm8Qg6sfBkak4OY7onfiqYZ+HJ-iwQ@mail.gmail.com/2-v10-0001-Add-Statistics-Views-section-and-refentry-for-ea.patch) download | inline diff: From 84632b35e65ef803eb32eadfce3d363a13891cb1 Mon Sep 17 00:00:00 2001 From: Peter Smith <[email protected]> Date: Wed, 11 Jan 2023 16:51:56 +1100 Subject: [PATCH v10] Add "Statistics Views" section and refentry for each view. --- doc/src/sgml/monitoring.sgml | 257 ++++++++++++++++++++++++++++++++----------- 1 file changed, 194 insertions(+), 63 deletions(-) diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 358d2ff..c222b53 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -290,6 +290,11 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser linkend="predefined-roles"/>) can see all the information about all sessions. </para> + </sect2> + + <sect2 id="monitoring-stats-views-all"> + <title>Statistics Views</title> + <table id="monitoring-stats-dynamic-views-table"> <title>Dynamic Statistics Views</title> @@ -681,10 +686,14 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser into the kernel's handling of I/O. </para> - </sect2> + <refentry id="monitoring-pg-stat-activity-view"> + <refnamediv> + <refname><structname>pg_stat_activity</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-activity-view"> - <title><structname>pg_stat_activity</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_activity</primary> @@ -2343,10 +2352,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </programlisting> </para> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-replication-view"> + <refnamediv> + <refname><structname>pg_stat_replication</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-replication-view"> - <title><structname>pg_stat_replication</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_replication</primary> @@ -2680,10 +2695,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </para> </note> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-replication-slots-view"> + <refnamediv> + <refname><structname>pg_stat_replication_slots</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-replication-slots-view"> - <title><structname>pg_stat_replication_slots</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_replication_slots</primary> @@ -2829,10 +2850,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-stat-wal-receiver-view"> - <title><structname>pg_stat_wal_receiver</structname></title> + <refentry id="monitoring-pg-stat-wal-receiver-view"> + <refnamediv> + <refname><structname>pg_stat_wal_receiver</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_wal_receiver</primary> @@ -3009,10 +3036,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-stat-recovery-prefetch"> - <title><structname>pg_stat_recovery_prefetch</structname></title> + <refentry id="monitoring-pg-stat-recovery-prefetch"> + <refnamediv> + <refname><structname>pg_stat_recovery_prefetch</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_recovery_prefetch</primary> @@ -3155,10 +3188,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-subscription"> + <refnamediv> + <refname><structname>pg_stat_subscription</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-subscription"> - <title><structname>pg_stat_subscription</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_subscription</primary> @@ -3266,10 +3305,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-subscription-stats"> + <refnamediv> + <refname><structname>pg_stat_subscription_stats</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-subscription-stats"> - <title><structname>pg_stat_subscription_stats</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_subscription_stats</primary> @@ -3344,10 +3389,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-stat-ssl-view"> - <title><structname>pg_stat_ssl</structname></title> + <refentry id="monitoring-pg-stat-ssl-view"> + <refnamediv> + <refname><structname>pg_stat_ssl</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_ssl</primary> @@ -3465,10 +3516,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-gssapi-view"> + <refnamediv> + <refname><structname>pg_stat_gssapi</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-gssapi-view"> - <title><structname>pg_stat_gssapi</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_gssapi</primary> @@ -3540,10 +3597,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-archiver-view"> + <refnamediv> + <refname><structname>pg_stat_archiver</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-archiver-view"> - <title><structname>pg_stat_archiver</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_archiver</primary> @@ -3644,10 +3707,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i archived. </para> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-bgwriter-view"> + <refnamediv> + <refname><structname>pg_stat_bgwriter</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-bgwriter-view"> - <title><structname>pg_stat_bgwriter</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_bgwriter</primary> @@ -3781,10 +3850,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-stat-wal-view"> - <title><structname>pg_stat_wal</structname></title> + <refentry id="monitoring-pg-stat-wal-view"> + <refnamediv> + <refname><structname>pg_stat_wal</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_wal</primary> @@ -3915,10 +3990,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> -</sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-database-view"> + <refnamediv> + <refname><structname>pg_stat_database</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-database-view"> - <title><structname>pg_stat_database</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_database</primary> @@ -4240,10 +4321,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-stat-database-conflicts-view"> - <title><structname>pg_stat_database_conflicts</structname></title> + <refentry id="monitoring-pg-stat-database-conflicts-view"> + <refnamediv> + <refname><structname>pg_stat_database_conflicts</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_database_conflicts</primary> @@ -4343,10 +4430,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-all-tables-view"> + <refnamediv> + <refname><structname>pg_stat_all_tables</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-all-tables-view"> - <title><structname>pg_stat_all_tables</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_all_tables</primary> @@ -4614,10 +4707,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-all-indexes-view"> + <refnamediv> + <refname><structname>pg_stat_all_indexes</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-all-indexes-view"> - <title><structname>pg_stat_all_indexes</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_all_indexes</primary> @@ -4763,10 +4862,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </para> </note> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-statio-all-tables-view"> + <refnamediv> + <refname><structname>pg_statio_all_tables</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-statio-all-tables-view"> - <title><structname>pg_statio_all_tables</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_statio_all_tables</primary> @@ -4899,10 +5004,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-statio-all-indexes-view"> - <title><structname>pg_statio_all_indexes</structname></title> + <refentry id="monitoring-pg-statio-all-indexes-view"> + <refnamediv> + <refname><structname>pg_statio_all_indexes</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>pg_statio_all_indexes</primary> @@ -4999,10 +5110,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-statio-all-sequences-view"> + <refnamediv> + <refname><structname>pg_statio_all_sequences</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-statio-all-sequences-view"> - <title><structname>pg_statio_all_sequences</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_statio_all_sequences</primary> @@ -5077,10 +5194,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> + + <refentry id="monitoring-pg-stat-user-functions-view"> + <refnamediv> + <refname><structname>pg_stat_user_functions</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> - <sect2 id="monitoring-pg-stat-user-functions-view"> - <title><structname>pg_stat_user_functions</structname></title> + <refsect1> + <title>Description</title> <indexterm> <primary>pg_stat_user_functions</primary> @@ -5167,10 +5290,16 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> - </sect2> + </refsect1></refentry> - <sect2 id="monitoring-pg-stat-slru-view"> - <title><structname>pg_stat_slru</structname></title> + <refentry id="monitoring-pg-stat-slru-view"> + <refnamediv> + <refname><structname>pg_stat_slru</structname></refname> + <refpurpose>View</refpurpose> + </refnamediv> + + <refsect1> + <title>Description</title> <indexterm> <primary>SLRU</primary> @@ -5289,6 +5418,8 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i </tgroup> </table> + </refsect1></refentry> + </sect2> <sect2 id="monitoring-stats-functions"> -- 1.8.3.1 ^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: [DOCS] Stats views and functions not in order? @ 2023-01-18 10:36 Peter Eisentraut <[email protected]> parent: Peter Smith <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Peter Eisentraut @ 2023-01-18 10:36 UTC (permalink / raw) To: Peter Smith <[email protected]>; vignesh C <[email protected]>; +Cc: David G. Johnston <[email protected]>; Tom Lane <[email protected]>; PostgreSQL Hackers <[email protected]> On 11.01.23 07:11, Peter Smith wrote: > v9-0003 --> v10-0001 > >> I'm not sure if anything is pending for v9-0003, if there is something >> pending, please post an updated patch for the same. > > Thanks for the reminder. PSA v10. So this patch changes some sections describing system views to refentry's. What is the reason for that? refentry's are basically man pages; do we want man pages for each system view? Maybe (*), but then we should also do the same to all the other system views, all the system catalogs, everything else. Just changing a few in a single place seems odd. (*) -- but also maybe not? ^ permalink raw reply [nested|flat] 24+ messages in thread
end of thread, other threads:[~2023-01-18 10:36 UTC | newest] Thread overview: 24+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]> 2023-01-11 06:11 Re: [DOCS] Stats views and functions not in order? Peter Smith <[email protected]> 2023-01-18 10:36 ` Re: [DOCS] Stats views and functions not in order? Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox