public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 6/6] 0003 review
24+ messages / 3 participants
[nested] [flat]
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: Avoid use deprecated Windows Memory API
@ 2023-03-22 10:01 Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 24+ messages in thread
From: Daniel Gustafsson @ 2023-03-22 10:01 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Ranier Vilela <[email protected]>; Aleksander Alekseev <[email protected]>; pgsql-hackers; Alvaro Herrera <[email protected]>
> On 19 Mar 2023, at 23:41, Michael Paquier <[email protected]> wrote:
>
> On Fri, Mar 17, 2023 at 12:19:56PM -0300, Ranier Vilela wrote:
>> Rebased to latest Head.
>
> I was looking at this thread, and echoing Daniel's and Alvaro's
> arguments, I don't quite see why this patch is something we need. I
> would recommend to mark it as rejected and move on.
Unless the claimed performance improvement is measured and provides a speedup,
and the loss of zeroing memory is guaranteed safe, there doesn't seem to be
much value provided.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: Avoid use deprecated Windows Memory API
@ 2023-03-22 12:18 Ranier Vilela <[email protected]>
parent: Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 24+ messages in thread
From: Ranier Vilela @ 2023-03-22 12:18 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: Michael Paquier <[email protected]>; Aleksander Alekseev <[email protected]>; pgsql-hackers; Alvaro Herrera <[email protected]>
Em qua., 22 de mar. de 2023 às 07:01, Daniel Gustafsson <[email protected]>
escreveu:
> > On 19 Mar 2023, at 23:41, Michael Paquier <[email protected]> wrote:
> >
> > On Fri, Mar 17, 2023 at 12:19:56PM -0300, Ranier Vilela wrote:
> >> Rebased to latest Head.
> >
> > I was looking at this thread, and echoing Daniel's and Alvaro's
> > arguments, I don't quite see why this patch is something we need. I
> > would recommend to mark it as rejected and move on.
>
> Unless the claimed performance improvement is measured and provides a
> speedup,
> and the loss of zeroing memory is guaranteed safe, there doesn't seem to be
> much value provided.
>
At no time was it suggested that there would be performance gains.
The patch proposes to adjust the API that the manufacturer asks you to use.
However, I see no point in discussing a defunct patch.
regards,
Ranier Vilela
^ permalink raw reply [nested|flat] 24+ messages in thread
end of thread, other threads:[~2023-03-22 12:18 UTC | newest]
Thread overview: 24+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2023-03-22 10:01 Re: Avoid use deprecated Windows Memory API Daniel Gustafsson <[email protected]>
2023-03-22 12:18 ` Re: Avoid use deprecated Windows Memory API Ranier Vilela <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox