agora inbox for [email protected]  

help / color / mirror / Atom feed

[PATCH v9 3/7] Row pattern recognition patch (planner).
265+ messages / 2 participants
[nested] [flat]

* [PATCH v9 3/7] Row pattern recognition patch (planner).
@ 2023-10-04 05:51 Tatsuo Ishii <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Tatsuo Ishii @ 2023-10-04 05:51 UTC (permalink / raw)

---
 src/backend/optimizer/plan/createplan.c | 23 ++++++++++++++++++-----
 src/backend/optimizer/plan/setrefs.c    | 23 +++++++++++++++++++++++
 src/include/nodes/plannodes.h           | 15 +++++++++++++++
 3 files changed, 56 insertions(+), 5 deletions(-)

diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
index 34ca6d4ac2..469fcd156b 100644
--- a/src/backend/optimizer/plan/createplan.c
+++ b/src/backend/optimizer/plan/createplan.c
@@ -286,9 +286,10 @@ static WindowAgg *make_windowagg(List *tlist, Index winref,
 								 int ordNumCols, AttrNumber *ordColIdx, Oid *ordOperators, Oid *ordCollations,
 								 int frameOptions, Node *startOffset, Node *endOffset,
 								 Oid startInRangeFunc, Oid endInRangeFunc,
-								 Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst,
-								 List *runCondition, List *qual, bool topWindow,
-								 Plan *lefttree);
+								 Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, List *runCondition,
+								 RPSkipTo rpSkipTo, List *patternVariable, List *patternRegexp, List *defineClause,
+								 List *defineInitial,
+								 List *qual, bool topWindow, Plan *lefttree);
 static Group *make_group(List *tlist, List *qual, int numGroupCols,
 						 AttrNumber *grpColIdx, Oid *grpOperators, Oid *grpCollations,
 						 Plan *lefttree);
@@ -2698,6 +2699,11 @@ create_windowagg_plan(PlannerInfo *root, WindowAggPath *best_path)
 						  wc->inRangeAsc,
 						  wc->inRangeNullsFirst,
 						  wc->runCondition,
+						  wc->rpSkipTo,
+						  wc->patternVariable,
+						  wc->patternRegexp,
+						  wc->defineClause,
+						  wc->defineInitial,
 						  best_path->qual,
 						  best_path->topwindow,
 						  subplan);
@@ -6601,8 +6607,10 @@ make_windowagg(List *tlist, Index winref,
 			   int ordNumCols, AttrNumber *ordColIdx, Oid *ordOperators, Oid *ordCollations,
 			   int frameOptions, Node *startOffset, Node *endOffset,
 			   Oid startInRangeFunc, Oid endInRangeFunc,
-			   Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst,
-			   List *runCondition, List *qual, bool topWindow, Plan *lefttree)
+			   Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, List *runCondition,
+			   RPSkipTo rpSkipTo, List *patternVariable, List *patternRegexp, List *defineClause,
+			   List *defineInitial,
+			   List *qual, bool topWindow, Plan *lefttree)
 {
 	WindowAgg  *node = makeNode(WindowAgg);
 	Plan	   *plan = &node->plan;
@@ -6628,6 +6636,11 @@ make_windowagg(List *tlist, Index winref,
 	node->inRangeAsc = inRangeAsc;
 	node->inRangeNullsFirst = inRangeNullsFirst;
 	node->topWindow = topWindow;
+	node->rpSkipTo = rpSkipTo,
+	node->patternVariable = patternVariable;
+	node->patternRegexp = patternRegexp;
+	node->defineClause = defineClause;
+	node->defineInitial = defineInitial;
 
 	plan->targetlist = tlist;
 	plan->lefttree = lefttree;
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c
index 7962200885..20ce399763 100644
--- a/src/backend/optimizer/plan/setrefs.c
+++ b/src/backend/optimizer/plan/setrefs.c
@@ -2456,6 +2456,29 @@ set_upper_references(PlannerInfo *root, Plan *plan, int rtoffset)
 					   NRM_EQUAL,
 					   NUM_EXEC_QUAL(plan));
 
+	/*
+	 *	Modifies an expression tree in each DEFINE clause so that all Var
+	 *	nodes reference outputs of a subplan.
+	 */
+	if (IsA(plan, WindowAgg))
+	{
+		WindowAgg  *wplan = (WindowAgg *) plan;
+
+		foreach(l, wplan->defineClause)
+		{
+			TargetEntry *tle = (TargetEntry *) lfirst(l);
+
+			tle->expr = (Expr *)
+				fix_upper_expr(root,
+							   (Node *) tle->expr,
+							   subplan_itlist,
+							   OUTER_VAR,
+							   rtoffset,
+							   NRM_EQUAL,
+							   NUM_EXEC_QUAL(plan));
+		}
+	}
+
 	pfree(subplan_itlist);
 }
 
diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h
index 8cafbf3f8a..e48b59517d 100644
--- a/src/include/nodes/plannodes.h
+++ b/src/include/nodes/plannodes.h
@@ -1096,6 +1096,21 @@ typedef struct WindowAgg
 	/* nulls sort first for in_range tests? */
 	bool		inRangeNullsFirst;
 
+	/* Row Pattern Recognition AFTER MACH SKIP clause */
+	RPSkipTo	rpSkipTo;		/* Row Pattern Skip To type */
+
+	/* Row Pattern PATTERN variable name (list of String) */
+	List		*patternVariable;
+
+	/* Row Pattern RPATTERN regular expression quantifier ('+' or ''. list of String) */
+	List		*patternRegexp;
+
+	/* Row Pattern DEFINE clause (list of TargetEntry) */
+	List	   *defineClause;
+
+	/* Row Pattern DEFINE variable initial names (list of String) */
+	List		*defineInitial;
+
 	/*
 	 * false for all apart from the WindowAgg that's closest to the root of
 	 * the plan
-- 
2.25.1


----Next_Part(Wed_Oct__4_15_03_28_2023_821)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="v9-0004-Row-pattern-recognition-patch-executor.patch"



^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--






^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread

* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 265+ messages in thread

From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)

---
 src/backend/utils/error/elog.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
 check_log_min_messages(char **newval, void **extra, GucSource source)
 {
 	char	   *rawstring;
+	int			rawstring_len;
 	List	   *elemlist;
 	StringInfoData buf;
 	char	   *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		guc_free(rawstring);
 		return false;
 	}
+	rawstring_len = strlen(rawstring);
+	guc_free(rawstring);
 
 	/* Validate and assign log level and process type. */
 	foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		continue;
 
 lmm_fail:
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2489,7 +2491,6 @@ lmm_fail:
 	if (defaultlevel == -1)
 	{
 		GUC_check_errdetail("Default log level was not defined.");
-		guc_free(rawstring);
 		list_free(elemlist);
 		return false;
 	}
@@ -2507,7 +2508,7 @@ lmm_fail:
 	 */
 	list_sort(elemlist, log_min_messages_cmp);
 
-	initStringInfoExt(&buf, strlen(rawstring) + 1);
+	initStringInfoExt(&buf, rawstring_len + 1);
 	foreach_ptr(char, elem, elemlist)
 	{
 		if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
 		else
 			appendStringInfo(&buf, ", %s", elem);
 	}
+	list_free(elemlist);
 
 	result = guc_strdup(LOG, buf.data);
 	if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
 	guc_free(*newval);
 	*newval = result;
 
-	guc_free(rawstring);
-	list_free(elemlist);
 	pfree(buf.data);
 
 	/*
-- 
2.47.3


--dnohjpfxulhc3bo3--





^ permalink  raw  reply  [nested|flat] 265+ messages in thread