public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andres Freund <[email protected]>
To: Andrew Dunstan <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Japin Li <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_get__*_ddl consolidation
Date: Sun, 5 Apr 2026 16:03:49 -0400
Message-ID: <ocjzhjrnhagzimxo3jz42e3liybwed5nijnw7uadm5yyjurlux@kt3q6szjapre> (raw)
In-Reply-To: <ptyiexyhmtxf4lm524s7o7w64r26ra237uusv4tjav4yhpmeoo@vfwwllz7tivb>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
<[email protected]>
<SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
<CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
<[email protected]>
<[email protected]>
<ptyiexyhmtxf4lm524s7o7w64r26ra237uusv4tjav4yhpmeoo@vfwwllz7tivb>
Hi,
On 2026-04-05 11:40:33 -0400, Andres Freund wrote:
> On 2026-04-05 11:06:09 -0400, Andrew Dunstan wrote:
> > Pushed. I have moved the remaining get_*_ddl items to PG20-1
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin&dt=2026-04-05%2015%3A04%3A04
>
> diff -U3 /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/expected/database_ddl.out /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/results/database_ddl.out
> --- /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/expected/database_ddl.out 2026-04-05 11:04:08
> +++ /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/results/database_ddl.out 2026-04-05 11:05:57
> @@ -22,6 +22,7 @@
> CREATE DATABASE regress_database_ddl
> ENCODING utf8 LC_COLLATE "C" LC_CTYPE "C" TEMPLATE template0
> OWNER regress_datdba;
> +WARNING: databases created by regression test cases should have names including "regression"
> ALTER DATABASE regress_database_ddl CONNECTION_LIMIT 123;
> ALTER DATABASE regress_database_ddl SET random_page_cost = 2.0;
> ALTER ROLE regress_datdba IN DATABASE regress_database_ddl SET random_page_cost = 1.1;
Pushed a fixup for this and the pgindent failure, as it doesn't seem like a
great time to have CI/BF fail.
It is pretty odd that the naming restrictions for databases (regression*) is
different than for all the other object types...
> But do we really have to create a new database and a new tablespace for these?
> Database and tablespace creations are quite heavyweight operations.
>
> We already have an existing tablespace and an existing database as part of the
> regression tests. Couldn't you make do with those?
Didn't do anything about that.
Greetings,
Andres Freund
view thread (31+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_get__*_ddl consolidation
In-Reply-To: <ocjzhjrnhagzimxo3jz42e3liybwed5nijnw7uadm5yyjurlux@kt3q6szjapre>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox