public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andres Freund <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: some more include removal from headers
Date: Thu, 2 Apr 2026 12:27:12 -0400
Message-ID: <olxypm44m2bqzicr7biie37swt7c5uevpq3sbf7pzcykd2mirw@nw5pydkpjgeg> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Hi,
On 2026-04-02 12:52:13 +0200, Álvaro Herrera wrote:
> Here's low-hanging fruit I noticed while eyeballing a patch in the
> commitfest. This removes pg_publication.h from utils/rel.h, which is
> really nice because pg_publication includes objectaddress.h which in
> turn includes parsenodes.h (an absolute disaster we have there, harder
> to cleanup; not in the mood). But this here is nice and well contained.
These days including rel.h (indirectly) including objectaddress.h is
quite the disaster, because objectaddress.h recently grew an include of
syscache.h, as I complain about in [1].
I got pretty annoyed this cycle with how much rebuilding a simple change to
bufmgr.h triggers (due to hacking on it a lot). I started to write a series
to improve that, but didn't get around to posting that yet due to encountering
the issue 771fe0948ca fixed while improving the situation.
During that I encountered the objectaddress.h include, as part of which I then
complained about the issue in [1].
After the attached patches, a change to bufmgr.h triggers rebuilding 213
files, before it was 323. Not perfect, but better.
Would be nice to get rid of the bufmgr.h includes in access/nbtree.h and such,
but it looks like that'd be a bit more work.
I included your catalog/publication.h in it, as my version had surprisingly
extensive bitrot...
Greetings,
Andres Freund
[1] https://postgr.es/m/vlcexdcimsmvu3aplt2yxpfndkgtuvjsrms2fdl46rbw3k2kug%40drspkoxlaije
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: some more include removal from headers
In-Reply-To: <olxypm44m2bqzicr7biie37swt7c5uevpq3sbf7pzcykd2mirw@nw5pydkpjgeg>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox