From: Ulrich Neumann <U_Neumann@gne.de>
To: lockhart@fourpalms.org
Cc: pgsql-hackers@postgresql.org
Subject: Antw: Re: GETTIMEOFDAY_1ARG change
Date: Tue, 08 Jan 2002 19:46:36 +0100
Message-ID: <sc3b4cb0.044@mail.gne.de> (raw)
Hi Thomas,
i m working on postgres for 2 new platforms, NetWare 6 and a future
64 bit OS that is under development.
On NetWare timezone is defined as a global variable, seconds from GMT.
But wait, gettimeofday will be added to NetWare so there isn t any
change neccessary anymore.
On the other hand the struct isn t used in the mentioned functions,
so for
"correctness" it could be added.
Thanks for your answers
Ulrich Neumann
Ulrich Neumann
_______________________________________________________
_ _
| _ |\ | |_ GNE GmbH - Brechhoferstr. 1 - 56316 Raubach
|_| | \| |_ http://www.gne.de, Tel.: +49 2684-9454-0, Fax -94,
David: -71
GNE Hostmaster (hostmaster@gne.de)
CNA3, CNA4, CNA5, CNE3, CNE4, CNE5, Pending MCNE
Offizieller Novell SysOp für das Novell DeveloperNet
>>> Thomas Lockhart <lockhart@fourpalms.org> 08.01.2002 16:00:11 >>>
> i would like to add the following changes to the code so that
postgres
> doesn t have any problems if we compile it on machines that have
> gettimeofday with 1 ARG and therefore don t need 'struct timezone
xxx'
> I m working on a System where timezone is defined in another way.
What system? How is timezone defined for that system? Is it something
completely new and different, or a variant which we already handle in
other places but not for this case?
...
> 2.postgres.c
> ResetUsage(void)
> {
> #ifndef GETTIMEOFDAY_1ARG
> struct timezone tz;
> #endif
>
> getrusage(RUSAGE_SELF, &Save_r);
> gettimeofday(&Save_t, &tz);
...
So what "one argument" does gettimeofday() have? Where does "tz" come
from if it is not defined here? Does it become a global variable?
Where
is it declared?
afaik the nabstime.c usage of gettimeofday() has been in the
PostgreSQL
code for quite a while, so I'm suprised that this is a problem on the
new mystery platform ;)
- Thomas
-------------------------------------------
This mail is virus scanned
Diese mail ist virusgeprueft
CVP Server Solutions by GNE
visit us at www.gne.de
-------------------------------------------
BEGIN:VCARD
VERSION:2.1
X-GWTYPE:USER
FN:Ulrich Neumann
TEL;WORK:02684-9454-30
ORG:;Technik
TEL;PREF;FAX:02684-945494
EMAIL;WORK;PREF;NGW:U_Neumann@gne.de
N:Neumann;Ulrich
TITLE:Geschäftsführer
END:VCARD
Attachments:
[text/plain] Ulrich Neumann.vcf (203B, ../sc3b4cb0.044@mail.gne.de/2-Ulrich%20Neumann.vcf)
download | inline:
BEGIN:VCARD
VERSION:2.1
X-GWTYPE:USER
FN:Ulrich Neumann
TEL;WORK:02684-9454-30
ORG:;Technik
TEL;PREF;FAX:02684-945494
EMAIL;WORK;PREF;NGW:U_Neumann@gne.de
N:Neumann;Ulrich
TITLE:Geschäftsführer
END:VCARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: U_Neumann@gne.de, lockhart@fourpalms.org
Subject: Re: Antw: Re: GETTIMEOFDAY_1ARG change
In-Reply-To: <sc3b4cb0.044@mail.gne.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox