pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: 盏一 <w@hidva.com>
To: andres freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()`
Date: Sat, 12 Jun 2021 12:52:13 +0800
Message-ID: <tencent_266A74223032496338317CC7@qq.com> (raw)

Ok! Thanks
----------




--------------原始邮件--------------
发件人:"Andres Freund "<andres@anarazel.de>;
发送时间:2021年6月12日(星期六) 中午12:43
收件人:"盏一" <w@hidva.com>;
抄送:"pgsql-hackers "<pgsql-hackers@postgresql.org>;
主题:Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()`
-----------------------------------

 Hi,

On 2021-05-07 04:36:25 +0800, 盏一 wrote:
> &gt;&nbsp;Sounds like a plan! Do you want to write a patch?
> Add the patch.

Thanks for the patch. I finally pushed an edited version of it. There
were other loops over ->pgprocnos, so I put assertions in those - that
gains us a a good bit more checking than we had before...

I also couldn't resist to do some small formatting cleanups - I found
the memmove calls just too hard to read.

I took the authorship information as you had it in the diff you attached
- I hope that's OK?

Greetings,

Andres Freund

view thread (8+ messages)

Message-ID: <tencent_266A74223032496338317CC7@qq.com>
Permalink:  ../tencent_266A74223032496338317CC7@qq.com/
Also on:    postgresql.org/message-id/tencent_266A74223032496338317CC7@qq.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: w@hidva.com, andres@anarazel.de
  Subject: Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()`
  In-Reply-To: <tencent_266A74223032496338317CC7@qq.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox