From: zengman <zengman@halodbtech.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter@eisentraut.org>
Subject: Re: (SQL/PGQ) Clean up orphaned properties when dropping a label
Date: Fri, 12 Jun 2026 09:36:28 +0800
Message-ID: <tencent_645E2A4E416C0065571467F5@qq.com> (raw)
In-Reply-To: <CAExHW5scCjsrkDz4cfVaxyGRFJsgeeuwxFrqfvuVYbE0Pq2tcA@mail.gmail.com>
References: <tencent_76F6ACA2364EAA1E5DBD7A47@qq.com>
<CAExHW5scCjsrkDz4cfVaxyGRFJsgeeuwxFrqfvuVYbE0Pq2tcA@mail.gmail.com>
> Thanks for the report and the patch. The fix is on the right track. I
> changed a few things as follows
> a. we usually add operands to the same operator at the end, not at the
> beginning.
> b. create_property_graph.sql, which tests all property graph DDLs, is
> the right place to add these tests. graph_table.sql tests graph query.
>
> I have used an existing property graph in create_property_graph.sql in
> the test. It removes a label from the property graph which has two
> properties associated with it, one that gets orphaned and one that
> doesn't. We can verify that the orphaned property gets dropped from
> the property graph but not the other one by information schema query
> outputs later. So didn't add any separate verification step after the
> DDL.
> Attached patch with those changes.
Hi Ashutosh,
Thank you for your assistance. This looks better. There is a small problem that
https://commitfest.postgresql.org/patch/6848/
It seems that a 'rebase' is needed to conduct the test normally. Could you please make some adjustments again?
--
regards,
Man Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: zengman@halodbtech.com, ashutosh.bapat.oss@gmail.com, pgsql-hackers@lists.postgresql.org, peter@eisentraut.org
Subject: Re: (SQL/PGQ) Clean up orphaned properties when dropping a label
In-Reply-To: <tencent_645E2A4E416C0065571467F5@qq.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox