public inbox for [email protected]  

help / color / mirror / Atom feed

From: =?utf-8?B?bGl1amlueWFuZw==?= <[email protected]>
To: =?utf-8?B?cGdzcWwtaGFja2Vycw==?= <[email protected]>
Subject: remove the unneeded header file math.h in binaryheap.c
Date: Tue, 13 Jan 2026 17:21:30 +0800
Message-ID: <[email protected]> (raw)

Hi Hackers,




I found in file binaryheap.c， file "math.h" was included, but it is uncessary, so I removed it&nbsp;

and filing a patch to address the issue.




I have verified that, build is OK.




Please see the attachment and help review it.




thanks a lot!




liujinyang

Attachments:

  [application/octet-stream] v1-0001-remove-the-unneeded-header-file-math.h-in-binaryh.patch (679B, ../[email protected]/3-v1-0001-remove-the-unneeded-header-file-math.h-in-binaryh.patch)
  download | inline diff:
From 8e2bc152ebef4a189a41508b6c3a65f5956695ef Mon Sep 17 00:00:00 2001
From: liujinyang <[email protected]>
Date: Tue, 13 Jan 2026 13:34:37 +0800
Subject: [PATCH v1] remove the unneeded header file math.h in binaryheap.c

math.h was inlcuded in binaryheap.c, it is unnecessary, so remove it.

Author: liujinyang <[email protected]>
---
 src/common/binaryheap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/common/binaryheap.c b/src/common/binaryheap.c
index d2be882..df620c1 100644
--- a/src/common/binaryheap.c
+++ b/src/common/binaryheap.c
@@ -17,7 +17,6 @@
 #include "postgres.h"
 #endif
 
-#include <math.h>
 
 #ifdef FRONTEND
 #include "common/logging.h"
-- 
1.8.3.1

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: remove the unneeded header file math.h in binaryheap.c
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox