public inbox for [email protected]  

help / color / mirror / Atom feed

From: Álvaro Herrera <[email protected]>
To: liujinyang <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: remove the unneeded header file math.h in binaryheap.c
Date: Tue, 13 Jan 2026 18:18:19 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2026-Jan-13, liujinyang wrote:

> Hi Hackers,
> 
> I found in file binaryheap.c， file "math.h" was included, but it is uncessary, so I removed it&nbsp;
> and filing a patch to address the issue.

Fun.  This was already unnecessary at commit 7a2fe9bd0371 which
introduced the file.  It seems Abhijit had that include in his first
version [1] because he was using floor().   Robert rewrote it later [2]
and replaced that with straight arithmetic, making the include
unnecessary, but forgot to remove it.

[1] https://postgr.es/m/[email protected] 
[2] https://postgr.es/m/CA%2BTgmobvR7XW9fjj2RNY7sKK-VAG5nahfai_zV51rHVLDNvaBg%40mail.gmail.com

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: remove the unneeded header file math.h in binaryheap.c
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox