public inbox for [email protected]help / color / mirror / Atom feed
[PATCH] Disable background workers during servers start in pg_upgrade 2+ messages / 2 participants [nested] [flat]
* [PATCH] Disable background workers during servers start in pg_upgrade @ 2021-01-20 16:25 Denis Laxalde <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Denis Laxalde @ 2021-01-20 16:25 UTC (permalink / raw) We disable shared_preload_libraries to prevent background workers to initialize and start during server start in pg_upgrade. In essence, this is for a similar reason that we use a restricted socket access from f763b77193b04eba03a1f4ce46df34dc0348419e because background workers may produce undesired activities during the upgrade. Author: Denis Laxalde <[email protected]> Co-authored-by: Jehan-Guillaume de Rorthais <[email protected]> --- src/bin/pg_upgrade/server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bin/pg_upgrade/server.c b/src/bin/pg_upgrade/server.c index 31b1425202..fab95a2d24 100644 --- a/src/bin/pg_upgrade/server.c +++ b/src/bin/pg_upgrade/server.c @@ -240,11 +240,13 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error) * crash, the new cluster has to be recreated anyway. fsync=off is a big * win on ext4. * + * Turn off background workers by emptying shared_preload_libraries. + * * Force vacuum_defer_cleanup_age to 0 on the new cluster, so that * vacuumdb --freeze actually freezes the tuples. */ snprintf(cmd, sizeof(cmd), - "\"%s/pg_ctl\" -w -l \"%s\" -D \"%s\" -o \"-p %d%s%s %s%s\" start", + "\"%s/pg_ctl\" -w -l \"%s\" -D \"%s\" -o \"-p %d%s%s %s%s -c shared_preload_libraries=''\" start", cluster->bindir, SERVER_LOG_FILE, cluster->pgconfig, cluster->port, (cluster->controldata.cat_ver >= BINARY_UPGRADE_SERVER_FLAG_CAT_VER) ? " -b" : -- 2.20.1 --lvvxlk2k67d5kdun-- ^ permalink raw reply [nested|flat] 2+ messages in thread
* Fix wrong log in pgstat_report_checksum_failures_in_db() @ 2026-02-11 09:22 wangpeng <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: wangpeng @ 2026-02-11 09:22 UTC (permalink / raw) To: [email protected] Hi hackers, The function pgstat_report_checksum_failures_in_db(), file pgstat_database.c, currently emits a log message referring to "conflicts", which seems wrong. As the function name suggesting, the log message should refer to "checksum failures". Best regards, Wang Peng From baaa034639ecd4bb08edd7563a9ee4016fad765b Mon Sep 17 00:00:00 2001 From: Wang Peng <[email protected]> Date: Tue, 10 Feb 2026 22:16:24 -0500 Subject: [PATCH v1] Fix wrong log in pgstat_report_checksum_failures_in_db() Author: Wang Peng <[email protected]> --- src/backend/utils/activity/pgstat_database.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/utils/activity/pgstat_database.c b/src/backend/utils/activity/pgstat_database.c index 6309909..0ccb170 100644 --- a/src/backend/utils/activity/pgstat_database.c +++ b/src/backend/utils/activity/pgstat_database.c @@ -200,7 +200,7 @@ pgstat_report_checksum_failures_in_db(Oid dboid, int failurecount) Assert(entry_ref); if (!entry_ref) { - elog(WARNING, "could not report %d conflicts for DB %u", + elog(WARNING, "could not report %d checksum failures for DB %u", failurecount, dboid); return; } -- 1.8.3.1 Attachments: [text/plain] v1-0001-Fix-wrong-log-in-pgstat_report_checksum_failures.patch (914B, ../../[email protected]/2-v1-0001-Fix-wrong-log-in-pgstat_report_checksum_failures.patch) download | inline diff: From baaa034639ecd4bb08edd7563a9ee4016fad765b Mon Sep 17 00:00:00 2001 From: Wang Peng <[email protected]> Date: Tue, 10 Feb 2026 22:16:24 -0500 Subject: [PATCH v1] Fix wrong log in pgstat_report_checksum_failures_in_db() Author: Wang Peng <[email protected]> --- src/backend/utils/activity/pgstat_database.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/utils/activity/pgstat_database.c b/src/backend/utils/activity/pgstat_database.c index 6309909..0ccb170 100644 --- a/src/backend/utils/activity/pgstat_database.c +++ b/src/backend/utils/activity/pgstat_database.c @@ -200,7 +200,7 @@ pgstat_report_checksum_failures_in_db(Oid dboid, int failurecount) Assert(entry_ref); if (!entry_ref) { - elog(WARNING, "could not report %d conflicts for DB %u", + elog(WARNING, "could not report %d checksum failures for DB %u", failurecount, dboid); return; } -- 1.8.3.1 ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-02-11 09:22 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-20 16:25 [PATCH] Disable background workers during servers start in pg_upgrade Denis Laxalde <[email protected]> 2026-02-11 09:22 Fix wrong log in pgstat_report_checksum_failures_in_db() wangpeng <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox