public inbox for [email protected]
help / color / mirror / Atom feed[PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment
2+ messages / 2 participants
[nested] [flat]
* [PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment
@ 2026-02-26 03:01 =?utf-8?B?em91cmVubGk=?= <[email protected]>
2026-03-16 07:00 ` Re: [PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment Michael Paquier <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: =?utf-8?B?em91cmVubGk=?= @ 2026-02-26 03:01 UTC (permalink / raw)
To: =?utf-8?B?cGdzcWwtaGFja2Vycw==?= <[email protected]>
Hi all,
This is a trivial fix for the comment of getBackendKeyData() function in fe-protocol3.c.
The comment incorrectly stated that the BackendKeyData message type is 'v', when in fact it is 'K' as defined in protocol.h. This fix corrects the comment to match the actual message type used in the protocol.
No functional changes are involved.
Patch is attached below.
Thanks,
zourenli
<[email protected]>
Attachments:
[application/octet-stream] v1-0001-fix-incorrect-message-type-in-getBackendKeyData-comment.patch (1.2K, 3-v1-0001-fix-incorrect-message-type-in-getBackendKeyData-comment.patch)
download | inline diff:
From 301c54c5345b2931b3cd4742bce179d798ca1a8a Mon Sep 17 00:00:00 2001
From: zourenli <[email protected]>
Date: Thu, 26 Feb 2026 10:54:23 +0800
Subject: [PATCH] libpq: Fix incorrect message type in getBackendKeyData()
comment
The getBackendKeyData function comment incorrectly stated that the
BackendKeyData message type is 'v', when in fact it is 'K' as defined
in protocol.h. This fix corrects the comment to match the actual
message type used in the protocol.
---
src/interfaces/libpq/fe-protocol3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c
index 8c1fda5caf0..66397bde555 100644
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interfaces/libpq/fe-protocol3.c
@@ -1612,9 +1612,9 @@ getParameterStatus(PGconn *conn)
/*
* parseInput subroutine to read a BackendKeyData message.
- * Entry: 'v' message type and length have already been consumed.
+ * Entry: 'K' message type and length have already been consumed.
* Exit: returns 0 if successfully consumed message.
- * returns EOF if not enough data.
+ * returns EOF if not enough data.
*/
static int
getBackendKeyData(PGconn *conn, int msgLength)
--
2.32.0
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment
2026-02-26 03:01 [PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment =?utf-8?B?em91cmVubGk=?= <[email protected]>
@ 2026-03-16 07:00 ` Michael Paquier <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2026-03-16 07:00 UTC (permalink / raw)
To: zourenli <[email protected]>; +Cc: pgsql-hackers <[email protected]>
On Thu, Feb 26, 2026 at 11:01:29AM +0800, zourenli wrote:
> This is a trivial fix for the comment of getBackendKeyData() function in fe-protocol3.c.
> The comment incorrectly stated that the BackendKeyData message type
> is 'v', when in fact it is 'K' as defined in protocol.h. This fix
> corrects the comment to match the actual message type used in the
> protocol.
As in PqMsg_BackendKeyData, good catch. Grabbed this one.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-03-16 07:00 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-26 03:01 [PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment =?utf-8?B?em91cmVubGk=?= <[email protected]>
2026-03-16 07:00 ` Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox