pg.ddx.io pgsql-interfaces@postgresql.org mailing list archivehelp / color / mirror / Atom feed
Re: [BUGS] WIN32 MULTIBYTE 4+ messages / 3 participants [nested] [flat]
* Re: [BUGS] WIN32 MULTIBYTE @ 2001-07-23 17:47 Darko Prenosil <Darko.Prenosil@finteh.hr> 2001-07-31 01:56 ` Re: Re: [BUGS] WIN32 MULTIBYTE Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 4+ messages in thread From: Darko Prenosil @ 2001-07-23 17:47 UTC (permalink / raw) To: pgsql-interfaces; Tom Lane <tgl@sss.pgh.pa.us> > "Darko Prenosil" <darko_prenosil@yahoo.com> writes: > > In src/include/miscadmin.h there is declared external function GetUserName. > > > I think that this header should not be imported in libpq at all, > > It isn't --- at least I can't see any inclusion path for it in current > sources. > > regards, tom lane Maybe You can not see it in build for Linux (I did not check), but in WIN32.MAK file there is section that looks like this: !IFDEF MULTIBYTE "$(INTDIR)\common.obj" : ..\..\backend\utils\mb\common.c $(CPP) @<< $(CPP_PROJ) /I "." ..\..\backend\utils\mb\common.c << And there are first few lines from common.c : /* * This file contains some public functions * usable for both the backend and the frontend. * Tatsuo Ishii * $Id: common.c,v 1.13 2001/04/16 02:42:01 tgl Exp $ */ #include "postgres.h" #ifdef WIN32 #include "win32.h" #else #include <unistd.h> #endif #include "miscadmin.h" #include "mb/pg_wchar.h" #include "utils/builtins.h" ...etc... When I try to compile without correction I mentioned in previous message I got this error: ..\..\include\miscadmin.h(206) : error C2373: 'GetUserNameA' : redefinition; different type modifiers ! I'm shore that this header is imported, but I do not know if it can be skipped in this way: /* * This file contains some public functions * usable for both the backend and the frontend. * Tatsuo Ishii * $Id: common.c,v 1.13 2001/04/16 02:42:01 tgl Exp $ */ #include "postgres.h" #ifdef WIN32 #include "win32.h" #else #include <unistd.h> #include "miscadmin.h" #endif #include "mb/pg_wchar.h" #include "utils/builtins.h" ...etc... I supose that this should not impact some other builds? Is this part of code used by ODBC driver for example, and this change can corrupt this build ? I'm quite new in this, so I do not know those answers. Darko.Prenosil@finteh.hr ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Re: [BUGS] WIN32 MULTIBYTE 2001-07-23 17:47 Re: [BUGS] WIN32 MULTIBYTE Darko Prenosil <Darko.Prenosil@finteh.hr> @ 2001-07-31 01:56 ` Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2001-07-31 01:56 UTC (permalink / raw) To: Darko Prenosil <Darko.Prenosil@finteh.hr>; +Cc: pgsql-interfaces "Darko Prenosil" <Darko.Prenosil@finteh.hr> writes: > I think that this header should not be imported in libpq at all, >> >> It isn't --- at least I can't see any inclusion path for it in current >> sources. >> >> regards, tom lane > Maybe You can not see it in build for Linux (I did not check), > but in WIN32.MAK file there is section > that looks like this: > !IFDEF MULTIBYTE > "$(INTDIR)\common.obj" : ..\..\backend\utils\mb\common.c > $(CPP) @<< > $(CPP_PROJ) /I "." ..\..\backend\utils\mb\common.c Hmm. That seems to be rather substantially out of date: in the regular Unix build, the only file added for MULTIBYTE support is utils/mb/wchar.c, and it doesn't include any backend-only include files. We used to import those other backend source files, but that was long ago. Please try ripping all the stuff about common.c, conv.c, and big5.c out of win32.mak, and see if it works then. regards, tom lane ^ permalink raw reply [nested|flat] 4+ messages in thread
* WIN32 MULTIBYTE @ 2001-07-25 14:59 Darko Prenosil <Darko.Prenosil@finteh.hr> 2001-07-26 21:22 ` Re: WIN32 MULTIBYTE Bruce Momjian <pgman@candle.pha.pa.us> 0 siblings, 1 reply; 4+ messages in thread From: Darko Prenosil @ 2001-07-25 14:59 UTC (permalink / raw) To: pgsql-interfaces; Bruce Momjian <pgman@candle.pha.pa.us> Hi, Bruce ! I have recompiled the server with MULTUBYTE, and tested the client library. It seem to work OK. I posted message to [INTERFACES], with suggestion how to change "backend\utils\mb\common.c" , and asked if anyone knows my suggestion can corrupt any other build (as I said, I'm not that familiar with all source code to know). Nobody answered ! Does it means nobody have nothing against ? In that case I suppose that I can send diff-s for new patch ? I do not like idea to send the patch, and then realize that it make some problems to other builds. I Also have question that You probably know the answer. Where can I found documentation with detailed description of QUERY PLAN and QUERY DUMP returned with "EXPLAIN VERBOSE something..." ? I'm writing set of Postgres database components for DELPHI, and it seem to me that result of this command can give me some answers on QUERY before query is actually executed. If I could only parse the result ! Darko.Prenosil@finteh.hr ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: WIN32 MULTIBYTE 2001-07-25 14:59 WIN32 MULTIBYTE Darko Prenosil <Darko.Prenosil@finteh.hr> @ 2001-07-26 21:22 ` Bruce Momjian <pgman@candle.pha.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Bruce Momjian @ 2001-07-26 21:22 UTC (permalink / raw) To: Darko Prenosil <Darko.Prenosil@finteh.hr>; +Cc: pgsql-interfaces > Hi, Bruce ! > > I have recompiled the server with MULTUBYTE, and tested the client library. > It seem to work OK. > I posted message to [INTERFACES], with suggestion how to change "backend\utils\mb\common.c" , > and asked if anyone knows my suggestion can corrupt any other build (as I said, I'm not that familiar with > all source code to know). > Nobody answered ! > Does it means nobody have nothing against ? > In that case I suppose that I can send diff-s for new patch ? > I do not like idea to send the patch, and then realize that it make some problems to other builds. Sure, send the patch to the patches list. > > I Also have question that You probably know the answer. > Where can I found documentation with detailed description of QUERY PLAN and > QUERY DUMP returned with "EXPLAIN VERBOSE something..." ? > I'm writing set of Postgres database components for DELPHI, and it seem to me that result of this > command can give me some answers on QUERY before query is actually > executed. If I could only parse the result ! See documentation. It is in there. Not sure where. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2001-07-31 01:56 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2001-07-23 17:47 Re: [BUGS] WIN32 MULTIBYTE Darko Prenosil <Darko.Prenosil@finteh.hr> 2001-07-31 01:56 ` Tom Lane <tgl@sss.pgh.pa.us> 2001-07-25 14:59 WIN32 MULTIBYTE Darko Prenosil <Darko.Prenosil@finteh.hr> 2001-07-26 21:22 ` Bruce Momjian <pgman@candle.pha.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox