From: Tom Lane <tgl@sss.pgh.pa.us>
To: Constantin Teodorescu <teo@flex.ro>
Cc: pgsql-hackers@postgreSQL.org
Cc: pgsql-interfaces@postgreSQL.org
Subject: Re: [INTERFACES] crypt not included when compiling libpgtcl !!!!!!!
Date: Thu, 05 Nov 1998 18:16:27 -0500
Message-ID: <13907.910307787@sss.pgh.pa.us> (raw)
In-Reply-To: <3641D6F4.B0D38A89@flex.ro>
Constantin Teodorescu <teo@flex.ro> writes:
> RedHat 5.1 i386 with PostgreSQL v6.4 final version
> after installing libpgtcl , cannot run pgaccess because library crypt
> hasn't been linked into libpgtcl.so
> must manually add -lcrypt in Makefile into src/interfaces/libpgtcl
I don't think that's the right approach. libpgtcl doesn't depend on
libcrypt. libpq does, and that's where we need to fix this, or else
we'll see the same problem with any other shared library that depends
on libpq.
Would you check whether it works to add the following patch to
src/interfaces/libpq's Makefile, and then build libpgtcl *without*
a reference to crypt? (I can't test it here since crypt is part of
libc on my machine...)
inline patch 1: Makefile.in (+4/-0 lines) download inline-1.patch*** Makefile.in~ Thu Nov 5 18:08:26 1998
--- Makefile.in Thu Nov 5 18:11:43 1998
***************
*** 34,39 ****
--- 34,43 ----
OBJS+= common.o wchar.o conv.o
endif
+ # If crypt is a separate library, rather than part of libc,+ # make sure it gets included in shared libpq.+ SHLIB_LINK= $(findstring -lcrypt,$(LIBS))+
# Shared library stuff, also default 'all' target
include $(SRCDIR)/Makefile.shlib
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: tgl@sss.pgh.pa.us, teo@flex.ro, pgsql-hackers@postgreSQL.org
Subject: Re: [INTERFACES] crypt not included when compiling libpgtcl !!!!!!!
In-Reply-To: <13907.910307787@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox