pg.ddx.io pgsql-interfaces@postgresql.org mailing list archive
help / color / mirror / Atom feedatttypmod now 32 bits, interface change
21+ messages / 8 participants
[nested] [flat]
* atttypmod now 32 bits, interface change
@ 1998-07-13 02:51 Bruce Momjian <maillist@candle.pha.pa.us>
0 siblings, 1 reply; 21+ messages in thread
From: Bruce Momjian @ 1998-07-13 02:51 UTC (permalink / raw)
To: pgsql-interfaces; hackers@postgresql.org
I was wrong.
atttypmod was passed as int16 to the clients. attypmod is now passed as
int32. I have modified libpq to fix this. I think only odbc needs to
be changed for this. I know odbc is not maintained here, but is
uploaded from somewhere else. The maintainer needs to change this. The
other interfaces look OK.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 12:42 David Hartwig <daveh@insightdist.com>
parent: Bruce Momjian <maillist@candle.pha.pa.us>
0 siblings, 3 replies; 21+ messages in thread
From: David Hartwig @ 1998-07-13 12:42 UTC (permalink / raw)
To: Bruce Momjian <maillist@candle.pha.pa.us>; +Cc: pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>; Byron Nikolaidis <byronn@insightdist.com>
Not that we have been sitting on our hands, but we have been waiting for the
FE/BE protocol to stabilize before updating the ODBC driver to the 6.4
specs. Have we reached this point?
Bruce Momjian wrote:
> I was wrong.
>
> atttypmod was passed as int16 to the clients. attypmod is now passed as
> int32. I have modified libpq to fix this. I think only odbc needs to
> be changed for this. I know odbc is not maintained here, but is
> uploaded from somewhere else. The maintainer needs to change this. The
> other interfaces look OK.
>
> --
> Bruce Momjian | 830 Blythe Avenue
> maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
> + If your life is a hard drive, | (610) 353-9879(w)
> + Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 13:41 Tom Lane <tgl@sss.pgh.pa.us>
parent: David Hartwig <daveh@insightdist.com>
2 siblings, 2 replies; 21+ messages in thread
From: Tom Lane @ 1998-07-13 13:41 UTC (permalink / raw)
To: David Hartwig <daveh@insightdist.com>; +Cc: pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>
David Hartwig <daveh@insightdist.com> writes:
> Not that we have been sitting on our hands, but we have been waiting for the
> FE/BE protocol to stabilize before updating the ODBC driver to the 6.4
> specs. Have we reached this point?
The cancel changeover and this atttypmod width business were the only
open issues I know about. I'm prepared to declare the protocol frozen
for 6.4 ... are there any objections?
regards, tom lane
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 13:58 Bruce Momjian <maillist@candle.pha.pa.us>
parent: David Hartwig <daveh@insightdist.com>
2 siblings, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-13 13:58 UTC (permalink / raw)
To: daveh@insightdist.com; +Cc: pgsql-interfaces; hackers@postgreSQL.org; byronn@insightdist.com
> Not that we have been sitting on our hands, but we have been waiting for the
> FE/BE protocol to stabilize before updating the ODBC driver to the 6.4
> specs. Have we reached this point?
Good point. I totally agree.
I think we have finally stabalized the protocol, with the CANCEL
completed last week by Tom Lane. As far as I know, the libpq and sgml
docs are updated, so you can use them to see the changes. If you need
details, I have kept some of Tom Lane's postings.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 13:59 Bruce Momjian <maillist@candle.pha.pa.us>
parent: David Hartwig <daveh@insightdist.com>
2 siblings, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-13 13:59 UTC (permalink / raw)
To: daveh@insightdist.com; +Cc: pgsql-interfaces; hackers@postgreSQL.org; byronn@insightdist.com
> Not that we have been sitting on our hands, but we have been waiting for the
> FE/BE protocol to stabilize before updating the ODBC driver to the 6.4
> specs. Have we reached this point?
Of course, beta does not start until Sep 1, so it is possible to wait
some more to see of other things change before updating things, but
currently, there are no open items I know about.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 14:46 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-13 14:46 UTC (permalink / raw)
To: tgl@sss.pgh.pa.us; +Cc: daveh@insightdist.com; pgsql-interfaces; hackers@postgreSQL.org
> David Hartwig <daveh@insightdist.com> writes:
> > Not that we have been sitting on our hands, but we have been waiting for the
> > FE/BE protocol to stabilize before updating the ODBC driver to the 6.4
> > specs. Have we reached this point?
>
> The cancel changeover and this atttypmod width business were the only
> open issues I know about. I'm prepared to declare the protocol frozen
> for 6.4 ... are there any objections?
I agree. We are done.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 14:54 Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 2 replies; 21+ messages in thread
From: Thomas G. Lockhart @ 1998-07-13 14:54 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <maillist@candle.pha.pa.us>; +Cc: David Hartwig <daveh@insightdist.com>; pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>
> The cancel changeover and this atttypmod width business were the only
> open issues I know about. I'm prepared to declare the protocol frozen
> for 6.4 ... are there any objections?
Sounds good. Should we ask Tatsuo to do some mixed-endian tests, or is
that area completely unchanged from v6.3?
- Tom
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 15:15 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
1 sibling, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-13 15:15 UTC (permalink / raw)
To: lockhart@alumnus.caltech.edu; +Cc: tgl@sss.pgh.pa.us; daveh@insightdist.com; pgsql-interfaces; hackers@postgreSQL.org
> > The cancel changeover and this atttypmod width business were the only
> > open issues I know about. I'm prepared to declare the protocol frozen
> > for 6.4 ... are there any objections?
>
> Sounds good. Should we ask Tatsuo to do some mixed-endian tests, or is
> that area completely unchanged from v6.3?
>
> - Tom
>
Unchanged, I think.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 15:18 Bruce Momjian <maillist@candle.pha.pa.us>
0 siblings, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-13 15:18 UTC (permalink / raw)
To: maillist@candle.pha.pa.us; +Cc: daveh@insightdist.com; pgsql-interfaces; hackers@postgreSQL.org; byronn@insightdist.com
> > Not that we have been sitting on our hands, but we have been waiting for the
> > FE/BE protocol to stabilize before updating the ODBC driver to the 6.4
> > specs. Have we reached this point?
>
> Of course, beta does not start until Sep 1, so it is possible to wait
> some more to see of other things change before updating things, but
> currently, there are no open items I know about.
I have also renamed some of the client structure names used internally
by libpq. adtid, adtsize were too strange/confusing for me. Now they
are typid and typlen. Should help clarify why atttypmod is needed,
because many types, varchar(), don't have TYPE sizes.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-13 15:32 Tom Lane <tgl@sss.pgh.pa.us>
parent: Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
1 sibling, 1 reply; 21+ messages in thread
From: Tom Lane @ 1998-07-13 15:32 UTC (permalink / raw)
To: pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>
"Thomas G. Lockhart" <lockhart@alumnus.caltech.edu> writes:
> Should we ask Tatsuo to do some mixed-endian tests, or is
> that area completely unchanged from v6.3?
I don't think I broke anything in that regard ... but more testing is
always a good thing. If Tatsuo-san can spare the time, it would be
appreciated.
regards, tom lane
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-14 13:01 Tatsuo Ishii <t-ishii@sra.co.jp>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 21+ messages in thread
From: t-ishii@sra.co.jp @ 1998-07-14 13:01 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>
At 11:32 AM 98.7.13 -0400, Tom Lane wrote:
>"Thomas G. Lockhart" <lockhart@alumnus.caltech.edu> writes:
>> Should we ask Tatsuo to do some mixed-endian tests, or is
>> that area completely unchanged from v6.3?
>
>I don't think I broke anything in that regard ... but more testing is
>always a good thing. If Tatsuo-san can spare the time, it would be
>appreciated.
Ok, I think I can start the testing next week.
This week I'm too busy because I have to finish writing an article
on PostgreSQL for a Japanese magazine!
By the way what are the visible changes of 6.4?
I know now we can cancel a query. Could you tell me any other
thing so that I could refer to them in the article?
--
Tatsuo Ishii
t-ishii@sra.co.jp
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-14 13:42 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Tatsuo Ishii <t-ishii@sra.co.jp>
1 sibling, 1 reply; 21+ messages in thread
From: Bruce Momjian @ 1998-07-14 13:42 UTC (permalink / raw)
To: t-ishii@sra.co.jp; +Cc: tgl@sss.pgh.pa.us; pgsql-interfaces; hackers@postgreSQL.org
At 11:32 AM 98.7.13 -0400, Tom Lane wrote:
>"Thomas G. Lockhart" <lockhart@alumnus.caltech.edu> writes:
>> Should we ask Tatsuo to do some mixed-endian tests, or is
>> that area completely unchanged from v6.3?
>
>I don't think I broke anything in that regard ... but more testing is
>always a good thing. If Tatsuo-san can spare the time, it would be
>appreciated.
>Ok, I think I can start the testing next week.
>This week I'm too busy because I have to finish writing an article
>on PostgreSQL for a Japanese magazine!
>By the way what are the visible changes of 6.4?
>I know now we can cancel a query. Could you tell me any other
>thing so that I could refer to them in the article?
---------------------------------------------------------------------------
Nothing big that I can think of. Lots of cleanup/improvements to
existing areas. Vadim has some big items (as usual), but I don't think
we want to mention them publically yet.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-14 15:09 Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
parent: Bruce Momjian <maillist@candle.pha.pa.us>
0 siblings, 2 replies; 21+ messages in thread
From: Thomas G. Lockhart @ 1998-07-14 15:09 UTC (permalink / raw)
To: Bruce Momjian <maillist@candle.pha.pa.us>; +Cc: t-ishii@sra.co.jp; tgl@sss.pgh.pa.us; pgsql-interfaces; hackers@postgreSQL.org
> >This week I'm too busy because I have to finish writing an article
> >on PostgreSQL for a Japanese magazine!
> >By the way what are the visible changes of 6.4?
> >I know now we can cancel a query. Could you tell me any other
> >thing so that I could refer to them in the article?
> Nothing big that I can think of. Lots of cleanup/improvements to
> existing areas.
Now Bruce! The automatic type coersion features are a pretty big change,
especially for the casual user; the columns in queries get matched up
and converted without any explicit work from the user. I can give Tatsuo
some examples if he would like. I'll bet there are a few other changes
which would give readers a good idea about the ongoing support and
improvements to Postgres...
Speaking of docs, we'll have SQL and utility commands in an
html/hardcopy reference manual. Hmm, may not be as exciting for Japanese
readers, but... :)
I've been updating the old release notes in the sgml sources, and have
that completed. Perhaps we can start the v6.4 release notes now? With
the sgml sources we can have more summary verbiage to help users get
introduced to new features, and then roll it out into a text file if
necessary.
- Tom
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change]
@ 1998-07-14 15:37 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
1 sibling, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-14 15:37 UTC (permalink / raw)
To: lockhart@alumnus.caltech.edu; +Cc: t-ishii@sra.co.jp; tgl@sss.pgh.pa.us; pgsql-interfaces; hackers@postgreSQL.org
> > >This week I'm too busy because I have to finish writing an article
> > >on PostgreSQL for a Japanese magazine!
> > >By the way what are the visible changes of 6.4?
> > >I know now we can cancel a query. Could you tell me any other
> > >thing so that I could refer to them in the article?
> > Nothing big that I can think of. Lots of cleanup/improvements to
> > existing areas.
>
> Now Bruce! The automatic type coersion features are a pretty big change,
> especially for the casual user; the columns in queries get matched up
> and converted without any explicit work from the user. I can give Tatsuo
> some examples if he would like. I'll bet there are a few other changes
> which would give readers a good idea about the ongoing support and
> improvements to Postgres...
>
> Speaking of docs, we'll have SQL and utility commands in an
> html/hardcopy reference manual. Hmm, may not be as exciting for Japanese
> readers, but... :)
>
> I've been updating the old release notes in the sgml sources, and have
> that completed. Perhaps we can start the v6.4 release notes now? With
> the sgml sources we can have more summary verbiage to help users get
> introduced to new features, and then roll it out into a text file if
> necessary.
I was afraid I was going to insult someone by saying what I did.
I MEANT that there are no features being added that a non-postgresql
user would be interested in. subselects was one feature that
non-postgresql users would understand. Most of our stuff now is
cleanup/extension of 6.3 features, many of which would be uninteresting
to potential users.
I suggest we focus on telling them about 6.3, which is ready NOW, and
has many nice features.
In fact, since we started two years ago, every release has gotten much
better than the previous, so we are now at a point where we are adding
'nifty' features like 'cancel' and atttypmod and stuff like that.
The days where every release fixed server crashes, or added a feature
that users were 'screaming for' may be a thing of the past. We are
nearing a maturity stage, where we can focus on performance,
documenation, features, and cleanup. The days when we have a 'major'
feature may be fewer, because we have added 'most' of the major features
people have been asking for.
Our user base is growing, and the number of sophisticated developers is
growing too, so we are getting major patches to improve lots of existing
functionality.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [INTERFACES][HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-15 10:04 Herouth Maoz <herouth@oumail.openu.ac.il>
parent: Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
1 sibling, 1 reply; 21+ messages in thread
From: Herouth Maoz @ 1998-07-15 10:04 UTC (permalink / raw)
To: hackers@postgreSQL.org; pgsql-general@postgreSQL.org
At 18:37 +0300 on 14/7/98, Bruce Momjian wrote:
> The days where every release fixed server crashes, or added a feature
> that users were 'screaming for' may be a thing of the past. We are
> nearing a maturity stage, where we can focus on performance,
> documenation, features, and cleanup. The days when we have a 'major'
> feature may be fewer, because we have added 'most' of the major features
> people have been asking for.
Except row-level locking, referential integrity and PL/SQL...
Just an example of major features yet to be implemented (speaking from the
point of view of a user who doesn't know what the plans are for 6.4, of
course).
Herouth
(PS. This thread doesn't really have anything to do with the interfaces
list, does it? I redirected the crosspost to "general".)
--
Herouth Maoz, Internet developer.
Open University of Israel - Telem project
http://telem.openu.ac.il/~herutma
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [INTERFACES][HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-15 14:42 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Herouth Maoz <herouth@oumail.openu.ac.il>
0 siblings, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-15 14:42 UTC (permalink / raw)
To: herouth@oumail.openu.ac.il; +Cc: hackers@postgreSQL.org; pgsql-general@postgreSQL.org
> At 18:37 +0300 on 14/7/98, Bruce Momjian wrote:
>
>
> > The days where every release fixed server crashes, or added a feature
> > that users were 'screaming for' may be a thing of the past. We are
> > nearing a maturity stage, where we can focus on performance,
> > documenation, features, and cleanup. The days when we have a 'major'
> > feature may be fewer, because we have added 'most' of the major features
> > people have been asking for.
>
> Except row-level locking, referential integrity and PL/SQL...
I said the days would be fewer, not gone.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-22 05:22 t-ishii@sra.co.jp
parent: Tatsuo Ishii <t-ishii@sra.co.jp>
1 sibling, 2 replies; 21+ messages in thread
From: t-ishii@sra.co.jp @ 1998-07-22 05:22 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>
>At 11:32 AM 98.7.13 -0400, Tom Lane wrote:
>>"Thomas G. Lockhart" <lockhart@alumnus.caltech.edu> writes:
>>> Should we ask Tatsuo to do some mixed-endian tests, or is
>>> that area completely unchanged from v6.3?
>>
>>I don't think I broke anything in that regard ... but more testing is
>>always a good thing. If Tatsuo-san can spare the time, it would be
>>appreciated.
>
>Ok, I think I can start the testing next week.
I did some cross-platform testing today against 7/18 snapshot. The
platforms tested are:
1. Sparc/Solaris 2.6
2. PowerPC/Linux
3. x86/FreeBSD
4. x86/Linux
They workd fine!
P.S.
I noticed that 6.4 client did not talk to 6.3.2 server.
[srapc451.sra.co.jp]t-ishii{157}
Connection to database 'test' failed.
Unsupported frontend protocol.[srapc451.sra.co.jp]t-ishii{158}
I thought that we have kept the "backward compatibility" since we
introduced "protocol version" in libpq?
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-22 13:58 Bruce Momjian <maillist@candle.pha.pa.us>
parent: t-ishii@sra.co.jp
1 sibling, 1 reply; 21+ messages in thread
From: Bruce Momjian @ 1998-07-22 13:58 UTC (permalink / raw)
To: t-ishii@sra.co.jp; +Cc: tgl@sss.pgh.pa.us; pgsql-interfaces; hackers@postgreSQL.org
> >At 11:32 AM 98.7.13 -0400, Tom Lane wrote:
> >>"Thomas G. Lockhart" <lockhart@alumnus.caltech.edu> writes:
> >>> Should we ask Tatsuo to do some mixed-endian tests, or is
> >>> that area completely unchanged from v6.3?
> >>
> >>I don't think I broke anything in that regard ... but more testing is
> >>always a good thing. If Tatsuo-san can spare the time, it would be
> >>appreciated.
> >
> >Ok, I think I can start the testing next week.
>
> I did some cross-platform testing today against 7/18 snapshot. The
> platforms tested are:
>
> 1. Sparc/Solaris 2.6
> 2. PowerPC/Linux
> 3. x86/FreeBSD
> 4. x86/Linux
>
> They workd fine!
>
> P.S.
> I noticed that 6.4 client did not talk to 6.3.2 server.
>
> [srapc451.sra.co.jp]t-ishii{157}
>
>
>
> Connection to database 'test' failed.
> Unsupported frontend protocol.[srapc451.sra.co.jp]t-ishii{158}
>
> I thought that we have kept the "backward compatibility" since we
> introduced "protocol version" in libpq?
Might be my atttypmod changes. I did not make those version-sensitive.
I will do that now.
However, the protocol version number thing looks like something more
fundamental.
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-22 14:43 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <maillist@candle.pha.pa.us>
0 siblings, 1 reply; 21+ messages in thread
From: Tom Lane @ 1998-07-22 14:43 UTC (permalink / raw)
To: t-ishii@sra.co.jp; +Cc: pgsql-interfaces; hackers@postgreSQL.org
t-ishii@sra.co.jp writes:
>> I noticed that 6.4 client did not talk to 6.3.2 server.
>> Connection to database 'test' failed.
>> Unsupported frontend protocol.
>>
>> I thought that we have kept the "backward compatibility" since we
>> introduced "protocol version" in libpq?
Backwards compatibility yes: a 6.4 server should be able to talk to
an old client. You're asking about cross-version compatibility in the
other direction, which is something we don't have. The connection
protocol is designed to let the server accommodate to the client, not
vice versa --- the client tells the server its version, but not vice
versa. I suppose the client might check for that particular error
message after a connect failure and then try again with a lower version
number ... but that's pretty messy.
On a practical level, the new libpq is not capable of talking to an old
server anyway --- some of the cleanups I made are critically dependent
on new protocol features, such as the 'Z' (ReadyForQuery) message.
Bruce Momjian <maillist@candle.pha.pa.us> writes:
> Might be my atttypmod changes. I did not make those version-sensitive.
> I will do that now.
Yes, if we want to have backward compatibility as I just defined it,
then the backend will have to send atttypmod as either 2 or 4 bytes
depending on ProtocolVersion. Shouldn't be too hard. But I'm concerned
that you and I both missed that initially. We had better actually test
that the current backend sources will work with a 6.3.2-release frontend.
regards, tom lane
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [INTERFACES] Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-22 14:49 Thomas G. Lockhart <lockhart@alumni.caltech.edu>
parent: t-ishii@sra.co.jp
1 sibling, 0 replies; 21+ messages in thread
From: Thomas G. Lockhart @ 1998-07-22 14:49 UTC (permalink / raw)
To: t-ishii@sra.co.jp; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-interfaces; PostgreSQL-development <hackers@postgreSQL.org>
> I did some cross-platform testing today against 7/18 snapshot.
> They workd fine!
Great. Thanks Tatsuo.
- Tom
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: [HACKERS] atttypmod now 32 bits, interface change
@ 1998-07-22 15:10 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 1998-07-22 15:10 UTC (permalink / raw)
To: tgl@sss.pgh.pa.us; +Cc: t-ishii@sra.co.jp; pgsql-interfaces; hackers@postgreSQL.org
> Bruce Momjian <maillist@candle.pha.pa.us> writes:
> > Might be my atttypmod changes. I did not make those version-sensitive.
> > I will do that now.
>
> Yes, if we want to have backward compatibility as I just defined it,
> then the backend will have to send atttypmod as either 2 or 4 bytes
> depending on ProtocolVersion. Shouldn't be too hard. But I'm concerned
> that you and I both missed that initially. We had better actually test
> that the current backend sources will work with a 6.3.2-release frontend.
Already done. We never passed atttypmod to the backend before 6.4, so
the change it just to pass it or not pass it, and Tom already did that.
The fact that the internal length was 2 and is not 4 is not relevant
because we never passed it to the frontend in the past.
if (PG_PROTOCOL_MAJOR(FrontendProtocol) >= 2)
pq_putint(attrs[i]->atttypmod, sizeof(attrs[i]->atttypmod...
--
Bruce Momjian | 830 Blythe Avenue
maillist@candle.pha.pa.us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
^ permalink raw reply [nested|flat] 21+ messages in thread
end of thread, other threads:[~1998-07-22 15:10 UTC | newest]
Thread overview: 21+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
1998-07-13 02:51 atttypmod now 32 bits, interface change Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-13 12:42 ` David Hartwig <daveh@insightdist.com>
1998-07-13 13:41 ` Tom Lane <tgl@sss.pgh.pa.us>
1998-07-13 14:46 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-13 14:54 ` Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
1998-07-13 15:15 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-13 15:32 ` Tom Lane <tgl@sss.pgh.pa.us>
1998-07-14 13:01 ` Tatsuo Ishii <t-ishii@sra.co.jp>
1998-07-14 13:42 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-14 15:09 ` Thomas G. Lockhart <lockhart@alumnus.caltech.edu>
1998-07-14 15:37 ` Re: [HACKERS] atttypmod now 32 bits, interface change] Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-15 10:04 ` Herouth Maoz <herouth@oumail.openu.ac.il>
1998-07-15 14:42 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-22 05:22 ` t-ishii@sra.co.jp
1998-07-22 13:58 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-22 14:43 ` Tom Lane <tgl@sss.pgh.pa.us>
1998-07-22 15:10 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-22 14:49 ` Thomas G. Lockhart <lockhart@alumni.caltech.edu>
1998-07-13 13:58 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-13 13:59 ` Bruce Momjian <maillist@candle.pha.pa.us>
1998-07-13 15:18 Re: [HACKERS] atttypmod now 32 bits, interface change Bruce Momjian <maillist@candle.pha.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox