From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Reinhard Max <max@suse.de>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: elf@solvo.ru
Cc: pgsql-bugs@postgresql.org
Subject: Re: libpgtcl doesn't use UTF encoding of TCL
Date: Fri, 20 Jul 2001 11:17:26 -0400 (EDT)
Message-ID: <200107201517.f6KFHQC14099@candle.pha.pa.us> (raw)
In-Reply-To: <Pine.LNX.4.33.0107201634560.15079-100000@wotan.suse.de>
> On Fri, 20 Jul 2001, Peter Eisentraut wrote:
>
> > Reinhard Max writes:
> >
> > > OK, I'll pack the new stuff inside #ifdef TCL_UTF8 and define that if
> > > the Tcl version is 8.1 or greater.
> >
> > No, please add a configure check for Tcl_UtfToExternalDString or
> > some other function representative of this interface..
>
> Why make simple things complicated?
> Tcl changed it's internal string representation starting with release
> 8.1 . It is not an interface one can decide whether to use it or not.
> Every extension that imports or exports strings and gets compiled for
> Tcl >= 8.1 has to make sure that they are UTF8 regardless, if it uses
> the Tcl_*Utf*DString functions or something else. So I consider it
> sufficient to define TCL_UTF8 if Tcl's Version is >= 8.1 as I did in
> the patch that was attached to my last mail.
I think he is OK checking the TCL version. It is pretty common to check
the TCL include file for symbols and handle things that way. Do we test
any other TCL include defines from configure?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pgman@candle.pha.pa.us, max@suse.de, peter_e@gmx.net, tgl@sss.pgh.pa.us, elf@solvo.ru, pgsql-bugs@postgresql.org
Subject: Re: libpgtcl doesn't use UTF encoding of TCL
In-Reply-To: <200107201517.f6KFHQC14099@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox