From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: PQfnumber and quoted identifiers
Date: Sun, 5 Oct 2003 15:41:15 -0400 (EDT)
Message-ID: <200310051941.h95JfFd26212@candle.pha.pa.us> (raw)
In-Reply-To: <8636.1065378408@sss.pgh.pa.us>
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Peter Eisentraut wrote:
> >> Since this behavior was undocumented and no one had noticed it in the last
> >> 10 years, I think we can away with removing it.
>
> > I agree. I would never expect to add quotes to a C string to preserve
> > case (outside SQL), and the fact that PQfname doesn't return the string
> > in quotes is another inconsistency.
>
> Actually I was planning to quiz you about the history. I can see from
> the CVS logs that you installed all the patches that added the
> quoting/downcasing behavior. Was there any discussion about it?
> I dug through the mail archives and found
>
> http://archives.postgresql.org/pgsql-ports/1997-05/msg00081.php
> http://archives.postgresql.org/pgsql-bugs/1997-05/msg00023.php
> http://archives.postgresql.org/pgsql-hackers/1997-11/msg00170.php
>
> but I could not find any actual discussion about whether there was a
> real bug or whether the complainants should be told to fix their code.
Wow, 1997 --- seems like a time long ago.
As I remember, I crudely coded up a fix for the complaint --- that's the
way we did it back then. :-)
There probably wasn't a lot of discussion, if any --- people complained,
and we coded to fix the complaint. In hindsight, I should have told
them the API was working properly, but the idea of telling a user they
were wrong wasn't something we did back then --- we needed every user we
could get.
My guess is that the email reports from May, 1997 were in my mailbox,
and in Novemeber I saw it again (I was a volunteer then) and I coded up
the fix, posted it to the lists, then applied it. No one said anything
about it, so it stayed in.
Strange no one complained about it until now. I suppose that is because
few folks use that function _and_ upper-case identifiers, as you
mentioned. We could code the proper behavior, post a mention on
general, and document it in the release notes, or wait for 7.5, or do
nothing.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pgman@candle.pha.pa.us, tgl@sss.pgh.pa.us, peter_e@gmx.net, pgsql-hackers@postgresql.org
Subject: Re: PQfnumber and quoted identifiers
In-Reply-To: <200310051941.h95JfFd26212@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox