From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Jürgen Cappel <email@juergen-cappel.de>
Cc: pgsql-interfaces <pgsql-interfaces@postgresql.org>
Subject: Re: ECPG segfault
Date: Mon, 29 Mar 2004 10:26:37 -0500 (EST)
Message-ID: <200403291526.i2TFQbS11892@candle.pha.pa.us> (raw)
In-Reply-To: <JEEKIPNAKJNCFLMOBKHGKEHKDCAA.email@juergen-cappel.de>
Michael has fixed this in 7.4.X and CVS HEAD. Thanks.
---------------------------------------------------------------------------
Jürgen Cappel wrote:
> The code in ecpg/preproc/type.c has a problem when allocating
> memory. I'm referring to the function ECPGdump_a_simple() where
> one of the first actions is allocating memory and assigning it
> to variable "offset". The amount of memory requested depends on
> the size of the variable's name and the length of a fixed string.
> The function has a parameter called "varcharsize" (array size string)
> which is later used in the "case ECPGt_char:" where it is included
> in an sprintf() to fill the allocated memory area. This leads to
> a subsequent segmentation fault if "varcharsize" is not a simple
> integer but maybe a cpp macro of some length, say, 20 bytes. At
> least it *can* lead to a segfault, because you never know how and
> when memory corruption strikes back on you ...
>
> Using my example, things work well when allocating a few bytes more,
> but i would suggest adding a strlen(varcharsize) instead of 1 byte
> for allocation of "offset".
>
> Comments are welcome ! Best regards, J?rgen Cappel
>
> Oh, and btw thanks to valgrind for pointing me to that place :-)
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pgman@candle.pha.pa.us, email@juergen-cappel.de
Subject: Re: ECPG segfault
In-Reply-To: <200403291526.i2TFQbS11892@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox