From: Michael Meskes <meskes@postgresql.org>
To: Michael Fuhr <mike@fuhr.org>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: PostgreSQL-interfaces <pgsql-interfaces@postgresql.org>
Cc: PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] ECPG ignores SAVEPOINT if first statement of a transaction
Date: Mon, 12 Sep 2005 14:36:34 +0200
Message-ID: <20050912123634.GB21008@1> (raw)
In-Reply-To: <20050813150145.GA87926@winnie.fuhr.org>
References: <20050803153223.GA17861@winnie.fuhr.org>
<200508130222.j7D2MWh29185@candle.pha.pa.us>
<20050813150145.GA87926@winnie.fuhr.org>
On Sat, Aug 13, 2005 at 09:01:45AM -0600, Michael Fuhr wrote:
> If no statements have been executed in this transaction then committed
> is true, so ECPGtrans() ignores the current statement. It looks
> like the code should make an extra consideration for SAVEPOINT in
> case it's the first statement.
I rearranged the whole code as it seemed to have more holes. This code
really was old. :-)
So could you please check with the lates CVS, either HEAD or 8.0?
> I'm also wondering if the check for a NULL return value from PQexec()
> is sufficient. Shouldn't it also check for a non-NULL result that's
> anything other than PGRES_COMMAND_OK?
Yes, it should. I changed this as well.
Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: meskes@postgresql.org, mike@fuhr.org, pgman@candle.pha.pa.us, pgsql-patches@postgresql.org
Subject: Re: [HACKERS] ECPG ignores SAVEPOINT if first statement of a transaction
In-Reply-To: <20050912123634.GB21008@1>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox