From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Michael Glaesemann <grzm@myrealbox.com>
Cc: pgsql-patches@postgreSQL.org
Cc: pgsql-interfaces@postgreSQL.org
Subject: Re: Proposed p.tch for error locations
Date: Mon, 13 Mar 2006 10:57:07 -0500
Message-ID: <7693.1142265427@sss.pgh.pa.us> (raw)
In-Reply-To: <20060313153209.GA15002@surnet.cl>
References: <5114.1142185055@sss.pgh.pa.us>
<C3817205-17E1-4D6C-9D92-ED6045123F92@myrealbox.com>
<7274.1142262691@sss.pgh.pa.us>
<20060313153209.GA15002@surnet.cl>
Alvaro Herrera <alvherre@commandprompt.com> writes:
> This doesn't work on terminal using a variable-width font, does it?
> Sure, you can have all the interfaces use a monospace font, but it seems
> a weird thing to do. I think the line/character position should be
> returned in a separate error attribute in ereport. So for example
> pgAdmin could count characters and mark it in bold or use a different
> color.
That information is already available to pgAdmin, and has been since
7.4; if they are failing to exploit it that's their problem not libpq's.
Basically what's at stake here is the behavior of "dumb" applications
that are just using PQerrorMessage and not doing anything smart with
error message fields. It does not seem unreasonable to me to assume
fixed-width font in that context. We haven't seen any complaints about
psql doing it have we?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@commandprompt.com, grzm@myrealbox.com, pgsql-patches@postgreSQL.org
Subject: Re: Proposed p.tch for error locations
In-Reply-To: <7693.1142265427@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox