From: Tom Lane <tgl@sss.pgh.pa.us>
To: ljb <lbayuk@mindspring.com>
To: g.hintermayer@inode.at
Cc: pgsql-interfaces@postgresql.org
Subject: Re: still memory leaks with libpgtcl
Date: Tue, 07 Jan 2003 23:23:38 -0500
Message-ID: <785.1041999818@sss.pgh.pa.us> (raw)
In-Reply-To: <avg4mq$1ikp$1@news.hub.org>
References: <as0da6$2njk$1@news.hub.org>
<auhq8v$2iuo$1@news.hub.org>
<auj41k$f4v$1@news.hub.org>
<avf32e$rep$1@news.hub.org>
<avg4mq$1ikp$1@news.hub.org>
ljb <lbayuk@mindspring.com> writes:
> This patch is
> seriously ugly and 'highly suspect', and I am NOT suggesting this be
> included in the PostgreSQL release. Really. But it works. Maybe.
What we really need to do is reel in a Tcl guru to look at this.
I think that there is a Tcl bug here somewhere; even if not, we seem
to need someone who knows the Tcl library inside-and-out to tell us
what we're doing wrong.
I don't have the time or interest to pursue this with the Tcl community,
but perhaps one of you can do it?
> -#ifdef NOT_USED
> #if TCL_MAJOR_VERSION >= 8
> - if (connid->notifier_channel != NULL)
> + if (connid->notifier_channel != NULL && interp != NULL)
> Tcl_UnregisterChannel(NULL, connid->notifier_channel);
> #endif
> -#endif
Cool solution if it works --- but I'll not accept it unless someone can
explain to me *why* it fixes the problem, and preferably just where in
the Tcl documentation this is promised to be a correct solution...
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: tgl@sss.pgh.pa.us, lbayuk@mindspring.com, g.hintermayer@inode.at
Subject: Re: still memory leaks with libpgtcl
In-Reply-To: <785.1041999818@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox