From: Andreas Theofilu <theofilu@eunet.at>
To: pgsql-interfaces@postgreSQL.org
Cc: meskes@debian.org
Subject: Found error with apostrophes in ecpg
Date: Tue, 14 Sep 1999 10:34:38 +0200
Message-ID: <99091411152301.01383@theofilu> (raw)
Hi,
After playing around, I've found now the error in 'libecpg.so' that
ignored a quoted apostrophe. Detailed description with correction follows:
Symptom:
You've written source with embedded SQL comands and you've translated the
source with 'ecpg' first and then compiled it with your C compiler. Then
you've started the final program and now you wan't to insert a string
into a table that contains an apostrophe. The insert command returns with
the runtime error "Too many arguments in line xxx", allthough there's no
syntax error in your code.
Problem:
'libecpg.so' contains an internal function quote_postgres() (in
ecpglib.c line 217) that quotes every apostrophe with a backslash. So far
so well. The error occures in function next_insert() (in ecpglib.c line
362). This function looks for an apostrophe and if it finds one, it
interpretes it as 'end of string'. But it does not care about a backslash
in front of the apostrophe.
Solution:
361: static char *
362: next_insert(char *text)
363: {
364: char *ptr = text;
365: bool string = false;
366:
367: for (; *ptr != '\0' && (*ptr != '?' || string); ptr++)
368: if (*ptr == '\'' && *(ptr-1) != '\\')
369: string = string ? false : true;
370:
371: return (*ptr == '\0') ? NULL : ptr;
372: }
Line 368 was altered by me. The original line looks like:
368: if (*ptr == '\'')
As you can see, the backslash is honored now.
--
Theofilu Andreas
http://members.eunet.at/theofilu
-------------------------------------------------
Enjoy the science of Linux!
Genieße die Wissenschaft von Linux!
-------------------------------------------------
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: theofilu@eunet.at, meskes@debian.org
Subject: Re: Found error with apostrophes in ecpg
In-Reply-To: <99091411152301.01383@theofilu>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox