public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: mahendrakar s <[email protected]>
Cc: pgsql-novice <[email protected]>
Subject: Re: best way to apply and work on the patches of the pg community
Date: Fri, 15 Jul 2022 12:33:34 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABkiuWpOj1XZokr3yhSD0DepyLXYa0JsZF3wyTtTmcPGGSapYQ@mail.gmail.com>
References: <CABkiuWpOj1XZokr3yhSD0DepyLXYa0JsZF3wyTtTmcPGGSapYQ@mail.gmail.com>

mahendrakar s <[email protected]> writes:
> I would like to work on a patch published on hackers community( patch is
> from June, 2021). I cloned postgres code and tried to  apply the patch and
> got errors.

> *patch -p1 < ../0001-auth-generalize-SASL-mechanisms.patch*
> patching file src/backend/libpq/auth-scram.c
> Hunk #1 FAILED at 101.
> Hunk #2 FAILED at 170.
> Hunk #3 FAILED at 199.
> Hunk #4 FAILED at 215.
> Hunk #5 FAILED at 325.

> Can you please let me know what is the recommended way to apply the patches
> for me to begin the work?

"patch -p1" is the way that usually works the best for me.  My guess
here is that the patch in question is out of date and will need manual
adjustment to apply to HEAD.  There have been some pretty significant
changes in that code in the last year, eg 9fd85570d.

Sometimes --ignore-whitespace helps, but I doubt that's the main
problem in this case.

			regards, tom lane

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: best way to apply and work on the patches of the pg community
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox