From: Simon Riggs <simon@2ndquadrant.com>
To: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: pgsql-patches@postgresql.org
Subject: Re: WIP: executor_hook for pg_stat_statements
Date: Fri, 04 Jul 2008 09:44:25 +0100
Message-ID: <1215161065.4051.26.camel@ebony.site> (raw)
In-Reply-To: <20080623150535.946E.52131E4D@oss.ntt.co.jp>
References: <20080623150535.946E.52131E4D@oss.ntt.co.jp>
On Mon, 2008-06-23 at 15:22 +0900, ITAGAKI Takahiro wrote:
> I'm working on light-weight SQL logging for PostgreSQL.
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00601.php
>
> I divide the SQL logging feature into a core patch and an extension module.
> I hope only the patch is to be applied in the core. The extension module
> would be better to be developed separately from the core.
>
>
> The attached patch (executor_hook.patch) modifies HEAD as follows.
>
> - Add "tag" field (uint32) into PlannedStmt.
> - Add executor_hook to replace ExecutePlan().
> - Move ExecutePlan() to a global function.
The executor_hook.patch is fairly trivial and I see no errors.
The logic of including such a patch is clear. If we have a planner hook
then we should also have an executor hook.
Will you be completing the plugin for use in contrib?
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: simon@2ndquadrant.com, itagaki.takahiro@oss.ntt.co.jp
Subject: Re: WIP: executor_hook for pg_stat_statements
In-Reply-To: <1215161065.4051.26.camel@ebony.site>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox