pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Simon Riggs <simon@2ndquadrant.com>
To: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] WIP: executor_hook for pg_stat_statements
Date: Tue, 15 Jul 2008 09:31:29 +0100
Message-ID: <1216110689.19656.132.camel@ebony.2ndQuadrant> (raw)
In-Reply-To: <20080715150758.3016.52131E4D@oss.ntt.co.jp>
References: <13432.1215720702@sss.pgh.pa.us>
	<1216097491.19656.44.camel@ebony.2ndQuadrant>
	<20080715150758.3016.52131E4D@oss.ntt.co.jp>


On Tue, 2008-07-15 at 16:25 +0900, ITAGAKI Takahiro wrote:
> > > Also, after looking at the patch more closely, was there a good
> reason
> > > for making the hook intercept ExecutePlan rather than ExecutorRun?
> > 
> > That raises the question of whether we should have ExecutorStart()
> and
> > ExecutorEnd() hooks as well, to round things off.
> 
> Yeah, and also ExecutorRewind() hook. There are 4 interface functions
> in executor. My addin only needs Run hook because it doesn't modify
> the actual behavior of executor. However, when someone hope to replace
> the behavior, they need all of the hooks. (Is multi-threaded executor
> project still alive?)

No plans here, just thinking: if we do it, do it once.

The reason I wasn't thinking about the rewind part though was it seems
like someone might want to set up or tear down something at appropriate
times, so adding Start/End felt "obvious". Yes, lets have Rewind also. 

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support




view thread (14+ messages)  latest in thread

Message-ID: <1216110689.19656.132.camel@ebony.2ndQuadrant>
Permalink:  ../1216110689.19656.132.camel@ebony.2ndQuadrant/
Also on:    postgresql.org/message-id/1216110689.19656.132.camel@ebony.2ndQuadrant

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-patches@postgresql.org
  Cc: simon@2ndquadrant.com, itagaki.takahiro@oss.ntt.co.jp, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
  Subject: Re: [PATCHES] WIP: executor_hook for pg_stat_statements
  In-Reply-To: <1216110689.19656.132.camel@ebony.2ndQuadrant>
  References: <13432.1215720702@sss.pgh.pa.us> <1216097491.19656.44.camel@ebony.2ndQuadrant> <20080715150758.3016.52131E4D@oss.ntt.co.jp> <1216110689.19656.132.camel@ebony.2ndQuadrant>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox