pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Simon Riggs <simon@2ndquadrant.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Infrastructure changes for recovery
Date: Thu, 07 Aug 2008 16:55:42 +0100
Message-ID: <1218124543.4549.552.camel@ebony.2ndQuadrant> (raw)
In-Reply-To: <20080807145610.GD4171@alvh.no-ip.org>
References: <1218109459.4549.423.camel@ebony.2ndQuadrant>
	<20080807145610.GD4171@alvh.no-ip.org>


On Thu, 2008-08-07 at 10:56 -0400, Alvaro Herrera wrote:

> > * have startup process signal postmaster again when it has completed
> > recovery, so that the change of state is via explicit signal rather than
> > death of the child process
> 
> I'm not sure that this is very useful, because the startup process
> cannot do anything much.  It is an auxiliary process, which means it
> can't connect to a database and it can't run transactions.

Yes, but its going to be a lot easier to make it do transactions than it
will be to spawn something else that does? Or so I thought...

Specifically, I want to have a rmgr_post_cleanup() call to perform such
actions.

Who do you think should run those calls? They might need transactions,
or not, depending upon the rmgr. I envisage initially that rmgrs could
mark indexes as Invalid in pg_class, which requires a transaction (or
does it?).

If we did alter rmgrs to allow them to actually rebuild an index, then
it would be desirable to have them do it in parallel, just like AV
workers.

Would it be possible to use have startup to run rmgr_post_cleanup, then
provide a facility to have them run tasks through AV workers?

Sounds like a separate patch anyway.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support




view thread (52+ messages)  latest in thread

Message-ID: <1218124543.4549.552.camel@ebony.2ndQuadrant>
Permalink:  ../1218124543.4549.552.camel@ebony.2ndQuadrant/
Also on:    postgresql.org/message-id/1218124543.4549.552.camel@ebony.2ndQuadrant

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: simon@2ndquadrant.com, alvherre@commandprompt.com, pgsql-hackers@postgresql.org
  Subject: Re: Infrastructure changes for recovery
  In-Reply-To: <1218124543.4549.552.camel@ebony.2ndQuadrant>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox