From: Simon Riggs <simon@2ndQuadrant.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Subtransaction commits and Hot Standby
Date: Mon, 06 Oct 2008 08:00:31 +0100
Message-ID: <1223276431.14099.22.camel@ebony.2ndQuadrant> (raw)
In-Reply-To: <20081005185110.GC4266@alvh.no-ip.org>
References: <1221566023.3913.1823.camel@ebony.2ndQuadrant>
<48CFBC34.5010802@enterprisedb.com>
<20080916141148.GA9229@alvh.no-ip.org>
<1221749959.3913.2451.camel@ebony.2ndQuadrant>
<1222206431.4445.493.camel@ebony.2ndQuadrant>
<1222260525.4445.557.camel@ebony.2ndQuadrant>
<1222292659.4445.650.camel@ebony.2ndQuadrant>
<20081005185110.GC4266@alvh.no-ip.org>
On Sun, 2008-10-05 at 14:51 -0400, Alvaro Herrera wrote:
> Simon Riggs wrote:
>
> > OK, spent long time testing various batching scenarios for this using a
> > custom test harness to simulate various spreads of xids in transaction
> > trees. All looks fine now.
>
> I had a look and was mostly rephrasing some comments and the README
> (hopefully I didn't make any of them worse than they were), when I
> noticed that the code to iterate thru pages could be refactored. I
> think the change makes the algorithm in TransactionIdSetTreeStatus
> easier to follow.
OK, thanks for the review.
> I also noticed that TransactionIdSetPageStatus has a "subcommit" arg
> which is unexplained. I sort-of understand the point, but I think it's
> better that you fill in the explanation in the header comment (marked
> with XXX)
I'll explain some more in the code, and in the README with worked
examples of what we need to do and why.
> I hope I didn't break the code with the new function
> set_tree_status_by_pages -- please recheck that part.
Eyeballs OK.
> I didn't test this beyond regression tests.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: simon@2ndQuadrant.com, alvherre@commandprompt.com, heikki.linnakangas@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: Subtransaction commits and Hot Standby
In-Reply-To: <1223276431.14099.22.camel@ebony.2ndQuadrant>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox