From: Jeff Davis <pgsql@j-davis.com>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] GIN improvements
Date: Tue, 20 Jan 2009 10:01:29 -0800
Message-ID: <1232474489.23316.8.camel@jdavis> (raw)
In-Reply-To: <4974B002.3040202@sigaev.ru>
References: <483FD205.4090904@sigaev.ru>
<486BC501.6060605@sigaev.ru>
<27880.1215810535@sss.pgh.pa.us>
<487A6E0C.3090600@sigaev.ru>
<8993.1216843701@sss.pgh.pa.us>
<4888A594.6010102@sigaev.ru>
<490B07BA.6030109@sigaev.ru>
<492F04D9.5070404@enterprisedb.com>
<4942A137.3000502@sigaev.ru>
<1229910966.2285.76.camel@jdavis>
<49708008.8070109@sigaev.ru>
<1232348905.7281.114.camel@jdavis>
<4974B002.3040202@sigaev.ru>
On Mon, 2009-01-19 at 19:53 +0300, Teodor Sigaev wrote:
> I see only two guaranteed solution of the problem:
> - after limit is reached, force normal index inserts. One of the motivation of
> patch was frequent question from users: why update of whole table with GIN index
> is so slow? So this way will not resolve this question.
> - after limit is reached, force cleanup of pending list by calling
> gininsertcleanup. Not very good, because users sometimes will see a huge
> execution time of simple insert. Although users who runs a huge update should be
> satisfied.
>
> I have difficulties in a choice of way. Seems to me, the better will be second
> way: if user gets very long time of insertion then (auto)vacuum of his
> installation should tweaked.
>
I agree that the second solution sounds better to me.
With the new Visibility Map, it's more reasonable to run VACUUM more
often, so those that are inserting single tuples at a time should not
encounter the long insert time.
I'm still looking at the rest of the patch.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: pgsql@j-davis.com, teodor@sigaev.ru, heikki.linnakangas@enterprisedb.com, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] GIN improvements
In-Reply-To: <1232474489.23316.8.camel@jdavis>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox