pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Cc: Heikki Linnakangas <heikki@enterprisedb.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: page macros cleanup (ver 04)
Date: Sun, 13 Jul 2008 14:05:44 -0400
Message-ID: <12344.1215972344@sss.pgh.pa.us> (raw)
In-Reply-To: <4874C09F.4000302@sun.com>
References: <48529B83.9010907@sun.com>
	<2e78013d0807030450m4cab60d0jd99d1acce59fae56@mail.gmail.com>
	<486DD1D1.50604@sun.com>
	<2e78013d0807040150w393ad72codaf06a6ac12a83ce@mail.gmail.com>
	<486DF644.4070604@enterprisedb.com>
	<2e78013d0807040350m3b2913cfkceaa70d8f9d697c2@mail.gmail.com>
	<486E01B0.9050100@enterprisedb.com>
	<2e78013d0807040404q5ff7f7faq9f87a39e0f0552fa@mail.gmail.com>
	<486E138F.4060900@sun.com>
	<4874A6E0.9070909@enterprisedb.com>
	<4874C09F.4000302@sun.com>

Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> Good catch. if we have to bump catalog version then I have there small patch
> which introduce following macro and remove PageHeaderData stucture from 
> HashMetaPageData:

Seems like a bad idea --- PageGetContents is not guaranteed to deliver
a maxaligned pointer, so at least in principle this could result in
alignment violations.  It would accidentally fail to fail as of CVS
HEAD, but any future rearrangement of PageHeaderData or HashMetaPageData
could create a problem.

(Possibly PageGetContents *should* guarantee a maxaligned result,
but the current coding does not.)

			regards, tom lane



view thread (8+ messages)  latest in thread

Message-ID: <12344.1215972344@sss.pgh.pa.us>
Permalink:  ../12344.1215972344@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12344.1215972344@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: tgl@sss.pgh.pa.us, Zdenek.Kotala@Sun.COM, heikki@enterprisedb.com, pavan.deolasee@gmail.com
  Subject: Re: page macros cleanup (ver 04)
  In-Reply-To: <12344.1215972344@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox