From: Tom Lane <tgl@sss.pgh.pa.us>
To: daveg <daveg@sonic.net>
Cc: pgsql-patches@postgresql.org
Cc: hari@efrontier.com
Subject: Re: pg_dump lock timeout
Date: Sun, 20 Jul 2008 14:50:50 -0400
Message-ID: <13580.1216579850@sss.pgh.pa.us> (raw)
In-Reply-To: <20080717024407.GL11471@sonic.net>
References: <20080511113047.GV5673@sonic.net>
<20080511130035.GW5673@sonic.net>
<20080702155626.GC30328@fetter.org>
<20080717024407.GL11471@sonic.net>
daveg <daveg@sonic.net> writes:
> Here is an updated version of this patch against head. It builds, runs and
> functions as expected. I did not build the sgml.
Applied with mostly minor cosmetic improvements --- the only actual
error I noticed was failing to check whether the server version supports
statement_timeout.
In most cases our policy has been that pg_dumpall should accept and pass
through any pg_dump option for which it's sensible to do so. I did not
make that happen but it seems it'd be a reasonable follow-on patch.
A minor point is that the syntax "-X lock-wait-timeout=n" or
"-X lock-wait-timeout n" won't work, although perhaps people used to
-X might expect it to. Since we deprecate -X (and don't even document
it anymore), I thought that making this work would be much more trouble
than it's worth, but perhaps that's open to argument.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: tgl@sss.pgh.pa.us, daveg@sonic.net, hari@efrontier.com
Subject: Re: pg_dump lock timeout
In-Reply-To: <13580.1216579850@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox