From: Tom Lane <tgl@sss.pgh.pa.us>
To: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] WIP: executor_hook for pg_stat_statements
Date: Tue, 15 Jul 2008 10:56:55 -0400
Message-ID: <19450.1216133815@sss.pgh.pa.us> (raw)
In-Reply-To: <20080715150758.3016.52131E4D@oss.ntt.co.jp>
References: <13432.1215720702@sss.pgh.pa.us>
<1216097491.19656.44.camel@ebony.2ndQuadrant>
<20080715150758.3016.52131E4D@oss.ntt.co.jp>
ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> Simon Riggs <simon@2ndquadrant.com> wrote:
>>> Also, after looking at the patch more closely, was there a good reason
>>> for making the hook intercept ExecutePlan rather than ExecutorRun?
>>
>> That raises the question of whether we should have ExecutorStart() and
>> ExecutorEnd() hooks as well, to round things off.
> Yeah, and also ExecutorRewind() hook.
I'm not impressed by this line of argument. If we start putting in
hooks just because someone might need 'em someday, we'd soon end up with
hundreds or thousands of mostly-useless hooks. I'm happy to put in
hooks that there's a demonstrated need for, but I don't believe that
"replace the executor without touching the core code" is a sane goal.
Even if it were, the API of the executor to the rest of the system
is a whole lot wider than four functions.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: tgl@sss.pgh.pa.us, itagaki.takahiro@oss.ntt.co.jp, simon@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] WIP: executor_hook for pg_stat_statements
In-Reply-To: <19450.1216133815@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox