From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Robert.Lor@Sun.COM
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Theo Schlossnagle <jesus@omniti.com>
Cc: Josh.Berkus@Sun.COM, PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
Date: Fri, 5 May 2006 08:22:59 -0400 (EDT)
Message-ID: <200605051222.k45CMxC22692@candle.pha.pa.us> (raw)
In-Reply-To: <445A5364.4090307@Sun.COM>
Done, for Solaris and x86.
---------------------------------------------------------------------------
Robert Lor wrote:
>
> Hi Bruce,
>
> The new SPARC assembly file src/backend/port/tas/solaris_sparc.s uses /
> instead of ! for comments, and as a result the compile fails with Sun
> Studio 11. Please modify the first 3 lines to look like the following.
>
> > !=======================================================================
> > ! solaris_sparc.s -- compare and swap for solaris_sparc
> > !=======================================================================
>
>
>
> Thanks!
>
> -Robert
>
>
> Bruce Momjian wrote On 04/29/06 17:16,:
>
> >Tom Lane wrote:
> >
> >
> >>Theo Schlossnagle <jesus@omniti.com> writes:
> >>
> >>
> >>>I'd remind everyone that the spinlock stuff is entirely optional at
> >>>build time.
> >>>
> >>>
> >>Not really. The performance hit for not having hardware spinlocks is
> >>so severe that it's not considered a reasonable fallback.
> >>
> >>
> >>
> >>>I also think it immensely useful to replace all of the tas subsystem
> >>>with cas so that one could reliabily lock these atomics with the process
> >>>id of the locker.
> >>>
> >>>
> >>I cannot, ever once in my years working on Postgres, remember having
> >>wanted such a thing. I am strongly against mucking with the spinlock
> >>code for mere aesthetics --- it's too fragile and hard to test,
> >>especially on platforms you don't have ready access to.
> >>
> >>In short, it ain't broken and we don't need to fix it.
> >>
> >>
> >
> >Agreed. Should the new Solaris ASM code be modified?
> >
> >
> >
>
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: pgman@candle.pha.pa.us, Robert.Lor@Sun.COM, tgl@sss.pgh.pa.us, jesus@omniti.com
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
In-Reply-To: <200605051222.k45CMxC22692@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox