pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: List pgsql-patches <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] Hint Bits and Write I/O
Date: Sat, 02 Aug 2008 00:24:46 -0400
Message-ID: <27349.1217651086@sss.pgh.pa.us> (raw)
In-Reply-To: <20080801231014.GM4321@alvh.no-ip.org>
References: <1211916951.4489.232.camel@ebony.site>
	<15901.1211931165@sss.pgh.pa.us>
	<1213797209.9468.126.camel@ebony.site>
	<87hcbfq71p.fsf@oxford.xeocode.com>
	<1214578938.3845.423.camel@ebony.site>
	<1214865781.3845.525.camel@ebony.site>
	<20080801231014.GM4321@alvh.no-ip.org>

Alvaro Herrera <alvherre@commandprompt.com> writes:
> I think it makes sense to commit this patch now, per previous
> discussions on which we have agreed to make incremental changes.

Yeah, but at the same time there is merit in the argument that the
proposed patch hasn't actually been proven to be usable for anything.
I would be a lot happier if there were even a trivial proof-of-concept
plugin example submitted with it, just to prove that there were no
showstopper problems in the plugin design, like failure to pass
essential information or not getting the locking straight.

> I'm just wondering if the change of usage_count from 16 to 8 bits was
> discussed and agreed?

Umm ... it was not, but given that we have logic in there to limit the
usage_count to 5 or so, it's hard to argue that there's a big problem.

I confess to not having read the patch in detail --- where did the other
8 bits go to?

			regards, tom lane



view thread (30+ messages)  latest in thread

Message-ID: <27349.1217651086@sss.pgh.pa.us>
Permalink:  ../27349.1217651086@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/27349.1217651086@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@commandprompt.com, simon@2ndquadrant.com
  Subject: Re: [HACKERS] Hint Bits and Write I/O
  In-Reply-To: <27349.1217651086@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox