pg.ddx.io pgsql-patches@postgresql.org mailing list archive help / color / mirror / Atom feed From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Emmanuel Cecchet <manu@frogthinker.org>
Cc: Nikhil Sontakke <nikhil.sontakke@enterprisedb.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1
Date: Thu, 6 Nov 2008 05:47:29 +0100
Message-ID: <3073cc9b0811052047o4ebe24b4vd0ab24fd3095d342@mail.gmail.com> (raw )
In-Reply-To: <490B5178.7070600@frogthinker.org >
References: <d3c4af540803210745j5ded6107r5871095a3aeb91af@mail.gmail.com >
<200803211518.m2LFIfJ12397@momjian.us >
<3073cc9b0810181308y91deed8wac2df9bc925200f5@mail.gmail.com >
<a301bfd90810220221j389258d5n6940bb8d2f550709@mail.gmail.com >
<3073cc9b0810220743p11526a74ve9769a416c1707cf@mail.gmail.com >
<3073cc9b0810220744y987173avd560a33fcb58ede5@mail.gmail.com >
<a301bfd90810230541h50fd7778q5f84498f7461b6f8@mail.gmail.com >
<a301bfd90810310750pf108c69x36499546f406650f@mail.gmail.com >
<490B5178.7070600@frogthinker.org >
On Fri, Oct 31, 2008 at 7:42 PM, Emmanuel Cecchet <manu@frogthinker.org> wrote:
> Hi Nikhil,
>
i'm looking at this one:
http://archives.postgresql.org/message-id/a301bfd90810310750pf108c69x36499546f406650f@mail.gmail.com
> Here are a couple of questions:
> - How do you ALTER the table to repartition it?
fair question. but the patch was advertized to only automate some
tasks that we do manually... so keeping the same limitations seems
reasonably to me...
> - Another option is to have a separate trigger per child table and chain
> them to the master table. For example something like:
that sounds like a lot of overhead...
---------------
Now, about the patch...
- seems strange the need to create plpgsql language before we can
create any partitioned table but given that the trigger is a plpgsql
function (and a c function can't be used because we could need to add
new partitions) it seems necesary... ideas?
- the update part of the trigger looks very simplistic... if the new
values isn't in the range accepted by the partition it errors out
because of the check constraint... can't we be a little smarter,
delete from the actual partition and insert in the new one...
for the rest, the patch passes all regression tests and seems to work
as advertized....
--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
AsesorÃa y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157
view thread (59+ messages) latest in thread
Message-ID: <3073cc9b0811052047o4ebe24b4vd0ab24fd3095d342@mail.gmail.com>
Permalink: ../3073cc9b0811052047o4ebe24b4vd0ab24fd3095d342@mail.gmail.com/
Also on: postgresql.org/message-id/3073cc9b0811052047o4ebe24b4vd0ab24fd3095d342@mail.gmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: jcasanov@systemguards.com.ec, manu@frogthinker.org, nikhil.sontakke@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1
In-Reply-To: <3073cc9b0811052047o4ebe24b4vd0ab24fd3095d342@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox