From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: Hiroshi Saito <z-saito@guitar.ocn.ne.jp>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] Solve a problem of LC_TIME of windows.
Date: Tue, 11 Nov 2008 01:12:29 -0500
Message-ID: <3073cc9b0811102212n278644a8o7169f7c5ea562081@mail.gmail.com> (raw)
In-Reply-To: <20081104094301.7EE8.52131E4D@oss.ntt.co.jp>
References: <13239.1225589369@sss.pgh.pa.us>
<2C940A1672E743439355545C5DB15786@HIRO57887DE653>
<20081104094301.7EE8.52131E4D@oss.ntt.co.jp>
On Mon, Nov 3, 2008 at 8:41 PM, ITAGAKI Takahiro
<itagaki.takahiro@oss.ntt.co.jp> wrote:
> Hello, Saito-san:
>
> "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> wrote:
>> next patch is this.
>
> I'm reviewing your patch and cleanup some parts:
i'm confused, original patch has this signature:
+ conv_strftime(char *src, size_t len, const char *format, const struct tm *tm)
your's has:
+strftime_win32(char *dst, size_t dstlen, const char *format, const
struct tm *tm
you change all src for dst, just a variable name decision but a
radical one... why was that (i honestly doesn't understand this patch
very well ;)?
--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
AsesorÃa y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-patches@postgresql.org
Cc: jcasanov@systemguards.com.ec, itagaki.takahiro@oss.ntt.co.jp, z-saito@guitar.ocn.ne.jp, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] Solve a problem of LC_TIME of windows.
In-Reply-To: <3073cc9b0811102212n278644a8o7169f7c5ea562081@mail.gmail.com>
References: <13239.1225589369@sss.pgh.pa.us> <2C940A1672E743439355545C5DB15786@HIRO57887DE653> <20081104094301.7EE8.52131E4D@oss.ntt.co.jp> <3073cc9b0811102212n278644a8o7169f7c5ea562081@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox