pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Merlin Moncure <mmoncure@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Chernow <ac@esilo.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Patches (PostgreSQL) <pgsql-patches@postgresql.org>
Subject: Re: libpq object hooks
Date: Fri, 16 May 2008 11:21:15 -0400
Message-ID: <482DA66B.4000901@dunslane.net> (raw)
In-Reply-To: <b42b73150805160813x7fba1ccaif0c7d28cc2d53f4d@mail.gmail.com>
References: <b42b73150804301323i18b00019i62e765708abb65aa@mail.gmail.com>
	<b42b73150805150852m7b3c28fai2d7a4497c84118b2@mail.gmail.com>
	<6044.1210867771@sss.pgh.pa.us>
	<482C77E5.1060500@esilo.com>
	<9458.1210875556@sss.pgh.pa.us>
	<482C82BA.3090100@esilo.com>
	<9867.1210877054@sss.pgh.pa.us>
	<482CD76E.6000202@esilo.com>
	<b42b73150805160628y3c175608hc383187951206448@mail.gmail.com>
	<17177.1210949948@sss.pgh.pa.us>
	<b42b73150805160813x7fba1ccaif0c7d28cc2d53f4d@mail.gmail.com>



Merlin Moncure wrote:
>   
>> Also, even if varargs are safe they'd be notationally unpleasant
>> in the extreme.  varargs are just a PITA to work with --- you'd have
>> to do all the decoding in the first-level hook routine, even for
>> items you weren't going to use.  With something like the above
>> all you need is a switch() and some pointer casts.
>>     
>
> Switch, plus struct (basically a union) will do the trick nicely.  Can
> it be a formal union, or is it better as a void*?
>
> The main issue was how what we called the 'hook data' was passed back
> and forth.  We'll get a patch up.
>
>
>   

All of this is getting quite a long way from what was in the commitfest 
queue. Do we still want to try to get this in this cycle, or should it 
be marked returned to author for more work?

cheers

andrew



view thread (45+ messages)  latest in thread

Message-ID: <482DA66B.4000901@dunslane.net>
Permalink:  ../482DA66B.4000901@dunslane.net/
Also on:    postgresql.org/message-id/482DA66B.4000901@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: andrew@dunslane.net, mmoncure@gmail.com, tgl@sss.pgh.pa.us, ac@esilo.com, alvherre@commandprompt.com
  Subject: Re: libpq object hooks
  In-Reply-To: <482DA66B.4000901@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox