From: Teodor Sigaev <teodor@sigaev.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] GIN improvements
Date: Tue, 22 Jul 2008 21:22:32 +0400
Message-ID: <48861758.4070507@sigaev.ru> (raw)
In-Reply-To: <29437.1216742605@sss.pgh.pa.us>
References: <483FD205.4090904@sigaev.ru>
<486BC501.6060605@sigaev.ru>
<27880.1215810535@sss.pgh.pa.us>
<487A6E0C.3090600@sigaev.ru>
<29437.1216742605@sss.pgh.pa.us>
> I started to look at this. I don't understand why VACUUM does an insert
> cleanup before starting to vacuum, but VACUUM FULL doesn't?
Hmm. May be I missed something, but I don't understand where and what... I tried
to track all places of ambultdelete call. aminsertcleanup should be called
before any ambulkdelete, because ambulkdelete doesn't scan pending list which
can store items to be deleted and hence index will store item pointers to absent
tuples.
> needed is the one at vacuum startup, which tempts me to propose that
> the new AM entry point should be called "amvacuumstartup", instead of
> wiring in the assumption that what it's for is specifically cleanup
> of insertions.
That's possible but inserts into index should be forbidden between
amvacuumstartup and last call of ambulkdelete.
>
> Comments? I can make the change if you think it's okay --- I'm busy
> cleaning up docs and comments at the moment.
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: teodor@sigaev.ru, tgl@sss.pgh.pa.us, oleg@sai.msu.su, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] GIN improvements
In-Reply-To: <48861758.4070507@sigaev.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox