From: Heikki Linnakangas <heikki@enterprisedb.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Greg Smith <gsmith@gregsmith.com>
Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Dave Page <dpage@pgadmin.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: List pgsql-patches <pgsql-patches@postgresql.org>
Cc: Martin Zaun <Martin.Zaun@Sun.COM>
Subject: Re: [PATCHES] odd output in restore mode
Date: Tue, 29 Jul 2008 17:27:23 +0300
Message-ID: <488F28CB.8000201@enterprisedb.com> (raw)
In-Reply-To: <488DEE79.4010004@dunslane.net>
References: <200807011520.m61FKhZ20311@momjian.us>
<48867904.9090001@sun.com>
<1216810783.3894.602.camel@ebony.2ndQuadrant>
<48877AC0.7070603@enterprisedb.com>
<48873C7E.EE98.0025.0@wicourts.gov>
<Pine.GSO.4.64.0807281136140.26479@westnet.com>
<488DEE79.4010004@dunslane.net>
Andrew Dunstan wrote:
>
>
> Greg Smith wrote:
>> On Wed, 23 Jul 2008, Kevin Grittner wrote:
>>
>>> In our scripts we handle this by copying to a temp directory on the
>>> same mount point as the archive directory and doing a mv to the
>>> archive location when the copy is successfully completed. I think
>>> that this even works on Windows. Could that just be documented as a
>>> strong recommendation for the archive script?
>>
>> This is exactly what I always do. I think the way cp is shown in the
>> examples promotes what's really a bad practice for lots of reasons,
>> this particular problem being just one of them.
>>
>> I've been working on an improved archive_command shell script that I
>> expect to submit for comments and potential inclusion in the
>> documentation as a better base for other people to build on. This is
>> one of the options for how it can operate. It would be painful but not
>> impossible to convert a subset of that script to run under Windows as
>> well, at least enough to cover this particular issue.
>
> A Perl script using the (standard) File::Copy module along with the
> builtin function rename() should be moderately portable. It would to be
> nice not to have to maintain two scripts.
It's also not very nice to require a Perl installation on Windows, just
for a replacement of Copy. Would a simple .bat script work?
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: heikki@enterprisedb.com, andrew@dunslane.net, gsmith@gregsmith.com, Kevin.Grittner@wicourts.gov, simon@2ndquadrant.com, bruce@momjian.us, dpage@pgadmin.org, pgsql-hackers@postgresql.org, Martin.Zaun@Sun.COM
Subject: Re: [PATCHES] odd output in restore mode
In-Reply-To: <488F28CB.8000201@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox