From: Bryce Nesbitt <bryce2@obviously.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: New pg_dump patch, --no-stats flag, disables sending to statistics collector
Date: Tue, 20 Jan 2009 16:35:36 -0800
Message-ID: <49766DD8.7080300@obviously.com> (raw)
In-Reply-To: <497652E2.4030902@agliodbs.com>
References: <200901202154.n0KLsmL11525@momjian.us>
<497652E2.4030902@agliodbs.com>
Josh Berkus wrote:
> I'd argue that it is generally desired (or some convenient workaround)
> but not urgently so. I'd also argue that if we're going to have a
> --no-stats flag, it should exist for the other client ultilites as
> well; if I don't want pg_dump showing up, I probably don't want Vacuum
> showing up, or various other already-debugged maintenance routines.
>
> I'd suggest putting this into the first patch review for 8.5.
>
> --Josh
As pg_dumpall calls pg_dump, I think this is covered or at least
coverable. For vaccum, I've never seen that activity in stats? Can you
supply a more specific scenario where routine maintenance is harmfully
cluttering the stats table? A specific utility that needs attention?
For this feature I'm not so sure about "generally desired" -- I'll bet
most people don't even think about this. The question is among those
who DO think about it, what's the best behavior? Can it be argued that
excluding pg_dump is "generally desirable", for the average use case?
If there is not enough demand for a dedicated flag, I may submit a man
page patch documenting the Do-It-Yourself solution proposed by Greg
Smith, or the one proposed by Tom Lane.
G'day
-Bryce
PS: Note that no respondent on the psql user's lists thought excluding
pg_dump was even possible -- so that at least argues for desirability of
instructional material :-).
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: bryce2@obviously.com, pgsql-hackers@postgresql.org
Subject: Re: New pg_dump patch, --no-stats flag, disables sending to statistics collector
In-Reply-To: <49766DD8.7080300@obviously.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox