From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gregory Stark <stark@enterprisedb.com>
Cc: pgsql-patches@postgresql.org, "Jan Wieck" <JanWieck@Yahoo.com>
Subject: Re: Proposed patch to change TOAST compression strategy
Date: Fri, 07 Mar 2008 18:23:12 -0500
Message-ID: <8565.1204932192@sss.pgh.pa.us> (raw)
In-Reply-To: <87ir0mo8ot.fsf@oxford.xeocode.com>
References: <26048.1203271939@sss.pgh.pa.us>
<87ir0mo8ot.fsf@oxford.xeocode.com>
Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>> * Adds an early-failure path to the compressor as suggested by Jan:
>> if it's been unable to find even one compressible substring in the
>> first 1KB (parameterizable), assume we're looking at incompressible
>> input and give up. (There are various ways this could be done, but
>> this way seems to add the least overhead to the compressor's inner
>> loop.)
> I'm not sure how to test the rest of it, but this bit seems testable. I fear
> this may be too conservative. Even nigh incompressible data will find a few
> backreferences.
> I'll try some tests and see.
On the strength of Teodor's favorable test, I went ahead and applied
this patch as-is. We can certainly tweak the compressor logic again
if you can show an improvement by changing it further.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: tgl@sss.pgh.pa.us, stark@enterprisedb.com, JanWieck@Yahoo.com
Subject: Re: Proposed patch to change TOAST compression strategy
In-Reply-To: <8565.1204932192@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox