pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] VACUUM Improvements - WIP Patch
Date: Mon, 14 Jul 2008 11:23:45 -0400
Message-ID: <8741.1216049025@sss.pgh.pa.us> (raw)
In-Reply-To: <2e78013d0807132050j16cdc558s4dc3f889371a937d@mail.gmail.com>
References: <2e78013d0806092232h6ca15ffejcbcd24e88401308f@mail.gmail.com>
	<21751.1215883933@sss.pgh.pa.us>
	<2e78013d0807132050j16cdc558s4dc3f889371a937d@mail.gmail.com>

"Pavan Deolasee" <pavan.deolasee@gmail.com> writes:
> (taking the discussions to -hackers)
> On Sat, Jul 12, 2008 at 11:02 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (2) It achieves speedup of VACUUM by pushing work onto subsequent
>> regular accesses of the page, which is exactly the wrong thing.
>> Worse, once you count the disk writes those accesses will induce it's
>> not even clear that there's any genuine savings.

> Well in the worst case that is true. But in most other cases, the
> second pass work will be combined with other normal activities and the
> overhead will be shared, at least there is a chance for that. I think
> there is a chance for delaying the work until there is any real need
> for that e.g. INSERT or UPDATE on the page which would require a free
> line pointer.

That's just arm-waving: right now, pruning will be done by the next
*reader* of the page, whether or not he has any intention of *writing*
it.   With no proposal on the table for improving that situation,
I don't see any credibility in arguing for over-complicating VACUUM
on the grounds that it might happen someday.  In any case, the work
that is supposed to be done by VACUUM is being pushed to a foreground
query, which I find to be completely against our design principles.

>> It strikes me that what you are trying to do here is compensate for
>> a bad decision in the HOT patch, which was to have VACUUM's first
>> pass prune/defrag a page even when we know we are going to have to
>> come back to that page later.  What about trying to fix things so
>> that if the page contains line pointers that need to be removed,
>> the first pass doesn't dirty it at all, but leaves all the work
>> to be done at the second visit?

> I am not against this idea. Just that it still requires us double scan
> of the main table and that's exactly what we are trying to avoid with
> this patch.

The part of the argument that I found convincing was trying to reduce
the write traffic (especially WAL log output), not avoiding a second
read.  And the fundamental point still remains: the work should be done
in background, not foreground.

			regards, tom lane



view thread (17+ messages)  latest in thread

Message-ID: <8741.1216049025@sss.pgh.pa.us>
Permalink:  ../8741.1216049025@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8741.1216049025@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-patches@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pavan.deolasee@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [PATCHES] VACUUM Improvements - WIP Patch
  In-Reply-To: <8741.1216049025@sss.pgh.pa.us>
  References: <2e78013d0806092232h6ca15ffejcbcd24e88401308f@mail.gmail.com> <21751.1215883933@sss.pgh.pa.us> <2e78013d0807132050j16cdc558s4dc3f889371a937d@mail.gmail.com> <8741.1216049025@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox