From: Marko Kreen <markokr@gmail.com>
To: daveg <daveg@sonic.net>
Cc: pgsql-patches@postgresql.org, hari@efrontier.com, "Postgres Hackers" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] pg_dump lock timeout
Date: Thu, 3 Jul 2008 11:15:10 +0300
Message-ID: <e51f66da0807030115y2520ecbdie9d17f6312636f3@mail.gmail.com> (raw)
In-Reply-To: <20080511113047.GV5673@sonic.net>
References: <20080511113047.GV5673@sonic.net>
On 5/11/08, daveg <daveg@sonic.net> wrote:
> Attached is a patch to add a commandline option to pg_dump to limit how long
> pg_dump will wait for locks during startup.
My quick review:
- It does not seem important enough to waste a short option on.
Having only long option should be enough.
- It would be more polite to do SET LOCAL instead SET.
(Eg. it makes safer to use pg_dump through pooler.)
- The statement_timeout is set back with "statement_timeout = default"
Maybe it would be better to do "= 0" here? Although such decision
would go outside the scope of the patch, I see no sense having
any other statement_timeout for actual dumping.
--
marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: markokr@gmail.com, daveg@sonic.net, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] pg_dump lock timeout
In-Reply-To: <e51f66da0807030115y2520ecbdie9d17f6312636f3@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox