pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <robertmhaas@gmail.com>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jon Nelson <jnelson+pgsql@jamponi.net>
Cc: " <pgsql-bugs@postgresql.org>
Cc: " <pgsql-bugs@postgresql.org>
Subject: Re: [PERFORM] typoed column name, but postgres didn't grump
Date: Fri, 29 Oct 2010 17:48:59 -0400
Message-ID: <0E628919-9700-47B7-9436-41CEB09DC94F@gmail.com> (raw)
In-Reply-To: <4CCAE6650200002500036FC3@gw.wicourts.gov>
References: <AANLkTimYMA8D2h4-jHK5vD032jWwig1iJmW6uF-3i=Bx@mail.gmail.com>
	<4480.1288374498@sss.pgh.pa.us>
	<4CCACE6E0200002500036F95@gw.wicourts.gov>
	<6240.1288379246@sss.pgh.pa.us>
	<AANLkTim35FrP1EyZRmnotKSw=2rq8JNVutkitn9PXwFp@mail.gmail.com>
	<4CCADE440200002500036FB2@gw.wicourts.gov>
	<4CCADE440200002500036FB2@gw.wicourts.gov>
	<8216.1288383162@sss.pgh.pa.us>
	<4CCAE6650200002500036FC3@gw.wicourts.gov>

On Oct 29, 2010, at 4:21 PM, "Kevin Grittner" <Kevin.Grittner@wicourts.gov> wrote:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> "Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
>>> Robert Haas <robertmhaas@gmail.com> wrote:
>>>>> I think if I had to pick a proposal, I'd say we should disable
>>>>> #2 for the specific case of casting a composite type to
>>>>> something else.
>> 
>>>> Well, then let's do that.  It's not the exact fix I'd pick, but
>>>> it's clearly better than nothing, so I'm willing to sign on to
>>>> it as a compromise position.
>> 
>>> So, I'd rather scrap #2 entirely; but if that really would break
>>> much working code, +1 for ignoring it when it would cast a
>>> composite to something else.
>> 
>> Well, assuming for the sake of argument that we have consensus on
>> fixing it like that, is this something we should just do in HEAD,
>> or should we back-patch into 8.4 and 9.0?  We'll be hearing about
>> it nigh indefinitely if we don't, but on the other hand this isn't
>> the kind of thing we like to change in released branches.
> 
> I can't see back-patching it -- it's a behavior change.
> 
> On the bright side, in five years after the release where it's
> removed, it will be out of support.  Problem reports caused by it
> should be tapering off before that....

Yeah, I think we're going to have to live with it, at least for 8.4.  One could make an argument that 9.0 is new enough we could get away with a small behavior change to avoid a large amount of user confusion.  But that may be a self-serving argument based on wanting to tamp down the bug reports rather than a wisely considered policy decision...  so I'm not sure I quite buy it.

...Robert


view thread (23+ messages)  latest in thread

Message-ID: <0E628919-9700-47B7-9436-41CEB09DC94F@gmail.com>
Permalink:  ../0E628919-9700-47B7-9436-41CEB09DC94F@gmail.com/
Also on:    postgresql.org/message-id/0E628919-9700-47B7-9436-41CEB09DC94F@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: robertmhaas@gmail.com, Kevin.Grittner@wicourts.gov, tgl@sss.pgh.pa.us, jnelson+pgsql@jamponi.net, pgsql-bugs@postgresql.org
  Subject: Re: [PERFORM] typoed column name, but postgres didn't grump
  In-Reply-To: <0E628919-9700-47B7-9436-41CEB09DC94F@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox